webbrowser-app

Merge lp:~rpadovani/webbrowser-app/1351149 into lp:webbrowser-app

  1. 1351149
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 768
Merged at revision: 794
Proposed branch: lp:~rpadovani/webbrowser-app/1351149
Merge into: lp:webbrowser-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/webbrowser/Browser.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/webbrowser-app/1351149
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+239212@code.launchpad.net

Commit message

Fixed #1351149 - Opening a page from the history view should do it in a new tab

Description of the change

Fixed #1351149 - Opening a page from the history view should do it in a new tab

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:768
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1205/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6133
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4170
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/404
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/404
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/404/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/404
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5760
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7385
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7385/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14956
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3531
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4520
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4520/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1205/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:768
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1243/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/19
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/19/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15500
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/14
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/14/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1243/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

The change looks good, but now I can’t find any reference to it in the design specification. Approving, but not landing until I get confirmation from Giorgio that it’s still the desired behaviour.

review: Approve
Revision history for this message
Olivier Tilloy (osomon) wrote :

Got confirmation from Giorgio, let’s merge!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2014-10-07 08:32:45 +0000
3+++ src/app/webbrowser/Browser.qml 2014-10-22 15:09:59 +0000
4@@ -326,7 +326,7 @@
5 anchors.fill: parent
6
7 onHistoryEntryClicked: {
8- currentWebview.url = url
9+ browser.openUrlInNewTab(url, true, true)
10 done()
11 }
12 onHistoryEntryRemoved: browser.historyModel.removeEntryByUrl(url)

Subscribers

People subscribed via source and target branches

to status/vote changes: