The Webapps-core project

Merge lp:~rpadovani/webapps-core/facebook_content_exchange_source into lp:webapps-core

  1. facebook_content_exchange_source
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Merged at revision: 105
Proposed branch: lp:~rpadovani/webapps-core/facebook_content_exchange_source
Merge into: lp:webapps-core
Diff against target: 13 lines (+2/-1)
1 file modified
webapp-facebook/webapp-facebook.json (+2/-1)
To merge this branch: bzr merge lp:~rpadovani/webapps-core/facebook_content_exchange_source
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
Review via email: mp+240591@code.launchpad.net

Commit message

Added content_exchange_source to manifest.json of Facebook webapp

Description of the change

If in a conversation on facebook I receive an image I can click on it, and there is a link to download it. When I click on the link, it opens the content-hub, it shows the gallery as usual, and when I click on it the content hub close itself, but nothing else happens - the file isn't downloaded and no error is raised.

This is due lack of content_exchange_source in manifest.json

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM and tested,

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'webapp-facebook/webapp-facebook.json'
2--- webapp-facebook/webapp-facebook.json 2014-09-24 16:45:27 +0000
3+++ webapp-facebook/webapp-facebook.json 2014-11-04 15:42:20 +0000
4@@ -7,7 +7,8 @@
5 "video",
6 "webview",
7 "location",
8- "content_exchange"
9+ "content_exchange",
10+ "content_exchange_source"
11 ],
12 "policy_version": 1.2
13 }

Subscribers

People subscribed via source and target branches

to all changes: