Merge lp:~rpadovani/ubuntu-weather-app/1200600 into lp:ubuntu-weather-app/obsolete.trunk
Proposed by
Riccardo Padovani
Status: | Merged |
---|---|
Approved by: | Martin Borho |
Approved revision: | 62 |
Merged at revision: | 62 |
Proposed branch: | lp:~rpadovani/ubuntu-weather-app/1200600 |
Merge into: | lp:ubuntu-weather-app/obsolete.trunk |
Diff against target: |
33 lines (+12/-0) 1 file modified
components/AddLocationPage.qml (+12/-0) |
To merge this branch: | bzr merge lp:~rpadovani/ubuntu-weather-app/1200600 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Nekhelesh Ramananthan (community) | Approve | ||
Martin Borho | Approve | ||
Review via email: mp+174405@code.launchpad.net |
Commit message
Added "No city" in city list when no city is found.
See #1200600
Description of the change
Added "No city" in city list when no city is found.
See #1200600
To post a comment you must log in.
Thanks for the fix, that was fast!
But one request:
By using only "if (citiesModel.count < 1) {" in the onMessage handler instead of "if (!number) {", you could remove the "number" var. Leads to less code.
Cheers
Martin