Merge lp:~rpadovani/ubuntu-calculator-app/tempResultOnlyInParenthesis into lp:ubuntu-calculator-app

Proposed by Riccardo Padovani
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 249
Merged at revision: 249
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/tempResultOnlyInParenthesis
Merge into: lp:ubuntu-calculator-app
Diff against target: 12 lines (+1/-1)
1 file modified
app/ubuntu-calculator-app.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/tempResultOnlyInParenthesis
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+279473@code.launchpad.net

Commit message

Remove * from operators with priority

Description of the change

We try to help users calculating temporary results. Unfortunately at the moment the feature is confusing, 'cause we calculate the temporary result just after a * operator.

So if the users write
3*3^3
we print
9^3

Then user presses = and we print 27 (that is right) but is confusing because 9^3 = 81.

So we can calculate temporary result only in the parenthesis, cause nothing has priorty > than parenthesis

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Work ok for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ubuntu-calculator-app.qml'
2--- app/ubuntu-calculator-app.qml 2015-11-28 20:44:02 +0000
3+++ app/ubuntu-calculator-app.qml 2015-12-03 16:45:49 +0000
4@@ -182,7 +182,7 @@
5 }
6
7 // Add here operators that have always priority
8- if ((visual.toString() === "*") || (visual.toString() === ")")) {
9+ if (visual.toString() === ")") {
10 isFormulaIsValidToCalculate = true;
11 }
12 }

Subscribers

People subscribed via source and target branches