Ubuntu Calculator App

Merge lp:~rpadovani/ubuntu-calculator-app/fixFavouriteGhost into lp:ubuntu-calculator-app

  1. fixFavouriteGhost
  2. Merge into trunk
Proposed by Riccardo Padovani on 2015-03-26
Status: Merged
Approved by: Bartosz Kosiorek on 2015-03-26
Approved revision: 140
Merged at revision: 140
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/fixFavouriteGhost
Merge into: lp:ubuntu-calculator-app
Diff against target: 12 lines (+1/-1)
1 file modified
app/ui/FavouritePage.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/fixFavouriteGhost
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-03-26
Bartosz Kosiorek 2015-03-26 Approve on 2015-03-26
Review via email: mp+254282@code.launchpad.net

Commit Message

Fix favourite that remains in favourite page after deletion

Description of the Change

Fix favourite that remains in favourite page after deletion

To post a comment you must log in.
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Bartosz Kosiorek (gang65) wrote :

It is working perfectly for me.

review: Approve
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/FavouritePage.qml'
2--- app/ui/FavouritePage.qml 2015-03-11 08:31:12 +0000
3+++ app/ui/FavouritePage.qml 2015-03-26 16:23:49 +0000
4@@ -52,7 +52,7 @@
5 model: calculationHistory.getContents();
6
7 delegate: ListItem.Empty {
8- visible: model.isFavourite
9+ visible: model.isFavourite && model.dbId != -1
10 height: visible ? units.gu(6) : 0
11
12 MouseArea {

Subscribers

People subscribed via source and target branches