Code review comment for lp:~rpadovani/ubuntu-calculator-app/closeBrackets150127

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Hi Bartosz,

your idea is good, but I think it is for advanced users: a normal user IMO wants to do calc as fast as possible.

When I implemented this I was thinking to sqrt. I need to know the sqrt of a number (e.g 9). With this branch a user needs only 3 clicks:
- Open the app
- Click sqrt button
- Click 9
- Click =

The app then complete the calc with )

On the other side, with actual implementation (and with yours too) user needs to click 4 buttons and do two swipes:
- Open the app
- Click sqrt button
- Click 9
- (Maybe click = and see the popup)
- Swipe right
- Click )
- Swipe left
- Click (

So, both approaches have their advantages. I ping popey and gcollura to have feedbacks :-)

« Back to merge proposal