Merge lp:~rpadovani/ubuntu-calculator-app/bignumber141224 into lp:ubuntu-calculator-app

Proposed by Riccardo Padovani on 2014-12-24
Status: Merged
Approved by: Riccardo Padovani on 2015-01-09
Approved revision: 49
Merged at revision: 56
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/bignumber141224
Merge into: lp:ubuntu-calculator-app
Diff against target: 12 lines (+1/-1)
1 file modified
app/engine/math.js (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/bignumber141224
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-01-09
Alan Pope 🍺🐧🐱 πŸ¦„ 2014-12-24 Approve on 2015-01-05
Review via email: mp+245362@code.launchpad.net

Commit Message

Use bignumber as default

Description of the Change

Use bignumber as default, this help us to avoid overflow and to have strange results with little numbers (try 0.1+0.3, you have something like 0.4000000000000000004)

To post a comment you must log in.

Looks good!

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/engine/math.js'
2--- app/engine/math.js 2014-11-28 00:01:50 +0000
3+++ app/engine/math.js 2015-01-08 15:26:27 +0000
4@@ -115,7 +115,7 @@
5 matrix: 'matrix',
6
7 // type of default number output. Choose 'number' (default) or 'bignumber'
8- number: 'number',
9+ number: 'bignumber',
10
11 // number of significant digits in BigNumbers
12 precision: 64,

Subscribers

People subscribed via source and target branches