Merge lp:~rpadovani/ubuntu-calculator-app/24Sep2013 into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Riccardo Padovani
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 157
Merged at revision: 158
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/24Sep2013
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 54 lines (+7/-4)
1 file modified
Simple/Screen.qml (+7/-4)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/24Sep2013
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+187334@code.launchpad.net

Commit message

Some updates to fix graphic issues on device:
- Add trash.png, our Icon wasn't on device
- Fixed text size in a couple of text

Description of the change

Some updates to fix graphic issues on device:
- Add trash.png, our Icon wasn't on device
- Fixed text size in a couple of text

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Simple/Screen.qml'
2--- Simple/Screen.qml 2013-09-24 19:51:16 +0000
3+++ Simple/Screen.qml 2013-09-24 20:13:21 +0000
4@@ -45,9 +45,9 @@
5 Item {
6 width: parent.width
7 height: units.gu(4)
8- Icon {
9+ Image {
10 anchors.centerIn: parent
11- name: "user-trash-symbolic"
12+ source: Qt.resolvedUrl("../images/trash.png")
13 width: units.gu(2)
14 height: units.gu(2)
15 }
16@@ -60,6 +60,7 @@
17 color: "#9094AA"
18 text: _content.x > root.width / 3 ? "Release To Delete" : "Pull To Delete"
19 font.italic: true
20+ font.pixelSize: FontUtils.sizeToPixels("medium")
21 }
22 }
23 }
24@@ -76,9 +77,9 @@
25 Item {
26 width: parent.width
27 height: units.gu(4)
28- Icon {
29+ Image {
30 anchors.centerIn: parent
31- name: "user-trash-symbolic"
32+ source: Qt.resolvedUrl("../images/trash.png")
33 width: units.gu(2)
34 height: units.gu(2)
35 }
36@@ -91,6 +92,7 @@
37 color: "#9094AA"
38 text: _content.x < -root.width / 3 ? "Release To Delete" : "Pull To Delete"
39 font.italic: true
40+ font.pixelSize: FontUtils.sizeToPixels("medium")
41 }
42 }
43 }
44@@ -113,6 +115,7 @@
45 color: "#FFFFFF"
46
47 text: i18n.tr("Delete this calculation?")
48+ font.pixelSize: FontUtils.sizeToPixels("medium")
49 }
50
51 Button {
52
53=== added file 'images/trash.png'
54Binary files images/trash.png 1970-01-01 00:00:00 +0000 and images/trash.png 2013-09-24 20:13:21 +0000 differ

Subscribers

People subscribed via source and target branches