Merge lp:~rpadovani/telegram-app/scrollbar into lp:telegram-app/app-dev

Proposed by Riccardo Padovani
Status: Merged
Approved by: Mihir Soni
Approved revision: 106
Merged at revision: 108
Proposed branch: lp:~rpadovani/telegram-app/scrollbar
Merge into: lp:telegram-app/app-dev
Diff against target: 43 lines (+12/-0)
3 files modified
ui/ContactsPage.qml (+4/-0)
ui/DialogPage.qml (+4/-0)
ui/DialogsPage.qml (+4/-0)
To merge this branch: bzr merge lp:~rpadovani/telegram-app/scrollbar
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Review via email: mp+237653@code.launchpad.net

Commit message

Added scrollbar to listviews

Description of the change

Added scrollbar to listviews.

For now they uses default colors, that are pretty invisible in our app.

To post a comment you must log in.
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me tested on device.
It is showing light scrollbar inside listview.

Thanks Riccardo.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ui/ContactsPage.qml'
2--- ui/ContactsPage.qml 2014-10-07 10:33:00 +0000
3+++ ui/ContactsPage.qml 2014-10-08 17:51:45 +0000
4@@ -204,6 +204,10 @@
5 }
6 }
7 }
8+
9+ Scrollbar {
10+ flickableItem: contactListView
11+ }
12 }
13
14 ContactImport {
15
16=== modified file 'ui/DialogPage.qml'
17--- ui/DialogPage.qml 2014-10-07 10:56:56 +0000
18+++ ui/DialogPage.qml 2014-10-08 17:51:45 +0000
19@@ -256,6 +256,10 @@
20 }
21 }
22 }
23+
24+ Scrollbar {
25+ flickableItem: list
26+ }
27 }
28 }
29
30
31=== modified file 'ui/DialogsPage.qml'
32--- ui/DialogsPage.qml 2014-09-24 13:45:19 +0000
33+++ ui/DialogsPage.qml 2014-10-08 17:51:45 +0000
34@@ -145,5 +145,9 @@
35 return 0;
36 }
37 } // ListView
38+
39+ Scrollbar {
40+ flickableItem: dialogsListView
41+ }
42 }
43 }

Subscribers

People subscribed via source and target branches