Merge lp:~rpadovani/telegram-app/groupsDefaultAvatar into lp:telegram-app/app-dev

Proposed by Riccardo Padovani
Status: Merged
Approved by: Michał Karnicki
Approved revision: 136
Merged at revision: 138
Proposed branch: lp:~rpadovani/telegram-app/groupsDefaultAvatar
Merge into: lp:telegram-app/app-dev
Diff against target: 49 lines (+12/-11)
2 files modified
js/avatar.js (+11/-10)
ui/DialogsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/telegram-app/groupsDefaultAvatar
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve
Review via email: mp+239072@code.launchpad.net

Commit message

When in a group chat there isn't any image, show default group image instead of single user one

Description of the change

When in a group chat there isn't any image, show default group image instead of single user one

To post a comment you must log in.
136. By Riccardo Padovani

Better implementation of avatar.js

Revision history for this message
Michał Karnicki (karni) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'js/avatar.js'
2--- js/avatar.js 2014-08-14 12:37:52 +0000
3+++ js/avatar.js 2014-10-21 15:16:17 +0000
4@@ -1,21 +1,22 @@
5 .pragma library
6
7 var AVATARS = [
8- ["#8179d7", "user_violet.png"],
9- ["#f2749a", "user_pink.png" ],
10- ["#7ec455", "user_green.png" ],
11- ["#f3c34a", "user_yellow.png"],
12- ["#5b9dd8", "user_blue.png" ],
13- ["#62b8cd", "user_aqua.png" ],
14- ["#ed8b4a", "user_orange.png"],
15- ["#d95848", "user_red.png" ]
16+ ["#8179d7", "_violet.png"],
17+ ["#f2749a", "_pink.png" ],
18+ ["#7ec455", "_green.png" ],
19+ ["#f3c34a", "_yellow.png"],
20+ ["#5b9dd8", "_blue.png" ],
21+ ["#62b8cd", "_aqua.png" ],
22+ ["#ed8b4a", "_orange.png"],
23+ ["#d95848", "_red.png" ]
24 ]
25
26 function getColor(userId) {
27 return AVATARS[userId % 8][0];
28 }
29
30-function getAvatar(userId) {
31- return AVATARS[userId % 8][1];
32+function getAvatar(userId, isGroup) {
33+ isGroup = isGroup || false;
34+ return (isGroup ? "group" : "user") + AVATARS[userId % 8][1];
35 }
36
37
38=== modified file 'ui/DialogsPage.qml'
39--- ui/DialogsPage.qml 2014-10-17 12:56:36 +0000
40+++ ui/DialogsPage.qml 2014-10-21 15:16:17 +0000
41@@ -84,7 +84,7 @@
42 property bool isChat: TLInputPeer.TypeInputPeerChat === model.peerType
43
44 image: model.thumbnail !== "" ? model.thumbnail
45- : Qt.resolvedUrl("../images/" + Avatar.getAvatar(model.id))
46+ : Qt.resolvedUrl("../images/" + Avatar.getAvatar(model.id, isGroup))
47 isGroup: isChat
48 title: model.name
49 sender: isChat ? model.topMessageFromFirstName + ": " : ""

Subscribers

People subscribed via source and target branches