Merge lp:~rpadovani/reminders-app/fixForReload into lp:reminders-app

Proposed by Riccardo Padovani
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 217
Merged at revision: 236
Proposed branch: lp:~rpadovani/reminders-app/fixForReload
Merge into: lp:reminders-app
Diff against target: 18 lines (+7/-2)
1 file modified
src/app/qml/components/PulldownListView.qml (+7/-2)
To merge this branch: bzr merge lp:~rpadovani/reminders-app/fixForReload
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+230775@code.launchpad.net

Commit message

Fixed pull down to refresh behavior

Description of the change

Fixed this wrong behavior:

<mzanetti> rpadovani: I also found a bug with the pulldown thingie
<mzanetti> rpadovani: pull it down to make the text change to "release to refresh"
<mzanetti> rpadovani: then drag it back up to the beginning and release
<mzanetti> it still refreshes
<mzanetti> should only if you release it below the threshold

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

much better

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/PulldownListView.qml'
2--- src/app/qml/components/PulldownListView.qml 2014-07-23 21:39:44 +0000
3+++ src/app/qml/components/PulldownListView.qml 2014-08-14 11:08:44 +0000
4@@ -47,8 +47,13 @@
5 }
6
7 onContentYChanged: {
8- if (priv.wasAtYBeginning && priv.initialContentY - contentY > units.gu(5)) {
9- priv.toBeReloaded = true
10+ if (dragging) {
11+ if (priv.wasAtYBeginning && priv.initialContentY - contentY > units.gu(5)) {
12+ priv.toBeReloaded = true
13+ }
14+ else {
15+ priv.toBeReloaded = false
16+ }
17 }
18 }
19

Subscribers

People subscribed via source and target branches