Merge lp:~rpadovani/reminders-app/bouncingProgressBar into lp:reminders-app

[Riccardo Padovani]

Added a bouncing ProgressBar

As discussed during last meeting, I added a bouncing ProgressBar that is visible when a note is loaded and on the main screen

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:260
http://91.189.93.70:8080/job/reminders-app-ci/530/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/577
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/577/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/226

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/530/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

inline

review: Needs Fixing

[lp:~rpadovani/reminders-app/bouncingProgressBar]

261. By Riccardo Padovani on 2014-10-07

better implementation of bouncing bar

262. By Riccardo Padovani on 2014-10-07

Fixed a typo about easing animation

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:261
http://91.189.93.70:8080/job/reminders-app-ci/540/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/761
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/761/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/236

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/540/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:262
http://91.189.93.70:8080/job/reminders-app-ci/541/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/762
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/762/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/237

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/541/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

ack

review: Approve

=== added file 'src/app/qml/components/BouncingProgressBar.qml'
--- src/app/qml/components/BouncingProgressBar.qml	1970-01-01 00:00:00 +0000
+++ src/app/qml/components/BouncingProgressBar.qml	2014-10-07 18:03:59 +0000
@@ -0,0 +1,48 @@
+/*
+ * Copyright: 2014 Canonical, Ltd
+ *
+ * This file is part of reminders-app
+ *
+ * reminders-app is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * reminders-app is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.3
+import Ubuntu.Components 1.1
+
+Item {
+    height: units.dp(3)
+    width: parent.width
+
+    onVisibleChanged: visible ? animation.start() : animation.stop()
+
+    Rectangle {
+        id: rectangle
+        anchors.fill: parent
+        color: UbuntuColors.orange
+        visible: animation.running // Avoid to show the orange bar before animation starts
+    }
+
+    SequentialAnimation {
+        id: animation
+        loops: Animation.Infinite
+
+        ParallelAnimation {
+            PropertyAnimation { target: rectangle; property: "anchors.leftMargin"; from: 0; to: width * 7/8; duration: 1000; easing.type: Easing.InOutQuad }
+            PropertyAnimation { target: rectangle; property: "anchors.rightMargin"; from: width * 7/8; to: 0; duration: 1000; easing.type: Easing.InOutQuad }
+        }
+        ParallelAnimation {
+            PropertyAnimation { target: rectangle; property: "anchors.leftMargin"; from: width * 7/8; to: 0; duration: 1000; easing.type: Easing.InOutQuad }
+            PropertyAnimation { target: rectangle; property: "anchors.rightMargin"; from: 0; to: width * 7/8; duration: 1000; easing.type: Easing.InOutQuad }
+        }
+    }
+}

=== modified file 'src/app/qml/ui/NoteView.qml'
--- src/app/qml/ui/NoteView.qml	2014-09-23 12:39:27 +0000
+++ src/app/qml/ui/NoteView.qml	2014-10-07 18:03:59 +0000
@@ -18,7 +18,7 @@
 
 import QtQuick 2.3
 import Ubuntu.Components 1.1
-import com.canonical.Oxide 1.0 
+import com.canonical.Oxide 1.0
 import Evernote 0.1
 import "../components"
 
@@ -34,14 +34,14 @@
         NotesStore.refreshNoteContent(root.note.guid)
     }
 
-    ActivityIndicator {
-        anchors.centerIn: parent
-        running: root.note.loading
-        visible: running
+    BouncingProgressBar {
+        anchors.top: parent.top
+        visible: root.note.loading
+        z: 10
     }
 
     WebContext {
-        id: webContext 
+        id: webContext
 
         userScripts: [
             UserScript {
@@ -56,7 +56,7 @@
         anchors { fill: parent}
 
         property string html: note.htmlContent
-        
+
         onHtmlChanged: {
             loadHtml(html, "file:///")
         }
@@ -85,7 +85,7 @@
                         NotesStore.saveNote(note.guid);
                         break;
                     }
-                } 
+                }
             }
         ]
      }

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2014-09-23 12:39:27 +0000
+++ src/app/qml/ui/NotesPage.qml	2014-10-07 18:03:59 +0000
@@ -193,10 +193,9 @@
             }
         }
 
-        ActivityIndicator {
-            anchors.centerIn: parent
-            running: notes.loading
-            visible: running
+        BouncingProgressBar {
+            anchors.top: parent.top
+            visible: notes.loading
         }
         Label {
             anchors.centerIn: parent