Ubuntu Notes app

Merge lp:~rpadovani/reminders-app/betterGradient into lp:reminders-app

  1. betterGradient
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: David Planella
Approved revision: 105
Merged at revision: 131
Proposed branch: lp:~rpadovani/reminders-app/betterGradient
Merge into: lp:reminders-app
Diff against target: 37 lines (+16/-5)
1 file modified
src/app/qml/components/NotesDelegate.qml (+16/-5)
To merge this branch: bzr merge lp:~rpadovani/reminders-app/betterGradient
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Review via email: mp+219015@code.launchpad.net

This proposal supersedes a proposal from 2014-05-09.

Commit message

Better gradient on preview images

Description of the change

Better gradient on preview images

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:104
http://91.189.93.70:8080/job/reminders-app-ci/327/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2571
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2571/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/107
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/107/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-ci/328
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/22

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/327/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:105
http://91.189.93.70:8080/job/reminders-app-ci/328/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2573
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2573/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/109
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/109/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-trusty-amd64-ci/329
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/23

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/328/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

LGTM, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/NotesDelegate.qml'
2--- src/app/qml/components/NotesDelegate.qml 2014-05-09 09:05:32 +0000
3+++ src/app/qml/components/NotesDelegate.qml 2014-05-09 16:13:56 +0000
4@@ -108,17 +108,28 @@
5 Layout.maximumWidth: parent.width / 2
6
7 Rectangle {
8- height: parent.width
9+ height: parent.width / 4
10 width: parent.height
11
12- anchors.centerIn: parent
13+ anchors {verticalCenter: parent.verticalCenter; horizontalCenter: parent.horizontalCenter; horizontalCenterOffset: parent.width/2 - height/2 }
14 rotation: 90
15
16 gradient: Gradient {
17 GradientStop{ position: 0; color: "#383838" }
18- GradientStop{ position: 0.1; color: "transparent" }
19- GradientStop{ position: 0.9; color: "transparent" }
20- GradientStop{ position: 1; color: "#383838" }
21+ GradientStop{ position: 1; color: "transparent" }
22+ }
23+ }
24+
25+ Rectangle {
26+ height: parent.width / 4
27+ width: parent.height
28+
29+ anchors {verticalCenter: parent.verticalCenter; horizontalCenter: parent.horizontalCenter; horizontalCenterOffset: -parent.width/2 + height/2 }
30+ rotation: 270
31+
32+ gradient: Gradient {
33+ GradientStop{ position: 0; color: "#383838" }
34+ GradientStop{ position: 1; color: "transparent" }
35 }
36 }
37 }

Subscribers

People subscribed via source and target branches