Merge lp:~rpadovani/reminders-app/1382730 into lp:reminders-app

Proposed by Riccardo Padovani
Status: Merged
Approved by: David Planella
Approved revision: 280
Merged at revision: 285
Proposed branch: lp:~rpadovani/reminders-app/1382730
Merge into: lp:reminders-app
Diff against target: 25 lines (+2/-2)
2 files modified
src/app/qml/components/PageWithBottomEdge.qml (+1/-1)
src/app/qml/ui/NotesPage.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/reminders-app/1382730
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Michael Zanetti (community) Approve
Review via email: mp+238904@code.launchpad.net

Commit message

Fixed #1382730 - Unable to create new notes

Description of the change

Fixed #1382730 - Unable to create new notes

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

cheers

review: Approve
Revision history for this message
David Planella (dpm) wrote :

This doesn't seem to fix it for me, the error comes on qml/components/PageWithBottomEdge.qml:

qml/components/PageWithBottomEdge.qml:114: ReferenceError: filter is not defined
                NotesStore.createNote("Untitled", filter);

review: Needs Fixing
Revision history for this message
David Planella (dpm) wrote :

LGTM now and it works, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/components/PageWithBottomEdge.qml'
2--- src/app/qml/components/PageWithBottomEdge.qml 2014-09-23 12:39:27 +0000
3+++ src/app/qml/components/PageWithBottomEdge.qml 2014-10-20 15:32:44 +0000
4@@ -111,7 +111,7 @@
5 if (edgeLoader.status === Loader.Ready) {
6 edgeLoader.item.active = true
7
8- NotesStore.createNote("Untitled", filter);
9+ NotesStore.createNote("Untitled", filterNotebookGuid);
10
11 if (edgeLoader.item.flickable) {
12 edgeLoader.item.flickable.contentY = -page.header.height
13
14=== modified file 'src/app/qml/ui/NotesPage.qml'
15--- src/app/qml/ui/NotesPage.qml 2014-10-10 14:15:04 +0000
16+++ src/app/qml/ui/NotesPage.qml 2014-10-20 15:32:44 +0000
17@@ -68,7 +68,7 @@
18 text: i18n.tr("Add note")
19 iconName: "add"
20 onTriggered: {
21- NotesStore.createNote(i18n.tr("Untitled"), filter);
22+ NotesStore.createNote(i18n.tr("Untitled"), filterNotebookGuid);
23 }
24 }
25 }

Subscribers

People subscribed via source and target branches