Merge lp:~rpadovani/reminders-app/1379886 into lp:reminders-app

[Riccardo Padovani]

Fix #1379886 - First time reminders tab is shown, the list is offset from the top

Fix #1379886 - First time reminders tab is shown, the list is offset from the top

I'm not sure what are roots of the bug, I think is because ListView height is set before all delegates are istanciated. So I inserted the listview in an Item that fills the parent, and set anchor of listview to Item

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:279
http://91.189.93.70:8080/job/reminders-app-ci/553/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/954
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/954/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/249

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/553/rebuild

review: Approve (continuous-integration)

[David Planella (dpm)]

LGTM, thanks!

review: Approve

=== modified file 'src/app/qml/ui/RemindersPage.qml'
--- src/app/qml/ui/RemindersPage.qml	2014-09-23 12:39:27 +0000
+++ src/app/qml/ui/RemindersPage.qml	2014-10-15 10:31:22 +0000
@@ -56,56 +56,60 @@
         onlyReminders: true
     }
 
-    ListView {
-        id: remindersListView
+    Item {
         anchors.fill: parent
-
-        delegate: RemindersDelegate {
-            width: remindersListView.width
-            note: notes.note(guid)
-
-            Component.onCompleted: {
-                if (!model.plaintextContent) {
-                    NotesStore.refreshNoteContent(model.guid)
-                }
-            }
-
-            onClicked: {
-                root.selectedNote = NotesStore.note(guid);
-            }
-        }
-
-        model: notes
-
-        section.criteria: ViewSection.FullString
-        section.property: "reminderTimeString"
-        section.delegate: Empty {
-            height: units.gu(5)
-            RowLayout {
-                anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(2) }
-                Label {
-                    text: section
-                    Layout.fillWidth: true
-                }
-                Label {
-                    text: "(" + notes.sectionCount("reminderTimeString", section) + ")"
-                }
-            }
-        }
-
-        ActivityIndicator {
-            anchors.centerIn: parent
-            running: notes.loading
-            visible: running
-        }
-        Label {
-            anchors.centerIn: parent
-            visible: !notes.loading && (notes.error || remindersListView.count == 0)
-            width: parent.width - units.gu(4)
-            wrapMode: Text.WordWrap
-            horizontalAlignment: Text.AlignHCenter
-            text: notes.error ? notes.error :
-                                i18n.tr("No reminders available. You can create new reminders by setting a reminder when viewing a note.")
+        ListView {
+            id: remindersListView
+            anchors { left: parent.left; right: parent.right }
+            height: parent.height - y
+
+            delegate: RemindersDelegate {
+                width: remindersListView.width
+                note: notes.note(guid)
+
+                Component.onCompleted: {
+                    if (!model.plaintextContent) {
+                        NotesStore.refreshNoteContent(model.guid)
+                    }
+                }
+
+                onClicked: {
+                    root.selectedNote = NotesStore.note(guid);
+                }
+            }
+
+            model: notes
+
+            section.criteria: ViewSection.FullString
+            section.property: "reminderTimeString"
+            section.delegate: Empty {
+                height: units.gu(5)
+                RowLayout {
+                    anchors { left: parent.left; right: parent.right; verticalCenter: parent.verticalCenter; margins: units.gu(2) }
+                    Label {
+                        text: section
+                        Layout.fillWidth: true
+                    }
+                    Label {
+                        text: "(" + notes.sectionCount("reminderTimeString", section) + ")"
+                    }
+                }
+            }
+
+            ActivityIndicator {
+                anchors.centerIn: parent
+                running: notes.loading
+                visible: running
+            }
+            Label {
+                anchors.centerIn: parent
+                visible: !notes.loading && (notes.error || remindersListView.count == 0)
+                width: parent.width - units.gu(4)
+                wrapMode: Text.WordWrap
+                horizontalAlignment: Text.AlignHCenter
+                text: notes.error ? notes.error :
+                i18n.tr("No reminders available. You can create new reminders by setting a reminder when viewing a note.")
+            }
         }
     }
 }