Ubuntu Notes app

Merge lp:~rpadovani/reminders-app/1340644 into lp:reminders-app

  1. 1340644
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: Michael Zanetti
Approved revision: 181
Merged at revision: 179
Proposed branch: lp:~rpadovani/reminders-app/1340644
Merge into: lp:reminders-app
Diff against target: 17 lines (+8/-0)
1 file modified
src/app/qml/ui/EditNoteView.qml (+8/-0)
To merge this branch: bzr merge lp:~rpadovani/reminders-app/1340644
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+226614@code.launchpad.net

Commit message

Fixed #1340644 - Notes go in default notebook when edited

Description of the change

Fixed #1340644 - Notes go in default notebook when edited

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:178
http://91.189.93.70:8080/job/reminders-app-ci/453/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/998
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/998/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/149

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/453/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

see inline

review: Needs Fixing
Revision history for this message
Michael Zanetti (mzanetti) wrote :

While the SDK doesn't have the count property on the OptionSelector, you can rebase this branch on https://code.launchpad.net/~mzanetti/reminders-app/add-count-props/+merge/226636 and make use of the model's count property.

lp:~rpadovani/reminders-app/1340644 updated
179. By Riccardo Padovani

Merged from trunk to have count property

180. By Riccardo Padovani

Removed public vars, use new count property in notebook

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Ok, I updated all. I leave root.note ? noteNotebookIndexModel : 0;, as we discussed on IRC

Revision history for this message
Michael Zanetti (mzanetti) wrote :

tiny nitpick inline

review: Needs Fixing
lp:~rpadovani/reminders-app/1340644 updated
181. By Riccardo Padovani

Removed whitespace

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:180
http://91.189.93.70:8080/job/reminders-app-ci/457/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1007
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1007/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/153

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/457/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

I like how we always manage to get the code down to half the size while even improving behavior :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/EditNoteView.qml'
2--- src/app/qml/ui/EditNoteView.qml 2014-05-07 16:34:06 +0000
3+++ src/app/qml/ui/EditNoteView.qml 2014-07-14 13:40:37 +0000
4@@ -27,6 +27,14 @@
5 id: root
6 property var note
7
8+ onNoteChanged: {
9+ for (var i = 0; i < notebookSelector.model.count; i++) {
10+ if (notebookSelector.model.notebook(i).guid == note.notebookGuid) {
11+ notebookSelector.selectedIndex = i;
12+ }
13+ }
14+ }
15+
16 signal exitEditMode(var note)
17 signal attachFromCamera(int position, var note)
18

Subscribers

People subscribed via source and target branches