Merge lp:~rpadovani/phablet-tools/fix-for-1139999 into lp:phablet-tools

Proposed by Riccardo Padovani on 2013-03-14
Status: Merged
Approved by: Loïc Minier on 2013-03-20
Approved revision: 68
Merged at revision: 68
Proposed branch: lp:~rpadovani/phablet-tools/fix-for-1139999
Merge into: lp:phablet-tools
Diff against target: 26 lines (+7/-1) 2 files modified
To merge this branch: bzr merge lp:~rpadovani/phablet-tools/fix-for-1139999
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration 2013-03-15 Approve on 2013-03-20
Loïc Minier 2013-03-14 Approve on 2013-03-15
Review via email: mp+153419@code.launchpad.net

Commit Message

Fix typo "excetuting" in phablet-flash error message; LP: #1139999.

Description of the Change

Fixing typo error (LP: #1139999)

To post a comment you must log in.
Loïc Minier (lool) wrote :

Thanks!

review: Approve
Loïc Minier (lool) wrote :

Actually sorry, probably want to keep the changelog as UNRELEASED rather than targeting precise

review: Disapprove
Riccardo Padovani (rpadovani) wrote :

> Actually sorry, probably want to keep the changelog as UNRELEASED rather than
> targeting precise

Ok.
So, next time I have to use -D UNRELEASED?

Loïc Minier (lool) wrote :

Yes (unless you're actually preparing an upload to the https://launchpad.net/~phablet-team/+archive/tools PPA I guess, then the target release would be raring and the version number something like 0.7-0phablet2).

Would you mind adding a commit to change it back to UNRELEASED? The branch is automerged, so I can't fixes of my own unless I submit my own merge proposal.

67. By Riccardo Padovani on 2013-03-15

Change changelog from precise to UNRELEASED

Riccardo Padovani (rpadovani) wrote :

Done, thanks for your patience ;)

68. By Riccardo Padovani on 2013-03-15

Change (another time) the changelog

Loïc Minier (lool) :
review: Approve
review: Approve (continuous-integration)

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2013-03-13 16:29:45 +0000
3+++ debian/changelog 2013-03-15 15:11:23 +0000
4@@ -1,3 +1,9 @@
5+phablet-tools (0.7-0phablet1ubuntu1) UNRELEASED; urgency=low
6+
7+ * Fixing typo error (LP: #1139999)
8+
9+ -- Riccardo Padovani <rpadovani@ubuntu-it.org> Thu, 14 Mar 2013 18:21:27 +0100
10+
11 phablet-tools (0.7-0phablet1) raring; urgency=low
12
13 [ Ricardo Salveti ]
14
15=== modified file 'phablet-flash'
16--- phablet-flash 2013-03-13 22:20:42 +0000
17+++ phablet-flash 2013-03-15 15:11:23 +0000
18@@ -163,7 +163,7 @@
19 try:
20 return f(*args, **kwargs)
21 except subprocess.CalledProcessError as e:
22- log.error('Error while excetuting %s' %
23+ log.error('Error while executing %s' %
24 e.cmd)
25 log.info('Make sure the device is connected and viewable '
26 'by running \'adb devices\'')

Subscribers

People subscribed via source and target branches