Merge lp:~ross-ross-williams/duplicity/gpg-agent-fix into lp:duplicity/0.6
Proposed by
Ross Williams
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 786 | ||||
Proposed branch: | lp:~ross-ross-williams/duplicity/gpg-agent-fix | ||||
Merge into: | lp:duplicity/0.6 | ||||
Diff against target: |
47 lines (+18/-6) 1 file modified
duplicity/gpg.py (+18/-6) |
||||
To merge this branch: | bzr merge lp:~ross-ross-williams/duplicity/gpg-agent-fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
duplicity-team | Pending | ||
Review via email: mp+74278@code.launchpad.net |
Description of the change
Have gpg.py check whether use_agent is enabled before asking GnuPGInterface to create a passphrase file descriptor. This works around a GnuPG 2.x-related issue in which --passphrase-fd takes priority over --use-agent as the source of the passphrase. The opposite was true in GnuPG 1.x, so this bug only occurs when using gpg2.
To post a comment you must log in.
On 06.09.2011 20:59, Ross Williams wrote: /bugs.launchpad .net/duplicity/ +bug/842990 /code.launchpad .net/~ross- ross-williams/ duplicity/ gpg-agent- fix/+merge/ 74278
> Ross Williams has proposed merging lp:~ross-ross-williams/duplicity/gpg-agent-fix into lp:duplicity.
>
> Requested reviews:
> duplicity-team (duplicity-team)
> Related bugs:
> Bug #842990 in Duplicity: "use-agent doesn't work with gpg2"
> https:/
>
> For more details, see:
> https:/
>
> Have gpg.py check whether use_agent is enabled before asking GnuPGInterface to create a passphrase file descriptor. This works around a GnuPG 2.x-related issue in which --passphrase-fd takes priority over --use-agent as the source of the passphrase. The opposite was true in GnuPG 1.x, so this bug only occurs when using gpg2.
nice.. does it work for gpg1 and 2 now? ..ede/duply.net