Wingpanel

Merge lp:~roryj/wingpanel/fix-strut-size into lp:~elementary-pantheon/wingpanel/trunk-0.3.x

  1. fix-strut-size
  2. Merge into trunk-0.3.x
Proposed by Rory
Status: Merged
Approved by: Cody Garver
Approved revision: 159
Merged at revision: 159
Proposed branch: lp:~roryj/wingpanel/fix-strut-size
Merge into: lp:~elementary-pantheon/wingpanel/trunk-0.3.x
Diff against target: 12 lines (+1/-1)
1 file modified
src/Widgets/BasePanel.vala (+1/-1)
To merge this branch: bzr merge lp:~roryj/wingpanel/fix-strut-size
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
WingPanel Devs Pending
Review via email: mp+217983@code.launchpad.net

Commit message

Strut is 1 pixel too long so decrease TOP_END by 1.

Description of the change

Strut is 1 pixel too long so decrease TOP_END by 1.

This fixes a bug with dual monitors where if the primary monitor is to the left of the secondary, there is a 1 pixel gap down side the left side of the secondary display when a window is maximised.

To post a comment you must log in.
lp:~roryj/wingpanel/fix-strut-size updated
158. By Aleksander

Added get_scale_factor () when getting panel height to support HiDPI

Revision history for this message
Cody Garver (codygarver) wrote :

Sorry but there was just a change to this very line in trunk so you will need to resubmit

Since it's only one line, the easiest way to do this would be to start over and when you're ready to push, bzr push lp:~roryj/wingpanel/fix-strut-size --overwrite

Then comment here when it's ready

review: Needs Fixing
lp:~roryj/wingpanel/fix-strut-size updated
159. By Rory

Fix incorrect strut size.

Revision history for this message
Rory (roryj) wrote :

Resubmitted as suggested.

Revision history for this message
Rory (roryj) wrote :

So...... anything happening?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/BasePanel.vala'
2--- src/Widgets/BasePanel.vala 2014-05-02 11:50:22 +0000
3+++ src/Widgets/BasePanel.vala 2014-05-02 13:26:56 +0000
4@@ -228,7 +228,7 @@
5
6 struts[Struts.TOP] = (panel_height + panel_y) * this.get_scale_factor ();
7 struts[Struts.TOP_START] = panel_x;
8- struts[Struts.TOP_END] = panel_x + panel_width;
9+ struts[Struts.TOP_END] = panel_x + panel_width - 1;
10
11 var first_struts = new ulong[Struts.BOTTOM + 1];
12 for (var i = 0; i < first_struts.length; i++)

Subscribers

People subscribed via source and target branches

to all changes: