Merge lp:~ronnie.vd.c/loco-team-portal/userprofile_creation into lp:loco-team-portal

[Ronnie]

[Adnane Belmadiaf (daker)]

1- Move create_userprofile to signals.py
2- Added tests http://paste.ubuntu.com/1012174/
3- pylint pls :) our code is rated 5/10 .

review: Needs Fixing

[Adnane Belmadiaf (daker)]

Your code has been merged with this MP https://code.launchpad.net/~daker/loco-team-portal/fix.profiles/+merge/135014

=== modified file 'loco_directory/events/views.py'
--- loco_directory/events/views.py	2012-02-15 15:56:28 +0000
+++ loco_directory/events/views.py	2012-05-28 10:45:22 +0000
@@ -301,9 +301,7 @@
     if team_event_object.is_attending(request.user):
         attendee_object = team_event_object.attendee_set.get(attendee_profile__user=request.user)
     else:
-        from userprofiles.models import create_profile
-        profile = create_profile(request.user.username)
-        attendee_object = Attendee(team_event=team_event_object, attendee_profile=profile)
+        attendee_object = Attendee(team_event=team_event_object, attendee_profile=request.user.get_profile())
         
     if request.method == 'POST':        
         form = AttendeeRegistrationForm(instance=attendee_object, data=request.POST)
@@ -338,9 +336,7 @@
         if form.is_valid():
             team_event_comment = form.save(commit=False)
             team_event_comment.team_event = team_event_object
-            from userprofiles.models import create_profile
-            profile = create_profile(request.user.username)
-            team_event_comment.commenter_profile = profile
+            team_event_comment.commenter_profile = request.user.get_profile()
             team_event_comment.save()
             request.user.message_set.create(message=_('Comment saved.'))
             return redirect( team_event_object )

=== modified file 'loco_directory/userprofiles/management/commands/update-profiles.py'
--- loco_directory/userprofiles/management/commands/update-profiles.py	2010-12-28 21:41:10 +0000
+++ loco_directory/userprofiles/management/commands/update-profiles.py	2012-05-28 10:45:22 +0000
@@ -5,7 +5,7 @@
 
 from common import launchpad
 from django.contrib.auth.models import User, Group
-from userprofiles.models import UserProfile, create_profile
+from userprofiles.models import UserProfile, create_userprofile
 
 from datetime import datetime
 import sys
@@ -22,18 +22,5 @@
         ld_users = User.objects.all()
 
         for ld_user in ld_users:
-            if not ld_user.username in USER_BLACKLIST:
-                profile, created = UserProfile.objects.get_or_create(user=ld_user)
-                try:
-                    lp_user = lp.people[ld_user.username]
-                    profile.tz = lp_user.time_zone or "UTC"
-                    profile.realname = lp_user.display_name or user.username
-                    if lp_user.logo_link.startswith("https://") :
-                       profile.mugshot = lp_user.logo_link
-                    else:
-                       profile.mugshot = "https://launchpad.net/@@/person-logo"
-                    profile.save()
-                except Exception, e:
-                    print "Error updating %s" % ld_user
-                    print e
-                    pass
+            create_userprofile(sender=User, instance=ld_user, lp=lp, USER_BLACKLIST=USER_BLACKLIST, need_update=True)
+            

=== modified file 'loco_directory/userprofiles/models.py'
--- loco_directory/userprofiles/models.py	2011-03-04 18:16:03 +0000
+++ loco_directory/userprofiles/models.py	2012-05-28 10:45:22 +0000
@@ -1,9 +1,14 @@
+import pytz
+import logging
+log = logging.getLogger(__name__)
+
 from django.db import models
+from django.db.models.signals import post_save
 from django.utils.translation import ugettext_lazy as _
 from django.contrib.auth import models as auth_models
+
 # Create your models here.
 
-import pytz
 
 class UserProfile(models.Model):
     " Store profile information about a user "
@@ -68,16 +73,37 @@
 auth_models.User.profile = property(_getUserProfile)
 auth_models.AnonymousUser.profile = property(_getAnonProfile)
 
+def create_userprofile(sender, instance, lp=None, USER_BLACKLIST=(u"root", u"admin"), need_update=False, **kwargs):
+    profile, created = UserProfile.objects.get_or_create(user=instance)
+    if instance.username in USER_BLACKLIST:
+        log.error('%s tried to create a userprofile, but exists in USER_BLACKLIST' % instance)
+        return profile
+        
+    if need_update or created:
+        from common import launchpad
+        if not lp:
+            lp = launchpad.lp_login()
+        if lp:
+            try:
+                lp_user = lp.people[instance.username]
+                profile.tz = lp_user.time_zone or "UTC"
+                profile.realname = lp_user.display_name or user.username
+                if lp_user.logo_link.startswith("https://") :
+                   profile.mugshot = lp_user.logo_link
+                else:
+                   profile.mugshot = "https://launchpad.net/@@/person-logo"
+                profile.save()
+            except Exception, e:
+                log.error("Error updating %s" % instance)
+                log.error(e)
+    return profile
+
+post_save.connect(create_userprofile, sender=auth_models.User)
+
 def create_profile(username):
     user, created = auth_models.User.objects.get_or_create(username=username)
     if created:
         user.save()
     from common import launchpad
     launchpad.set_user_openid(user, force=True)
-    profile, created = UserProfile.objects.get_or_create(user=user)
-    if created:
-        # set real name as username for now, 
-        # we get the name later on via cronjob
-        profile.realname = username
-        profile.save()
-    return profile
+    return user.get_profile()