Merge lp:~ronnie.vd.c/loco-team-portal/736208-url-name into lp:loco-team-portal

Proposed by Ronnie
Status: Merged
Approved by: Chris Johnston
Approved revision: 424
Merged at revision: 422
Proposed branch: lp:~ronnie.vd.c/loco-team-portal/736208-url-name
Merge into: lp:loco-team-portal
Diff against target: 554 lines (+102/-74)
21 files modified
loco_directory/events/models.py (+8/-1)
loco_directory/events/urls.py (+21/-15)
loco_directory/events/views.py (+9/-9)
loco_directory/meetings/models.py (+8/-1)
loco_directory/meetings/urls.py (+14/-10)
loco_directory/meetings/views.py (+7/-7)
loco_directory/templates/events/team_event_detail.html (+5/-5)
loco_directory/templates/events/team_event_detail_attendees.inc.html (+3/-3)
loco_directory/templates/events/team_event_detail_comments.inc.html (+1/-1)
loco_directory/templates/events/team_event_li.inc.html (+1/-1)
loco_directory/templates/events/team_events_rss.xml (+2/-2)
loco_directory/templates/meetings/agenda_item_delete_confirm.html (+1/-1)
loco_directory/templates/meetings/agenda_item_new.html (+1/-1)
loco_directory/templates/meetings/agenda_item_update.html (+1/-1)
loco_directory/templates/meetings/team_meeting_detail.html (+4/-4)
loco_directory/templates/meetings/team_meeting_li.inc.html (+1/-1)
loco_directory/templates/meetings/team_meetings_rss.xml (+2/-2)
loco_directory/templates/venues/venue_detail.html (+1/-1)
loco_directory/venues/models.py (+1/-1)
loco_directory/venues/urls.py (+7/-3)
loco_directory/venues/views.py (+4/-4)
To merge this branch: bzr merge lp:~ronnie.vd.c/loco-team-portal/736208-url-name
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+53683@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

When adding a team event, click submit and I get:

Exception Type: NoReverseMatch at /events/ubuntu-us-florida/add/
Exception Value: Reverse for 'team-event-detail' with arguments '()' and keyword arguments '{'team_event_id': 818}' not found.

Unable to click on links that are to global events.

review: Needs Fixing
Revision history for this message
Chris Johnston (cjohnston) wrote :

For adding a meeting I get:

Exception Type: NoReverseMatch at /meetings/ubuntu-us-florida/add/
Exception Value: Reverse for 'team-meeting-detail' with arguments '()' and keyword arguments '{'team_meeting_id': 53}' not found.

424. By Ronnie

Changed redirect urls

Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/events/models.py'
2--- loco_directory/events/models.py 2011-03-02 23:05:59 +0000
3+++ loco_directory/events/models.py 2011-03-18 13:41:34 +0000
4@@ -148,9 +148,16 @@
5 self.date_end = local_end
6 local_date_end = property(get_local_end, set_local_end)
7
8+ def first_team(self):
9+ try:
10+ return self.teams.all()[0]
11+ except:
12+ print 'Event %s has no team' % self.id
13+ return {'lp_name':'no-team'}
14+
15 @models.permalink
16 def get_absolute_url(self):
17- return ('team-event-detail', [str(self.id)])
18+ return ('team-event-detail', [getattr(self.first_team(), 'lp_name', 'no-team'), str(self.id)])
19
20 def is_attending(self, user):
21 if user.is_authenticated():
22
23=== modified file 'loco_directory/events/urls.py'
24--- loco_directory/events/urls.py 2011-02-17 20:05:03 +0000
25+++ loco_directory/events/urls.py 2011-03-18 13:41:34 +0000
26@@ -4,20 +4,7 @@
27 #all events
28 url(r'^$', 'events.views.event_list', name='event-list'),
29 url(r'^history/$', 'events.views.event_history_list', name='event-history-list'),
30- #team events
31- url(r'^team/locations/$', 'events.views.team_event_locations', name='team-event-locations'),
32- url(r'^team/ical/$', 'events.views.teams_event_list_ical', name='teams-event-list-ical'),
33- url(r'^team/(?P<team_event_id>\d+)/detail/ical/$', 'events.views.event_ical', name='event-ical'),
34- url(r'^team/(?P<team_event_id>\d+)/register/$', 'events.views.team_event_register', name='team-event-register'),
35- url(r'^team/(?P<team_event_id>\d+)/detail/$', 'events.views.team_event_detail', name='team-event-detail'),
36- url(r'^team/(?P<team_event_id>\d+)/delete/$', 'events.views.team_event_delete', name='team-event-delete'),
37- url(r'^team/(?P<team_event_id>\d+)/update/$', 'events.views.team_event_update', name='team-event-update'),
38- url(r'^team/(?P<team_event_id>\d+)/comment/$', 'events.views.team_event_comment_new', name='team-event-comment-new'),
39- url(r'^team/(?P<team_event_id>\d+)/copy/$', 'events.views.team_event_copy', name='team-event-copy'),
40- url(r'^team/(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/add/$', 'events.views.team_event_new', name='team-event-new'),
41- url(r'^team/(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/rss/$', 'events.views.team_events_rss', name='team-events-rss'),
42- url(r'^team/(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/ical/$', 'events.views.team_event_list_ical', name='team-event-list-ical'),
43- url(r'^team/add/$', 'events.views.team_event_select', name='team-event-select'),
44+
45 #global events
46 url(r'^global/ical/$', 'events.views.global_event_list_ical', name='global-event-list-ical'),
47 url(r'^global/(?P<global_event_id>\d+)/detail/$', 'events.views.global_event_detail', name='global-event-detail'),
48@@ -25,5 +12,24 @@
49 url(r'^global/(?P<global_event_id>\d+)/update/$', 'events.views.global_event_update', name='global-event-update'),
50 url(r'^global/(?P<global_event_id>\d+)/locations/$', 'events.views.global_event_locations', name='global-event-locations'),
51 url(r'^global/add/$', 'events.views.global_event_new', name='global-event-new'),
52-
53+
54+ #team events
55+ url(r'^locations/$', 'events.views.team_event_locations', name='team-event-locations'),
56+ url(r'^ical/$', 'events.views.teams_event_list_ical', name='teams-event-list-ical'),
57+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/detail/ical/$', 'events.views.event_ical', name='event-ical'),
58+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/register/$', 'events.views.team_event_register', name='team-event-register'),
59+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/detail/$', 'events.views.team_event_detail', name='team-event-detail'),
60+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/delete/$', 'events.views.team_event_delete', name='team-event-delete'),
61+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/update/$', 'events.views.team_event_update', name='team-event-update'),
62+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/comment/$', 'events.views.team_event_comment_new', name='team-event-comment-new'),
63+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_event_id>\d+)/copy/$', 'events.views.team_event_copy', name='team-event-copy'),
64+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/add/$', 'events.views.team_event_new', name='team-event-new'),
65+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/rss/$', 'events.views.team_events_rss', name='team-events-rss'),
66+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/ical/$', 'events.views.team_event_list_ical', name='team-event-list-ical'),
67+ url(r'^add/$', 'events.views.team_event_select', name='team-event-select'),
68+
69+ # Old url notations
70+ url(r'^team/locations/$', 'events.views.team_event_locations'),
71+ url(r'^team/ical/$', 'events.views.teams_event_list_ical'),
72+ url(r'^team/add/$', 'events.views.team_event_select'),
73 )
74
75=== modified file 'loco_directory/events/views.py'
76--- loco_directory/events/views.py 2011-03-06 22:13:43 +0000
77+++ loco_directory/events/views.py 2011-03-18 13:41:34 +0000
78@@ -57,7 +57,7 @@
79
80 return response
81
82-def event_ical(request, team_event_id):
83+def event_ical(request, team_slug, team_event_id):
84 """
85 Return a ical list with a single events in ical format.
86 """
87@@ -102,7 +102,7 @@
88 # Team Events
89 #################################################################
90
91-def team_event_detail(request, team_event_id):
92+def team_event_detail(request, team_slug, team_event_id):
93 """
94 detailed view for a team event
95 """
96@@ -120,7 +120,7 @@
97 context, RequestContext(request))
98
99 @login_required
100-def team_event_delete(request, team_event_id):
101+def team_event_delete(request, team_slug, team_event_id):
102 """
103 delete a event
104 """
105@@ -204,7 +204,7 @@
106 team_event = form.save()
107 team_event.teams.add(team_object)
108 team_event_id = team_event.id
109- return HttpResponseRedirect(reverse('team-event-detail', kwargs={'team_event_id': team_event_id}))
110+ return HttpResponseRedirect(team_event.get_absolute_url())
111 else:
112 form = TeamEventForm(initial={'global_event':request.GET.get('global_event_id', None)}, teams=[team_object])
113 if request.GET.has_key('global_event_id'):
114@@ -223,7 +223,7 @@
115 return redirect( team_object )
116
117 @login_required
118-def team_event_copy(request, team_event_id):
119+def team_event_copy(request, team_slug, team_event_id):
120 """
121 new team event
122 """
123@@ -242,7 +242,7 @@
124 team_event = form.save()
125 team_event.teams.add(team_object)
126 team_event_id = team_event.id
127- return HttpResponseRedirect(reverse('team-event-detail', kwargs={'team_event_id': team_event_id}))
128+ return HttpResponseRedirect(team_event.get_absolute_url())
129 else:
130 form = TeamEventForm(instance=team_event, teams=team_event.teams.all())
131
132@@ -258,7 +258,7 @@
133 return redirect( team_object )
134
135 @login_required
136-def team_event_update(request, team_event_id):
137+def team_event_update(request, team_slug, team_event_id):
138 """
139 update team event
140 """
141@@ -292,7 +292,7 @@
142 return redirect( team_event_object )
143
144 @login_required
145-def team_event_register(request, team_event_id):
146+def team_event_register(request, team_slug, team_event_id):
147 """
148 register as attendee for a team event
149 """
150@@ -326,7 +326,7 @@
151 context, RequestContext(request))
152
153 @login_required
154-def team_event_comment_new(request, team_event_id):
155+def team_event_comment_new(request, team_slug, team_event_id):
156 """
157 create a comment for a team event
158 """
159
160=== modified file 'loco_directory/meetings/models.py'
161--- loco_directory/meetings/models.py 2011-03-02 23:05:59 +0000
162+++ loco_directory/meetings/models.py 2011-03-18 13:41:34 +0000
163@@ -56,10 +56,17 @@
164
165 def __unicode__(self):
166 return "%s %s" % (self.name, self.date_begin or "")
167+
168+ def first_team(self):
169+ try:
170+ return self.teams.all()[0]
171+ except:
172+ print 'Meeting %s has no team' % self.id
173+ return {'lp_name':'no-team'}
174
175 @models.permalink
176 def get_absolute_url(self):
177- return ('team-meeting-detail', [str(self.id)])
178+ return ('team-meeting-detail', [getattr(self.first_team(), 'lp_name', 'no-team'), str(self.id)])
179
180 #add manager
181 objects = TeamMeetingManager()
182
183=== modified file 'loco_directory/meetings/urls.py'
184--- loco_directory/meetings/urls.py 2011-01-23 02:17:54 +0000
185+++ loco_directory/meetings/urls.py 2011-03-18 13:41:34 +0000
186@@ -5,18 +5,22 @@
187 url(r'^$', 'meetings.views.meeting_list', name='meeting-list'),
188 url(r'^history/$', 'meetings.views.meeting_history_list', name='meeting-history-list'),
189 #team meetings
190- url(r'^team/ical/$', 'meetings.views.teams_meeting_list_ical', name='teams-meeting-list-ical'),
191- url(r'^team/(?P<team_meeting_id>\d+)/detail/ical/$', 'meetings.views.meeting_ical', name='meeting-ical'),
192- url(r'^team/(?P<team_meeting_id>\d+)/detail/$', 'meetings.views.team_meeting_detail', name='team-meeting-detail'),
193- url(r'^team/(?P<team_meeting_id>\d+)/delete/$', 'meetings.views.team_meeting_delete', name='team-meeting-delete'),
194- url(r'^team/(?P<team_meeting_id>\d+)/update/$', 'meetings.views.team_meeting_update', name='team-meeting-update'),
195- url(r'^team/(?P<team_meeting_id>\d+)/copy/$', 'meetings.views.team_meeting_copy', name='team-meeting-copy'),
196- url(r'^team/(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/add/$', 'meetings.views.team_meeting_new', name='team-meeting-new'),
197- url(r'^team/(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/rss/$', 'meetings.views.team_meetings_rss', name='team-meetings-rss'),
198- url(r'^team/(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/ical/$', 'meetings.views.team_meeting_list_ical', name='team-meeting-list-ical'),
199- url(r'^team/add/$', 'meetings.views.team_meeting_select', name='team-meeting-select'),
200+ url(r'^ical/$', 'meetings.views.teams_meeting_list_ical', name='teams-meeting-list-ical'),
201+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_meeting_id>\d+)/detail/ical/$', 'meetings.views.meeting_ical', name='meeting-ical'),
202+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_meeting_id>\d+)/detail/$', 'meetings.views.team_meeting_detail', name='team-meeting-detail'),
203+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_meeting_id>\d+)/delete/$', 'meetings.views.team_meeting_delete', name='team-meeting-delete'),
204+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_meeting_id>\d+)/update/$', 'meetings.views.team_meeting_update', name='team-meeting-update'),
205+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/(?P<team_meeting_id>\d+)/copy/$', 'meetings.views.team_meeting_copy', name='team-meeting-copy'),
206+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/add/$', 'meetings.views.team_meeting_new', name='team-meeting-new'),
207+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/rss/$', 'meetings.views.team_meetings_rss', name='team-meetings-rss'),
208+ url(r'^(?P<team_slug>[a-zA-Z0-9\-\.\+?]+)/ical/$', 'meetings.views.team_meeting_list_ical', name='team-meeting-list-ical'),
209+ url(r'^add/$', 'meetings.views.team_meeting_select', name='team-meeting-select'),
210
211 url(r'^team/(?P<team_meeting_id>\d+)/agenda/(?P<agenda_item_id>\d+)/delete/$', 'meetings.views.agenda_item_delete', name='agenda-item-delete'),
212 url(r'^team/(?P<team_meeting_id>\d+)/agenda/(?P<agenda_item_id>\d+)/update/$', 'meetings.views.agenda_item_update', name='agenda-item-update'),
213 url(r'^team/(?P<team_meeting_id>\d+)/agenda/add/$', 'meetings.views.agenda_item_new', name='agenda-item-new'),
214+
215+ #Old url notations
216+ url(r'^team/ical/$', 'meetings.views.teams_meeting_list_ical'),
217+ url(r'^team/add/$', 'meetings.views.team_meeting_select'),
218 )
219
220=== modified file 'loco_directory/meetings/views.py'
221--- loco_directory/meetings/views.py 2011-02-23 01:05:59 +0000
222+++ loco_directory/meetings/views.py 2011-03-18 13:41:34 +0000
223@@ -52,7 +52,7 @@
224 return response
225
226
227-def meeting_ical(request, team_meeting_id):
228+def meeting_ical(request, team_slug, team_meeting_id):
229 """
230 Return a ical list with a single meetings in ical format.
231 """
232@@ -89,7 +89,7 @@
233 # Team Meetings
234 #################################################################
235
236-def team_meeting_detail(request, team_meeting_id):
237+def team_meeting_detail(request, team_slug, team_meeting_id):
238 team_meeting_object = get_object_or_404(TeamMeeting, pk=team_meeting_id)
239 is_member = False
240 for team_object in team_meeting_object.teams.all():
241@@ -103,7 +103,7 @@
242 context, RequestContext(request))
243
244 @login_required
245-def team_meeting_delete(request, team_meeting_id):
246+def team_meeting_delete(request, team_slug, team_meeting_id):
247 """
248 delete a meeting
249 """
250@@ -185,7 +185,7 @@
251 team_meeting = form.save()
252 team_meeting.teams.add(team_object)
253 team_meeting_id = team_meeting.id
254- return HttpResponseRedirect(reverse('team-meeting-detail', kwargs={'team_meeting_id': team_meeting_id}))
255+ return HttpResponseRedirect(team_meeting_object.get_absolute_url())
256 else:
257 form = TeamMeetingForm(teams=[team_object], instance=team_meeting_object)
258
259@@ -201,7 +201,7 @@
260 return redirect( team_object )
261
262 @login_required
263-def team_meeting_copy(request, team_meeting_id):
264+def team_meeting_copy(request, team_slug, team_meeting_id):
265 """
266 copy team meeting
267 """
268@@ -220,7 +220,7 @@
269 team_meeting = form.save()
270 team_meeting.teams.add(team_object)
271 team_meeting_id = team_meeting.id
272- return HttpResponseRedirect(reverse('team-meeting-detail', kwargs={'team_meeting_id': team_meeting_id}))
273+ return HttpResponseRedirect(team_meeting.get_absolute_url())
274 else:
275 form = TeamMeetingForm(instance=team_meeting, teams=team_meeting.teams.all())
276
277@@ -236,7 +236,7 @@
278 return redirect( team_object )
279
280 @login_required
281-def team_meeting_update(request, team_meeting_id):
282+def team_meeting_update(request, team_slug, team_meeting_id):
283 """
284 update team meeting
285 """
286
287=== modified file 'loco_directory/templates/events/team_event_detail.html'
288--- loco_directory/templates/events/team_event_detail.html 2010-11-20 17:25:50 +0000
289+++ loco_directory/templates/events/team_event_detail.html 2011-03-18 13:41:34 +0000
290@@ -5,15 +5,15 @@
291
292 {% block sub_nav_links %}
293 <a class="sub-nav-item" href="{% url event-list %}">{% trans "Back to Events List" %}</a>
294-<a class="sub-nav-item" href="{% url team-event-comment-new team_event_object.id %}#comment">{% trans "Add Comment" %}</a>
295+<a class="sub-nav-item" href="{% url team-event-comment-new team_event_object.first_team.lp_name team_event_object.id %}#comment">{% trans "Add Comment" %}</a>
296 {% if user.is_authenticated %}
297 {% if user_is_team_member %}
298- <a class="sub-nav-item" href="{% url team-event-update team_event_object.id %}">{% trans "Edit Details" %}</a>
299- <a class="sub-nav-item" href="{% url team-event-delete team_event_object.id %}">{% trans "Delete Event" %}</a>
300- <a class="sub-nav-item" href="{% url team-event-copy team_event_object.id %}">{% trans "Copy Event" %}</a>
301+ <a class="sub-nav-item" href="{% url team-event-update team_event_object.first_team.lp_name team_event_object.id %}">{% trans "Edit Details" %}</a>
302+ <a class="sub-nav-item" href="{% url team-event-delete team_event_object.first_team.lp_name team_event_object.id %}">{% trans "Delete Event" %}</a>
303+ <a class="sub-nav-item" href="{% url team-event-copy team_event_object.first_team.lp_name team_event_object.id %}">{% trans "Copy Event" %}</a>
304 {% endif %}
305 {% endif %}
306-<a class="sub-nav-item" href="{% url event-ical team_event_object.id %}">{% trans "iCal Feed" %}</a>
307+<a class="sub-nav-item" href="{% url event-ical team_event_object.first_team.lp_name team_event_object.id %}">{% trans "iCal Feed" %}</a>
308 {% endblock %}
309
310 {% block content %}
311
312=== modified file 'loco_directory/templates/events/team_event_detail_attendees.inc.html'
313--- loco_directory/templates/events/team_event_detail_attendees.inc.html 2011-01-02 18:45:45 +0000
314+++ loco_directory/templates/events/team_event_detail_attendees.inc.html 2011-03-18 13:41:34 +0000
315@@ -5,12 +5,12 @@
316 <td colspan="2">
317 {% if user.is_authenticated %}
318 {% if user_is_attending %}
319- <a href="{% url team-event-register team_event_object.id %}">{% trans 'Change your Registration Status' %}</a>
320+ <a href="{% url team-event-register team_event_object.first_team.lp_name team_event_object.id %}">{% trans 'Change your Registration Status' %}</a>
321 {% else %}
322- <a href="{% url team-event-register team_event_object.id %}">{% trans 'Register for this Event' %}</a>
323+ <a href="{% url team-event-register team_event_object.first_team.lp_name team_event_object.id %}">{% trans 'Register for this Event' %}</a>
324 {% endif %}
325 {% else %}
326- <a href="{% url team-event-register team_event_object.id %}">{% trans 'Register for this Event' %}</a>
327+ <a href="{% url team-event-register team_event_object.first_team.lp_name team_event_object.id %}">{% trans 'Register for this Event' %}</a>
328 {% endif %}
329 </td>
330 </tr>
331
332=== modified file 'loco_directory/templates/events/team_event_detail_comments.inc.html'
333--- loco_directory/templates/events/team_event_detail_comments.inc.html 2010-11-19 13:17:17 +0000
334+++ loco_directory/templates/events/team_event_detail_comments.inc.html 2011-03-18 13:41:34 +0000
335@@ -3,7 +3,7 @@
336 <table id="team-event-comments">
337 <tr>
338 <td colspan="2" class="form-item-value">
339- <a href="{% url team-event-comment-new team_event_object.id %}#comment">{% trans "Add Comment" %}</a>
340+ <a href="{% url team-event-comment-new team_event_object.first_team.lp_name team_event_object.id %}#comment">{% trans "Add Comment" %}</a>
341 </td>
342 </tr>
343 {% regroup team_event_object.teameventcomment_set.all by local_date_created|date:"D d M Y" as comment_list %}
344
345=== modified file 'loco_directory/templates/events/team_event_li.inc.html'
346--- loco_directory/templates/events/team_event_li.inc.html 2011-01-20 14:36:48 +0000
347+++ loco_directory/templates/events/team_event_li.inc.html 2011-03-18 13:41:34 +0000
348@@ -1,5 +1,5 @@
349 {% load i18n %}
350 {% comment %}TRANSLATORS: If event has a venue, show: date "in" city{% endcomment %}
351 <li>
352- <a title="{% if team_event.venue %}{% else %}{{team_event.date_begin|date:"M d"}}{% endif %}" href="{% url team-event-detail team_event.id %}">{{ team_event.name }}</a> {% trans "on" %} {{ team_event.local_date_begin|date:"l, d N Y" }} {% trans "at " %}{{ team_event.local_date_begin|date:"H:i T" }}
353+ <a title="{% if team_event.venue %}{% else %}{{team_event.date_begin|date:"M d"}}{% endif %}" href="{% url team-event-detail team_event.first_team.lp_name team_event.id %}">{{ team_event.name }}</a> {% trans "on" %} {{ team_event.local_date_begin|date:"l, d N Y" }} {% trans "at " %}{{ team_event.local_date_begin|date:"H:i T" }}
354 </li>
355
356=== modified file 'loco_directory/templates/events/team_events_rss.xml'
357--- loco_directory/templates/events/team_events_rss.xml 2010-08-17 08:48:39 +0000
358+++ loco_directory/templates/events/team_events_rss.xml 2011-03-18 13:41:34 +0000
359@@ -8,7 +8,7 @@
360 {% for e in events %}
361 <item>
362 <title> {{ e.name }}</title>
363- <link>{{base}}{% url team-event-detail e.id %}</link>
364+ <link>{{base}}{% url team-event-detail e.first_team.lp_name e.id %}</link>
365 <description>{% trans "When:" %} {% spaceless %}
366 {% ifequal e.date_begin|date e.date_end|date %}
367 {{ e.date_begin|date:"D, d N Y H:i" }} - {{ e.date_end|date:"H:i O" }}
368@@ -17,7 +17,7 @@
369 {% endifequal %}
370 {% endspaceless %}{% if e.venue.name %} | {% trans "Where:" %} {{ e.venue.name }}{% endif %}
371 {% if e.description %} | {% trans "Description:" %} {{ e.description }}{% endif %}</description>
372- <guid>{{base}}{% url team-event-detail e.id %}</guid>
373+ <guid>{{base}}{% url team-event-detail e.first_team.lp_name e.id %}</guid>
374 </item>
375 {% endfor %}
376 </channel>
377
378=== modified file 'loco_directory/templates/meetings/agenda_item_delete_confirm.html'
379--- loco_directory/templates/meetings/agenda_item_delete_confirm.html 2011-01-23 15:20:31 +0000
380+++ loco_directory/templates/meetings/agenda_item_delete_confirm.html 2011-03-18 13:41:34 +0000
381@@ -5,7 +5,7 @@
382 {% block title %}{% trans "Delete Agenda Item" %} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}
383
384 {% block sub_nav_links %}
385-<a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a>
386+<a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a>
387 {% endblock %}
388
389 {% block extrahead %}{{ block.super }}
390
391=== modified file 'loco_directory/templates/meetings/agenda_item_new.html'
392--- loco_directory/templates/meetings/agenda_item_new.html 2011-01-22 16:05:24 +0000
393+++ loco_directory/templates/meetings/agenda_item_new.html 2011-03-18 13:41:34 +0000
394@@ -4,7 +4,7 @@
395 {% block title %}{% trans "New Agenda Item" %} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}
396
397 {% block sub_nav_links %}
398-<a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a>
399+<a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a>
400 {% endblock %}
401
402 {% block extrahead %}{{ block.super }}
403
404=== modified file 'loco_directory/templates/meetings/agenda_item_update.html'
405--- loco_directory/templates/meetings/agenda_item_update.html 2011-01-23 02:17:54 +0000
406+++ loco_directory/templates/meetings/agenda_item_update.html 2011-03-18 13:41:34 +0000
407@@ -4,7 +4,7 @@
408 {% block title %}{% trans "Update Agenda Item" %} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}
409
410 {% block sub_nav_links %}
411-<a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a>
412+<a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a>
413 <a class="sub-nav-item" href="{% url agenda-item-delete team_meeting_object.id agenda_item_object.id %}">{% trans "Delete Agenda Item" %}</a>
414 {% endblock %}
415
416
417=== modified file 'loco_directory/templates/meetings/team_meeting_detail.html'
418--- loco_directory/templates/meetings/team_meeting_detail.html 2010-12-24 14:18:40 +0000
419+++ loco_directory/templates/meetings/team_meeting_detail.html 2011-03-18 13:41:34 +0000
420@@ -7,12 +7,12 @@
421 <a class="sub-nav-item" href="{% url meeting-list %}">{% trans "Back to Meetings List" %}</a>
422 {% if user.is_authenticated %}
423 {% if user_is_team_member %}
424- <a class="sub-nav-item" href="{% url team-meeting-update team_meeting_object.id %}">{% trans "Edit Details" %}</a>
425- <a class="sub-nav-item" href="{% url team-meeting-delete team_meeting_object.id %}">{% trans "Delete Meeting" %}</a>
426- <a class="sub-nav-item" href="{% url team-meeting-copy team_meeting_object.id %}">{% trans "Copy Meeting" %}</a>
427+ <a class="sub-nav-item" href="{% url team-meeting-update team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Edit Details" %}</a>
428+ <a class="sub-nav-item" href="{% url team-meeting-delete team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Delete Meeting" %}</a>
429+ <a class="sub-nav-item" href="{% url team-meeting-copy team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Copy Meeting" %}</a>
430 {% endif %}
431 {% endif %}
432-<a class="sub-nav-item" href="{% url meeting-ical team_meeting_object.id %}">{% trans "iCal Feed" %}</a>
433+<a class="sub-nav-item" href="{% url meeting-ical team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "iCal Feed" %}</a>
434 {% endblock %}
435
436 {% block content %}
437
438=== modified file 'loco_directory/templates/meetings/team_meeting_li.inc.html'
439--- loco_directory/templates/meetings/team_meeting_li.inc.html 2011-01-24 02:40:53 +0000
440+++ loco_directory/templates/meetings/team_meeting_li.inc.html 2011-03-18 13:41:34 +0000
441@@ -1,5 +1,5 @@
442 {% load i18n %}
443 {% comment %}TRANSLATORS: If event has a venue, show: date "in" city{% endcomment %}
444 <li>
445- <a title="{{team_event.date_begin|date:"M d"}}" href="{% url team-meeting-detail team_event.id %}">{{ team_event.name }}</a> {% trans "on" %} {{ team_event.date_begin|date:"l, d N Y" }} {% trans "at " %}{{ team_event.date_begin|date:"H:i T" }}
446+ <a title="{{team_event.date_begin|date:"M d"}}" href="{% url team-meeting-detail team_event.first_team.lp_name team_event.id %}">{{ team_event.name }}</a> {% trans "on" %} {{ team_event.date_begin|date:"l, d N Y" }} {% trans "at " %}{{ team_event.date_begin|date:"H:i T" }}
447 </li>
448
449=== modified file 'loco_directory/templates/meetings/team_meetings_rss.xml'
450--- loco_directory/templates/meetings/team_meetings_rss.xml 2010-12-02 07:56:46 +0000
451+++ loco_directory/templates/meetings/team_meetings_rss.xml 2011-03-18 13:41:34 +0000
452@@ -8,7 +8,7 @@
453 {% for e in meetings %}
454 <item>
455 <title> {{ e.name }}</title>
456- <link>{{base}}{% url team-meeting-detail e.id %}</link>
457+ <link>{{base}}{% url team-meeting-detail e.first_team.lp_name e.id %}</link>
458 <description>{% trans "When:" %} {% spaceless %}
459 {% ifequal e.date_begin|date e.date_end|date %}
460 {{ e.date_begin|date:"D, d N Y H:i" }} - {{ e.date_end|date:"H:i O" }}
461@@ -16,7 +16,7 @@
462 {{ e.date_begin|date:"D, d N Y H:i" }} - {{ e.date_end|date:"D, d N Y H:i O" }}
463 {% endifequal %}
464 {% endspaceless %}</description>
465- <guid>{{base}}{% url team-meeting-detail e.id %}</guid>
466+ <guid>{{base}}{% url team-meeting-detail e.first_team.lp_name e.id %}</guid>
467 </item>
468 {% endfor %}
469 </channel>
470
471=== modified file 'loco_directory/templates/venues/venue_detail.html'
472--- loco_directory/templates/venues/venue_detail.html 2011-02-17 17:54:09 +0000
473+++ loco_directory/templates/venues/venue_detail.html 2011-03-18 13:41:34 +0000
474@@ -11,7 +11,7 @@
475
476 {% block sub_nav_links %}
477 <a class="sub-nav-item" href="{% url venue-list %}" >{% trans "Back to Venues List" %}</a>
478-<a class="sub-nav-item" href="{% url venue-update venue_object.id %}">{% trans "Edit Venue Details" %}</a>
479+<a class="sub-nav-item" href="{% url venue-update venue_object.country venue_object.id %}">{% trans "Edit Venue Details" %}</a>
480 {% endblock %}
481
482 {% block content %}
483
484=== modified file 'loco_directory/venues/models.py'
485--- loco_directory/venues/models.py 2010-12-20 23:54:15 +0000
486+++ loco_directory/venues/models.py 2011-03-18 13:41:34 +0000
487@@ -44,7 +44,7 @@
488 @models.permalink
489 def get_absolute_url(self):
490 """ get the absolute url for the venue """
491- return ('venue-detail', [self.id])
492+ return ('venue-detail', [self.country or 'no-country', self.id])
493
494 def get_timezone(self):
495 try:
496
497=== modified file 'loco_directory/venues/urls.py'
498--- loco_directory/venues/urls.py 2009-12-21 20:45:43 +0000
499+++ loco_directory/venues/urls.py 2011-03-18 13:41:34 +0000
500@@ -3,8 +3,12 @@
501 urlpatterns = patterns('',
502 #venues
503 url(r'^$', 'venues.views.venue_list', name='venue-list'),
504- url(r'^(?P<venue_id>\d+)/detail/$', 'venues.views.venue_detail', name='venue-detail'),
505- url(r'^(?P<venue_id>\d+)/update/$', 'venues.views.venue_update', name='venue-update'),
506+ url(r'^(?P<country>[\w\s]+)/(?P<venue_id>\d+)/detail/$', 'venues.views.venue_detail', name='venue-detail'),
507+ url(r'^(?P<country>[\w\s]+)/(?P<venue_id>\d+)/update/$', 'venues.views.venue_update', name='venue-update'),
508 url(r'add/$', 'venues.views.venue_new', name='venue-new'),
509- )
510+
511+ # Old urls for compatibility
512+ url(r'^(?P<venue_id>\d+)/detail/$', 'venues.views.venue_detail', kwargs={'country':''}),
513+ url(r'^(?P<venue_id>\d+)/update/$', 'venues.views.venue_update', kwargs={'country':''}),
514+)
515
516
517=== modified file 'loco_directory/venues/views.py'
518--- loco_directory/venues/views.py 2011-01-03 23:11:35 +0000
519+++ loco_directory/venues/views.py 2011-03-18 13:41:34 +0000
520@@ -32,7 +32,7 @@
521 return render_to_response('venues/venue_list.html', context,
522 RequestContext(request))
523
524-def venue_detail(request, venue_id):
525+def venue_detail(request, country, venue_id):
526 """
527 detailed view for a venue
528 """
529@@ -59,7 +59,7 @@
530 # escape() calls force_unicode.
531 (escape(venue_object.pk), escape(venue_object)))
532 else:
533- return HttpResponseRedirect(reverse('venue-detail', kwargs={'venue_id': new_venue_id}))
534+ return HttpResponseRedirect(venue_object.get_absolute_url())
535 else:
536 form = VenueForm()
537
538@@ -70,7 +70,7 @@
539 context, RequestContext(request))
540
541 @login_required
542-def venue_update(request, venue_id):
543+def venue_update(request, country, venue_id):
544 """
545 update venue
546 """
547@@ -81,7 +81,7 @@
548 if form.is_valid():
549 form.save()
550 request.user.message_set.create(message=_('Venue updated'))
551- return HttpResponseRedirect( reverse( 'venue-detail', args=[venue_object.id] ) )
552+ return HttpResponseRedirect(venue_object.get_absolute_url())
553 else:
554 form = VenueForm(instance=venue_object)
555

Subscribers

People subscribed via source and target branches