Software Properties

Merge lp:~ronj/software-properties/doubleclickSourceline into lp:software-properties

  1. doubleclickSourceline
  2. Merge into main
Proposed by Ronan Jouchet on 2010-04-21
Status: Rejected
Rejected by: Sebastien Bacher on 2010-11-18
Proposed branch: lp:~ronj/software-properties/doubleclickSourceline
Merge into: lp:software-properties
Diff against target: 13 lines (+1/-2)
1 file modified
softwareproperties/gtk/SoftwarePropertiesGtk.py (+1/-2)
To merge this branch: bzr merge lp:~ronj/software-properties/doubleclickSourceline
Reviewer Review Type Date Requested Status
Ronan Jouchet (community) Needs Fixing on 2010-11-15
Michael Vogt 2010-11-04 Needs Fixing on 2010-11-04
Ubuntu Core Development Team 2010-04-21 Pending
Review via email: mp+23891@code.launchpad.net

Description of the Change

I just corrected the function name and removed the FIXME

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks for this branch - this does not appear to be working for me. Could you please check that the glade gtkbuilder file has the right signal set?

review: Needs Fixing
Ronan Jouchet (ronj) wrote :

> Thanks for this branch - this does not appear to be working for me. Could you
> please check that the glade gtkbuilder file has the right signal set?
It used to work but yes indeed the structure changed, and given my miserable Python skills I'm unable to add the event as an input of on_treeview_sources_cursor_changed; meaning I can't check the event was a double click. Won't be able to fix, sigh :-/

review: Needs Fixing
Sebastien Bacher (seb128) wrote :

changing the status so it stops being on the sponsoring queue

Unmerged revisions

607. By Ronan Jouchet on 2010-04-21

initial version: corrected function name and removed FIXME

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
2--- softwareproperties/gtk/SoftwarePropertiesGtk.py 2010-01-12 18:03:48 +0000
3+++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2010-04-21 22:09:19 +0000
4@@ -771,8 +771,7 @@
5 if dialog.run() == gtk.RESPONSE_OK:
6 self.set_modified_sourceslist()
7
8- # FIXME:outstanding from merge
9- def on_isv_source_activated(self, treeview, path, column):
10+ def on_channel_activated(self, treeview, path, column):
11 """Open the edit dialog if a channel was double clicked"""
12 # check if the channel can be edited
13 if self.button_edit.get_property("sensitive") == True:

Subscribers

People subscribed via source and target branches

to status/vote changes: