Code review comment for lp:~roignac/ubuntuone-control-panel/close_window_shortcuts

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

I guess, I should install a trunk version of ubuntu-sso-client, as the version from PPA lacks tests:

$ apt-cache policy ubuntu-sso-client
  Installed: 3.1+r874-38~precise1
  Candidate: 3.1+r874-38~precise1
  Version table:
 *** 3.1+r874-38~precise1 0
        500 precise/main i386 Packages
        100 /var/lib/dpkg/status
     2.99.4-0ubuntu1 0
        500 precise/main i386 Packages

$ ./run-tests
*** Running test suite for ubuntuone/controlpanel ***
Traceback (most recent call last):
  File "/usr/bin/u1trial", line 325, in <module>
  File "/usr/bin/u1trial", line 305, in main
    suite = trial_runner.get_suite(config)
  File "/usr/bin/u1trial", line 184, in get_suite
  File "/usr/bin/u1trial", line 168, in _collect_tests
    module_suite = self._load_unittest(filepath)
  File "/usr/bin/u1trial", line 108, in _load_unittest
    module = __import__(modpath, None, None, [""])
  File "/home/vadik/Devel/ubuntuone-control-panel/close_window_shortcuts/ubuntuone/controlpanel/tests/", line 24, in <module>
    from ubuntu_sso.utils.webclient.tests import BaseMockWebServer
ImportError: No module named tests

I'll try using trunk version of ubuntu-sso-client.
Not sure whether it is a bug, as it doesn't affect ubuntuone-control-panel, however, new developers might encounter this issue too.

« Back to merge proposal