Merge lp:~roignac/ubuntuone-control-panel/close_window_shortcuts into lp:ubuntuone-control-panel
Proposed by
Vadim Rutkovsky
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Natalia Bidart | ||||
Proposed branch: | lp:~roignac/ubuntuone-control-panel/close_window_shortcuts | ||||
Merge into: | lp:ubuntuone-control-panel | ||||
Diff against target: |
38 lines (+17/-0) 2 files modified
ubuntuone/controlpanel/gui/gtk/gui.py (+8/-0) ubuntuone/controlpanel/gui/qt/gui.py (+9/-0) |
||||
To merge this branch: | bzr merge lp:~roignac/ubuntuone-control-panel/close_window_shortcuts | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart (community) | Needs Fixing | ||
Review via email: mp+93332@code.launchpad.net |
Description of the change
This change adds shortcuts to main windows (both GTK and QT) - close on Ctrl+W or Ctrl+Q
To post a comment you must log in.
Unmerged revisions
- 260. By Vadim Rutkovsky
-
Close window on Ctrl+Q or Ctrl+W
Hello Vadim!
First of all, thanks a lot for your contribution.
Secondly, I will have to set this branch as Needs Fixing since we have a strict policy about not adding new code without having the matching test suite validating the change.
To run the whole test suite, you can run the command:
./run-tests
At the moment, that command depends on a patched version of twisted that you can find out in our nightlies PPA: ppa:ubuntuone/ nightlies.
Let me know if you need any other guidance.
Regards, Natalia.