Merge lp:~roignac/software-center/bug-741778 into lp:software-center

[Vadim Rutkovsky]

The change displays a website for the app, showing a selectable URL

[Michael Vogt (mvo)]

Thanks! Much appreciated and merged into trunk :)

review: Approve

[Gary Lasker (gary-lasker)]

Hi Vadim, we discovered after merging that your fix has the unintended side-effect of making the link no longer activatable, that is, you can no longer click and view the site in a browser. So, I had to revert the change. My apologies for that and please know that this doesn't mean we don't appreciate your good work! It's nothing more than avoiding a regression.

Further, in reviewing the associated bug report, it seems that we will not want to make the change described in the report, that is, to display the full URL rather than the simple text "Website". The reason is that it does not conform to the Software Center spec for the details screen (https://wiki.ubuntu.com/SoftwareCenter#Software_item_screen), which is a product of a lot of skilled design work and is backed up by user testing and we generally try to conform to it as closely as we can.

I think that one reason that we use the simple text "Website" is that it is common for all software item views and it is always in the same place so the user can easily find it. A URL tends to be a somewhat random-looking collection of characters, different for each package and with little real usefulness beyond pasting into a browser to get to a web page.

Many thanks for all of your help, Vadim!

[Vadim Rutkovsky (roignac)]

Yes, I agree, as the change has brought such a regression and common users might not understand URL, this definatley should be reverted. And it's basically my fault to fix the bug, which contradicts the specification.

Thanks for such a kind reply!

[Gary Lasker (gary-lasker)]

Hi Vadim. First, I want to say that that was absolutely not your fault! On the contrary, yours was an elegant fix that took care of the bug as it was stated quite nicely. On the contrary, the responsibility was ours to triage that bug better and in particular to note the difference from the spec.

Thank you for your reply and also thank you very much your work on this and other branches for software-center! I hope that you know that your help is very much appreciated.

Best regards,
Gary

=== modified file 'softwarecenter/ui/gtk/appdetailsview_gtk.py'
--- softwarecenter/ui/gtk/appdetailsview_gtk.py	2011-07-21 02:45:28 +0000
+++ softwarecenter/ui/gtk/appdetailsview_gtk.py	2011-07-21 19:33:30 +0000
@@ -1287,6 +1287,8 @@
         if app_details.website:
             self.homepage_btn.show()
             self.homepage_btn.set_tooltip_text(app_details.website)
+            self.homepage_btn.set_label(app_details.website)
+            self.homepage_btn.label.set_selectable(True)
         else:
             self.homepage_btn.hide()
         return