Merge lp:~roignac/gwibber/Bug548524 into lp:gwibber
Proposed by
Vadim Rutkovsky
Status: | Rejected |
---|---|
Rejected by: | Robert Bruce Park |
Proposed branch: | lp:~roignac/gwibber/Bug548524 |
Merge into: | lp:gwibber |
Diff against target: |
48 lines (+5/-3) 3 files modified
gwibber/actions.py (+2/-3) gwibber/microblog/twitter.py (+2/-0) gwibber/microblog/util/__init__.py (+1/-0) |
To merge this branch: | bzr merge lp:~roignac/gwibber/Bug548524 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Bruce Park | Disapprove | ||
gwibber-committers | Pending | ||
Review via email:
|
Description of the change
Fixes LP:548524 - when sending message using twitter, group tags are also replaced with hashtags. Also, moved PARSE_GROUP variable to util module.
To post a comment you must log in.
Unmerged revisions
- 832. By Vadim Rutkovsky
-
group tags are replaced with hashtags when message is sent from Twitter
Thanks for taking the time to submit this patch, unfortunately Gwibber has gone through extensive changes recently and your patch no longer applies to the latest codebase.
Fortunately, the bug you were attempting to fix is no longer present in the current codebase. The new Twitter plugin does not do any parsing/munging of group or hashtags, so currently if you were to send a group tag to Twitter using Gwibber, Twitter would receive the message as you wrote it.
Please try out the latest Gwibber, I think you'll be quite pleased with what we've accomplished.