Gwibber

Merge lp:~roignac/gwibber/Bug534098 into lp:gwibber

  1. Bug534098
  2. Merge into trunk
Proposed by Vadim Rutkovsky
Status: Merged
Merged at revision: 857
Proposed branch: lp:~roignac/gwibber/Bug534098
Merge into: lp:gwibber
Diff against target: 17 lines (+4/-3)
1 file modified
gwibber/gwui.py (+4/-3)
To merge this branch: bzr merge lp:~roignac/gwibber/Bug534098
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+35473@code.launchpad.net

Description of the change

Fixes a small font defect - font name could not parsed when font setting is unset. This issue seems be critical for Kubuntu and other DEs possibly

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/gwui.py'
2--- gwibber/gwui.py 2010-08-30 07:02:22 +0000
3+++ gwibber/gwui.py 2010-09-14 21:31:22 +0000
4@@ -238,9 +238,10 @@
5
6 def render(self, theme, template, **kwargs):
7 default_font = self.gc.get_string("/desktop/gnome/interface/document_font_name")
8- font_name, font_size = default_font.rsplit(None, 1)
9- self.web_settings.set_property("sans-serif-font-family", font_name)
10- self.web_settings.set_property("default-font-size", float(font_size))
11+ if default_font:
12+ font_name, font_size = default_font.rsplit(None, 1)
13+ self.web_settings.set_property("sans-serif-font-family", font_name)
14+ self.web_settings.set_property("default-font-size", float(font_size))
15
16 if not resources.theme_exists(theme):
17 theme = "default"