Merge lp:~roignac/apport/bugpattern-check_for_duplicates into lp:~ubuntu-bugcontrol/apport/ubuntu-bugpatterns

[Vadim Rutkovsky]

test-local now checks that duplicate issues also match the pattern.
Maybe this should be optional?

[lp:~roignac/apport/bugpattern-check_for_duplicates]

312. By Vadim Rutkovsky on 2011-09-07

Show correct bugnumber if any of duplicates didn't match the pattern

313. By Vadim Rutkovsky on 2011-09-07

Skip non apport-crash issues when checking for duplicates

[Brian Murray (brian-murray)]

This is great! I'm still playing with it now but thanks for doing this.

[Brian Murray (brian-murray)]

I'm leaving this as non-optional as I found the duplicate checking useful as it allowed me to expand a bug pattern. I did make some minor changes to your branch also.

I removed sys.exit from match_bug so it'll keep checking other duplicates.

Because the tags of a bug report are a list you don't really need to iterate over them.
  if 'apport-crash' in bug.tags:

And using total_size wasn't really necessary. This was sufficient:
  if bug.duplicates:

review: Approve

=== modified file 'test-local'
--- test-local	2011-07-07 23:29:01 +0000
+++ test-local	2011-09-07 13:22:25 +0000
@@ -4,16 +4,26 @@
 
 import apport
 from apport.crashdb import get_crashdb
+from launchpadlib.launchpad import Launchpad
+
+def match_bug(bugnumber):
+    db = get_crashdb(None)
+    report = db.download(bugnumber)
+    match = report.search_bug_patterns('bugpatterns.xml')
+    
+    if match:
+        print 'LP: #%s: Matched bug pattern: %s' % (bugnumber, match )
+    else:
+        print 'LP: #%s: No match' % bugnumber
+        sys.exit(1)
+
+lp = Launchpad.login_anonymously('apport', 'production')
 
 if len(sys.argv) != 2:
     print >> sys.stderr, 'Usage: %s <.crash file or bug number>' % sys.argv[0]
     sys.exit(1)
 
-if sys.argv[1].isdigit():
-    db = get_crashdb(None)
-    report = db.download(sys.argv[1])
-    #report.write(open('/tmp/report.crash', 'w'))
-else:
+if not sys.argv[1].isdigit():
     report = apport.Report()
     try:
         f = open(sys.argv[1])
@@ -22,12 +32,27 @@
         sys.exit(1)
     report.load(f)
     f.close()
-
-match = report.search_bug_patterns('bugpatterns.xml')
-
-if match:
-    print 'LP: #%s: Matched bug pattern: %s' % ( sys.argv[1], match )
+    match = report.search_bug_patterns('bugpatterns.xml')
+
+    if match:
+        print 'LP: #%s: Matched bug pattern: %s' % ( sys.argv[1], match )
+        sys.exit(0)
+    else:
+        print 'LP: #%s: No match' % sys.argv[1]
+        sys.exit(1)
+else:
+    match_bug(sys.argv[1])
+      
+    bug = lp.bugs[sys.argv[1]]
+    # if bug is a duplicate - call this for parent
+    if bug.duplicate_of:
+        match_bug(bug.duplicate_of.id)
+    if bug.duplicates.total_size:
+        print "Checking duplicate bugs.."
+        for duplicate in bug.duplicates:
+            # Skip if not an apport bug
+            for tag in duplicate.tags:
+                if 'apport-crash' in tag:
+                    match_bug(duplicate.id)
+
     sys.exit(0)
-else:
-    print 'LP: #%s: No match' % sys.argv[1]
-    sys.exit(1)