Merge lp:~rohangarg/user-setup/ubuntu into lp:~ubuntu-core-dev/user-setup/ubuntu

Proposed by Rohan Garg
Status: Merged
Merged at revision: 280
Proposed branch: lp:~rohangarg/user-setup/ubuntu
Merge into: lp:~ubuntu-core-dev/user-setup/ubuntu
Diff against target: 18 lines (+8/-0)
1 file modified
user-setup-apply (+8/-0)
To merge this branch: bzr merge lp:~rohangarg/user-setup/ubuntu
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+233732@code.launchpad.net

Description of the change

SDDM Support

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

The here-doc inside the quotes kind of confuses me; not that I'm saying it doesn't work, but it certainly requires thought. How about this structure instead:

  $log $chroot $ROOT /bin/sh -c "cat > /etc/sddm.conf" <<EOF
[Autologin]
...
EOF

lp:~rohangarg/user-setup/ubuntu updated
281. By Rohan Garg

Structure the code a bit better

Revision history for this message
Rohan Garg (rohangarg) wrote :

Fixed with r281

Revision history for this message
Colin Watson (cjwatson) wrote :

LGTM now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'user-setup-apply'
2--- user-setup-apply 2012-10-15 09:35:42 +0000
3+++ user-setup-apply 2014-09-16 12:46:52 +0000
4@@ -309,6 +309,14 @@
5 /etc/xdg/lubuntu/lxdm/lxdm.conf
6 fi
7
8+ if $chroot $ROOT [ -f /usr/bin/sddm ]; then
9+ # Configure SDDM autologin with plasma 5 session
10+ $log $chroot $ROOT /bin/sh -c "cat > /etc/sddm.conf" << EOF
11+[Autologin]
12+User=$USER
13+Session=plasma.desktop
14+EOF
15+ fi
16 if $chroot $ROOT [ -d /etc/lightdm ]; then
17 # Configure LightDM autologin
18 LightDMCustomFile=$ROOT/etc/lightdm/lightdm.conf

Subscribers

People subscribed via source and target branches

to all changes: