Merge lp:~rohangarg/ubiquity/ubiquity into lp:ubiquity

[Rohan Garg]

Inform the listview that it can assume all its items to be of uniform size as this greatly reduces the amount of work the UI has to do to layout it's popup. This also workarounds a bug where the combobox had to be clicked twice to get the list to show up

[lp:~rohangarg/ubiquity/ubiquity]

5949. By Dimitri John Ledkov on 2013-07-01

Use pyflakes3 instead of pyflakes, for better python3 checks.

[Aurélien Gâteau (agateau)]

Looks good to me. I would just suggest adding a comment before the added line to explain why this is done.

Another possible optimization would be to change set_language_choices() from:

    for choice in choices:
        self.combobox.addItem(str(choice))

to:

     self.combobox.addItems(choices)

Which is faster, and actually also avoids the problem.

review: Approve

[lp:~rohangarg/ubiquity/ubiquity]

5950. By Jonathan Riddell on 2013-07-08

[ Aurélien Gâteau ]
* Merge lp:~agateau/ubiquity/kde-rework-try-install-buttons
 - Make the icon part of the buttons so that they are clickable as
   well (I always click the icon and get frustrated it does not do
   anything...)
 - Use latest Oxygen icons

5951. By Colin Watson on 2013-07-09

merge lp:~laney/ubiquity/iso-639-b

5952. By Colin Watson on 2013-07-09

releasing version 2.15.9

[Dimitri John Ledkov (xnox)]

Should this be merged, or agateau's suggestion used?

review: Needs Information

[lp:~rohangarg/ubiquity/ubiquity]

5953. By Dimitri John Ledkov on 2013-07-09

Change Ubuntu Studio background in ubiquity-dm.

5954. By Dimitri John Ledkov on 2013-07-11

* Don't tell automake to install everything to ubiquity-frontend-gtk and
  try to clean up after
* Reorganize app icon handling
  - Fixes missing app icon in GNOME Shell (LP: #1164573)
  - Use improved icon from Humanity as fallback icon
* Update *.install files for above changes
* Fix minor lintian warning by not installing empty /usr/share/applications/

5955. By Jonathan Riddell on 2013-07-13

[ Aurélien Gâteau ]
KDE: Set icon theme to Oxygen, shows icons on standalone Ubiquity

[Rohan Garg (rohangarg)]

Both suggestions are optimizations, and it'll be good to have both. I'll add Aurélien suggestion to the code as well.

[lp:~rohangarg/ubiquity/ubiquity]

5956. By Dimitri John Ledkov on 2013-07-18

Add initial autopilot support! UI testing, brave new world!

5957. By Stéphane Graber on 2013-07-18

Always install shim-signed, grub-efi-amd64-signed and linux-signed-generic on UEFI systems.

5958. By Stéphane Graber on 2013-07-18

Update d-i sources.

5959. By Stéphane Graber on 2013-07-18

Fix mixed tabs/spaces in test_ubiquity_custom.py

5960. By Stéphane Graber on 2013-07-18

Fix autopkgtests to pass pyflakes.

5961. By Stéphane Graber on 2013-07-18

releasing version 2.15.10

5962. By Stéphane Graber on 2013-07-19

Update d-i sources.

5963. By Stéphane Graber on 2013-07-19

releasing version 2.15.11

5964. By Dimitri John Ledkov on 2013-07-23

[qt] Fix language drop down list closes on first click (LP:
#1187762)

=== modified file 'ubiquity/plugins/ubi-language.py'
--- ubiquity/plugins/ubi-language.py	2013-07-08 14:45:24 +0000
+++ ubiquity/plugins/ubi-language.py	2013-07-18 14:32:28 +0000
@@ -398,6 +398,9 @@
             from PyQt4.QtGui import QWidget, QPixmap, QIcon
             self.page = uic.loadUi('/usr/share/ubiquity/qt/stepLanguage.ui')
             self.combobox = self.page.language_combobox
+            # Tell layout that all items are of uniform sizes
+            # Fixes LP:1187762
+            self.combobox.view().setUniformItemSizes(True)
             self.combobox.currentIndexChanged[str].connect(
                 self.on_language_selection_changed)
             if not self.controller.oem_config:
@@ -502,8 +505,7 @@
     def set_language_choices(self, choices, choice_map):
         PageBase.set_language_choices(self, choices, choice_map)
         self.combobox.clear()
-        for choice in choices:
-            self.combobox.addItem(str(choice))
+        self.combobox.addItems(choices)
 
     def set_language(self, language):
         index = self.combobox.findText(str(language))