Merge lp:~rohangarg/software-properties/fix-for-1307170 into lp:software-properties

Proposed by Rohan Garg
Status: Merged
Merge reported by: Harald Sitter
Merged at revision: not available
Proposed branch: lp:~rohangarg/software-properties/fix-for-1307170
Merge into: lp:software-properties
Diff against target: 39 lines (+14/-0)
2 files modified
debian/changelog (+7/-0)
software-properties-kde (+7/-0)
To merge this branch: bzr merge lp:~rohangarg/software-properties/fix-for-1307170
Reviewer Review Type Date Requested Status
Harald Sitter Approve
KDEUSER56 (community) Approve
Review via email: mp+215580@code.launchpad.net
To post a comment you must log in.
901. By Rohan Garg

Remove superfluous carriage returns

Revision history for this message
KDEUSER56 (kdeuser56) wrote :

Solves the issue for me with high probability (this is an issue not reproducible every time, so one cannot confirm 100%), but I tried it quite often and it does not crash anymore

review: Approve
902. By Rohan Garg

Documentation++

903. By Rohan Garg

Fix changelog

904. By Rohan Garg

Indentation--

Revision history for this message
Harald Sitter (apachelogger) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-04-04 06:52:18 +0000
3+++ debian/changelog 2014-04-14 09:41:43 +0000
4@@ -1,3 +1,10 @@
5+software-properties (0.92.35ubuntu1) UNRELEASED; urgency=medium
6+
7+ * software-properties-kde : Work around crash in sip by skipping the
8+ destructors of SIP objects. (LP: #1307170)
9+
10+ -- Rohan Garg <rohangarg@kubuntu.org> Mon, 14 Apr 2014 11:36:28 +0200
11+
12 software-properties (0.92.35) trusty; urgency=low
13
14 * Add "Additional Drivers" desktop file for the non {GNOME,Unity,KDE}
15
16=== modified file 'software-properties-kde'
17--- software-properties-kde 2012-07-05 13:32:44 +0000
18+++ software-properties-kde 2014-04-14 09:41:43 +0000
19@@ -37,6 +37,8 @@
20 from PyKDE4.kdecore import ki18n, KAboutData, KCmdLineArgs , KCmdLineOptions
21 from PyKDE4.kdeui import KApplication, KMessageBox
22
23+import sip
24+
25 class OptionParsed:
26 debug = False
27 massive_debug = False
28@@ -46,6 +48,11 @@
29
30 #--------------- main ------------------
31 if __name__ == '__main__':
32+ # Workaround for LP:1307170
33+ try:
34+ sip.setdestroyonexit(False)
35+ except AttributeError:
36+ pass
37 _ = gettext.gettext
38
39 appName = "softwarepropertieskde"

Subscribers

People subscribed via source and target branches

to status/vote changes: