lp:~rogpeppe/pyjuju/go-state-add-errors

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

60. By Roger Peppe on 2012-02-14

change error message

59. By Roger Peppe on 2012-02-14

copy state errors

58. By Gustavo Niemeyer on 2012-02-13

store: do not log events internally on Publish

The external code that calls Publish has to deal with event logging
anyway for logging failures and whatnot. It's trivial for it to log the
error and success case from Publish too, so there's no reason to have
that logic duplicated in two different places. In fact, it's harder to
deal with it because the call site has to take care not to log errors
twice in that particular case.

R=rog, fwereade
CC=
https://codereview.appspot.com/5654081

57. By Gustavo Niemeyer on 2012-02-10

store: store a single charm for all its urls

It's clear now that storing multiple charms just because
they have a different URL is unnecessary.

Also add index for events collection.

R=fwereade, rog
CC=
https://codereview.appspot.com/5639067

56. By Gustavo Niemeyer on 2012-02-10

charm: url Collection is pointless

R=fwereade, rog
CC=
https://codereview.appspot.com/5639065

55. By Gustavo Niemeyer on 2012-02-10

charm: fix symlink and file mode when bundling/expanding

R=fwereade, rog
CC=
https://codereview.appspot.com/5647047

54. By Roger Peppe on 2012-02-10

state: add Info type and make Open use it

R=TheMue, fwereade, niemeyer
CC=
https://codereview.appspot.com/5655043

53. By Frank Mueller on 2012-02-09

Started Machine integration into the state package

A first raw Machine type has been added to add the Machine
related methods to unit. Additionally all Machine related
methods in topology have been added. Beside this major topic
Unit has been extended by few further methods.

R=niemeyer
CC=
https://codereview.appspot.com/5647055

52. By Gustavo Niemeyer on 2012-02-08

store: refactored AddCharm into a CharmPublisher

AddCharm required having the charm at hand when it was first called,
which meant the application would have to download the charm and
be ready to bundle it before even knowing if the charm was already
up-to-date or not.

This refactoring improves the situation by moving the charm importing
aspect onto a CharmPublisher, so when one is acquiring the charm
publisher from the store, it's already possible to tell if a charm
with the given URL and digest should not be imported, and not even
downloaded.

This change also simplfies other aspects. Now the whole importing
procedure sits within CharmPublisher.Publish, including publishing
of successful and failure events. There is still a reason to
publish failure events outside of the Publish method, but a lot
is being covered internally.

R=fwereade
CC=
https://codereview.appspot.com/5616058

51. By Roger Peppe on 2012-02-03

environs/ec2: add code to create juju-specific cloudinit data.

When we create another provider, this code will be factored out,
but for the time being we'll keep it local to environs/ec2.

Also add a function to get ssh authorized keys.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/5610050