lp:~rogpeppe/juju-core/500-errgo-fix

charm/repo_test.go (+32/-9)
cmd/juju/main.go (+41/-38)
cmd/jujud/machine.go (+3/-0)
container/kvm/kvm.go (+3/-0)
dependencies.tsv (+1/-0)
errors/errors.go (+5/-6)
errors/errors_test.go (+5/-4)
rpc/server.go (+1/-0)
state/addmachine.go (+43/-42)
state/address.go (+10/-9)
state/annotator.go (+10/-10)
state/api/agent/state.go (+6/-7)
state/api/agent/unit_test.go (+0/-1)
state/api/allwatcher.go (+1/-3)
state/api/apiclient.go (+6/-3)
state/api/base/caller.go (+11/-0)
state/api/charmrevisionupdater/package_test.go (+1/-2)
state/api/charmrevisionupdater/updater.go (+1/-1)
state/api/client.go (+20/-17)
state/api/client_test.go (+1/-2)
state/api/common/environwatcher.go (+4/-4)
state/api/common/life.go (+4/-5)
state/api/deployer/deployer.go (+4/-4)
state/api/deployer/deployer_test.go (+4/-4)
state/api/deployer/machine.go (+4/-4)
state/api/deployer/unit.go (+4/-3)
state/api/environment/package_test.go (+1/-2)
state/api/export_test.go (+1/-0)
state/api/firewaller/firewaller.go (+11/-8)
state/api/firewaller/firewaller_test.go (+1/-2)
state/api/firewaller/machine.go (+6/-6)
state/api/firewaller/service.go (+7/-5)
state/api/firewaller/unit.go (+10/-8)
state/api/keymanager/client_test.go (+1/-2)
state/api/keymanager/package_test.go (+1/-2)
state/api/keyupdater/authorisedkeys.go (+7/-8)
state/api/keyupdater/package_test.go (+1/-2)
state/api/logger/logger.go (+6/-7)
state/api/logger/package_test.go (+1/-2)
state/api/machiner/machine.go (+9/-9)
state/api/machiner/machiner.go (+1/-1)
state/api/machiner/machiner_test.go (+1/-2)
state/api/params/apierror.go (+72/-50)
state/api/params/constants.go (+1/-0)
state/api/params/internal.go (+1/-2)
state/api/params/params.go (+11/-10)
state/api/params/params_test.go (+1/-2)
state/api/provisioner/machine.go (+23/-22)
state/api/provisioner/provisioner.go (+10/-11)
state/api/provisioner/provisioner_test.go (+1/-2)
state/api/state_test.go (+1/-2)
state/api/uniter/charm.go (+7/-6)
state/api/uniter/endpoint.go (+1/-3)
state/api/uniter/relation.go (+10/-7)
state/api/uniter/relationunit.go (+10/-10)
state/api/uniter/service.go (+12/-10)
state/api/uniter/settings.go (+2/-1)
state/api/uniter/state_test.go (+1/-3)
state/api/uniter/unit.go (+34/-33)
state/api/uniter/unit_test.go (+2/-1)
state/api/uniter/uniter.go (+19/-20)
state/api/uniter/uniter_test.go (+1/-2)
state/api/upgrader/upgrader.go (+11/-12)
state/api/upgrader/upgrader_test.go (+1/-2)
state/api/watcher/interfaces.go (+1/-3)
state/api/watcher/watcher.go (+1/-2)
state/api/watcher/watcher_test.go (+1/-2)
state/apiserver/admin.go (+7/-7)
state/apiserver/agent/agent_test.go (+1/-2)
state/apiserver/apiserver.go (+6/-6)
state/apiserver/charmrevisionupdater/package_test.go (+1/-2)
state/apiserver/charmrevisionupdater/testing/suite.go (+1/-2)
state/apiserver/charmrevisionupdater/updater.go (+4/-1)
state/apiserver/charms.go (+49/-47)
state/apiserver/charms_test.go (+1/-2)
state/apiserver/client/api_test.go (+1/-2)
state/apiserver/client/client.go (+104/-100)
state/apiserver/client/client_test.go (+1/-2)
state/apiserver/client/destroy.go (+14/-13)
state/apiserver/client/destroy_test.go (+2/-1)
state/apiserver/client/get.go (+5/-5)
state/apiserver/client/get_test.go (+0/-1)
state/apiserver/client/run.go (+12/-9)
state/apiserver/client/run_test.go (+1/-2)
state/apiserver/client/status.go (+1/-1)
state/apiserver/client/tools.go (+3/-4)
state/apiserver/common/addresses.go (+2/-2)
state/apiserver/common/common_test.go (+2/-2)
state/apiserver/common/ensuredead.go (+3/-2)
state/apiserver/common/ensuredead_test.go (+4/-5)
state/apiserver/common/environmachineswatcher.go (+3/-4)
state/apiserver/common/environmachineswatcher_test.go (+2/-3)
state/apiserver/common/environwatcher.go (+5/-4)
state/apiserver/common/environwatcher_test.go (+4/-5)
state/apiserver/common/errors.go (+25/-13)
state/apiserver/common/errors_test.go (+3/-3)
state/apiserver/common/instanceidgetter.go (+3/-2)
state/apiserver/common/instanceidgetter_test.go (+3/-4)
state/apiserver/common/interfaces.go (+2/-2)
state/apiserver/common/life.go (+3/-2)
state/apiserver/common/life_test.go (+3/-4)
state/apiserver/common/password.go (+4/-3)
state/apiserver/common/password_test.go (+5/-4)
state/apiserver/common/remove.go (+6/-6)
state/apiserver/common/remove_test.go (+5/-6)
state/apiserver/common/resource.go (+1/-2)
state/apiserver/common/resource_test.go (+1/-2)
state/apiserver/common/setstatus.go (+3/-2)
state/apiserver/common/setstatus_test.go (+4/-5)
state/apiserver/common/tools.go (+10/-9)
state/apiserver/common/tools_test.go (+2/-3)
state/apiserver/common/unitswatcher.go (+3/-2)
state/apiserver/common/unitswatcher_test.go (+3/-4)
state/apiserver/common/watch.go (+3/-2)
state/apiserver/common/watch_test.go (+3/-4)
state/apiserver/deployer/deployer.go (+9/-6)
state/apiserver/deployer/deployer_test.go (+1/-2)
state/apiserver/environment/package_test.go (+1/-2)
state/apiserver/firewaller/firewaller.go (+14/-9)
state/apiserver/firewaller/firewaller_test.go (+1/-2)
state/apiserver/keymanager/keymanager.go (+17/-15)
state/apiserver/keymanager/package_test.go (+1/-2)
state/apiserver/keymanager/testing/fakesshimport.go (+2/-1)
state/apiserver/keyupdater/authorisedkeys.go (+5/-2)
state/apiserver/keyupdater/package_test.go (+1/-2)
state/apiserver/logger/logger.go (+0/-1)
state/apiserver/logger/package_test.go (+1/-2)
state/apiserver/login_test.go (+4/-3)
state/apiserver/machine/common_test.go (+1/-2)
state/apiserver/machine/machiner.go (+5/-2)
state/apiserver/pinger_test.go (+3/-2)
state/apiserver/provisioner/provisioner.go (+15/-10)
state/apiserver/provisioner/provisioner_test.go (+2/-3)
state/apiserver/root.go (+5/-5)
state/apiserver/root_test.go (+1/-2)
state/apiserver/server_test.go (+4/-8)
state/apiserver/testing/errors.go (+0/-1)
state/apiserver/testing/fakeauthorizer.go (+1/-3)
state/apiserver/uniter/uniter.go (+50/-46)
state/apiserver/uniter/uniter_test.go (+1/-2)
state/apiserver/upgrader/suite_test.go (+2/-1)
state/apiserver/upgrader/upgrader.go (+8/-5)
state/apiserver/utils.go (+2/-3)
state/apiserver/watcher.go (+3/-4)
state/assign_test.go (+1/-2)
state/charm.go (+1/-2)
state/charm_test.go (+1/-2)
state/cleanup.go (+26/-24)
state/cleanup_test.go (+0/-1)
state/constraints.go (+4/-5)
state/container.go (+0/-1)
state/endpoint.go (+2/-3)
state/environ.go (+3/-2)
state/export_test.go (+2/-1)
state/life.go (+0/-1)
state/machine.go (+51/-50)
state/machine_test.go (+2/-3)
state/megawatcher.go (+14/-14)
state/megawatcher_internal_test.go (+4/-4)
state/minimumunits.go (+10/-8)
state/minimumunits_test.go (+2/-1)
state/multiwatcher/multiwatcher.go (+5/-3)
state/multiwatcher/multiwatcher_internal_test.go (+5/-5)
state/open.go (+15/-15)
state/presence/presence.go (+25/-22)
state/relation.go (+15/-15)
state/relationunit.go (+35/-34)
state/relationunit_test.go (+4/-3)
state/sequence.go (+2/-3)
state/service.go (+61/-58)
state/service_test.go (+4/-3)
state/settings.go (+13/-12)
state/settings_test.go (+1/-1)
state/state.go (+116/-110)
state/state_test.go (+6/-5)
state/statecmd/destroymachines.go (+3/-3)
state/statecmd/machineconfig.go (+18/-14)
state/statecmd/machineconfig_test.go (+1/-2)
state/statecmd/status.go (+18/-16)
state/status.go (+7/-8)
state/testing/config.go (+5/-2)
state/testing/watcher.go (+1/-2)
state/tools_test.go (+0/-1)
state/unit.go (+85/-84)
state/unit_test.go (+4/-3)
state/user.go (+12/-12)
state/watcher.go (+40/-39)
state/watcher/helpers.go (+2/-1)
state/watcher/helpers_test.go (+1/-1)
state/watcher/watcher.go (+9/-6)
utils/apt.go (+6/-3)
utils/apt_test.go (+5/-6)
utils/attempt.go (+1/-3)
utils/attempt_test.go (+1/-2)
utils/command.go (+1/-1)
utils/command_test.go (+1/-2)
utils/exec/package_test.go (+1/-2)
utils/file.go (+5/-5)
utils/file_test.go (+1/-2)
utils/file_unix.go (+1/-3)
utils/fslock/fslock.go (+13/-10)
utils/fslock/fslock_test.go (+5/-4)
utils/fslock/package_test.go (+1/-2)
utils/http_test.go (+1/-2)
utils/network.go (+3/-3)
utils/network_test.go (+1/-2)
utils/parallel/parallel_test.go (+1/-2)
utils/parallel/try.go (+1/-1)
utils/parallel/try_test.go (+6/-6)
utils/password.go (+4/-4)
utils/set/strings.go (+1/-3)
utils/set/strings_test.go (+1/-2)
utils/ssh/authorisedkeys.go (+26/-23)
utils/ssh/authorisedkeys_test.go (+1/-2)
utils/ssh/clientkeys.go (+12/-12)
utils/ssh/clientkeys_test.go (+1/-2)
utils/ssh/fingerprint.go (+3/-1)
utils/ssh/generate.go (+3/-2)
utils/ssh/run.go (+4/-4)
utils/ssh/run_test.go (+1/-2)
utils/ssh/ssh.go (+7/-5)
utils/ssh/ssh_gocrypto.go (+12/-11)
utils/ssh/ssh_openssh.go (+8/-7)
utils/ssh/ssh_test.go (+1/-2)
utils/ssh/testing/fakessh.go (+1/-2)
utils/tailer/tailer.go (+9/-4)
utils/tailer/tailer_test.go (+5/-5)
utils/trivial.go (+8/-8)
utils/trivial_test.go (+1/-2)
utils/uuid.go (+6/-3)
utils/zfile_windows.go (+1/-0)
worker/authenticationworker/worker_test.go (+1/-2)
worker/charmrevisionworker/revisionupdater.go (+1/-2)
worker/charmrevisionworker/revisionupdater_test.go (+1/-2)
worker/cleaner/cleaner_test.go (+1/-2)
worker/deployer/deployer.go (+14/-13)
worker/deployer/deployer_test.go (+1/-2)
worker/deployer/simple.go (+11/-10)
worker/environ.go (+4/-2)
worker/environ_test.go (+1/-2)
worker/export_test.go (+1/-3)
worker/firewaller/firewaller.go (+53/-42)
worker/firewaller/firewaller_test.go (+1/-2)
worker/instancepoller/machine_test.go (+3/-4)
worker/instancepoller/observer.go (+1/-1)
worker/instancepoller/updater.go (+8/-6)
worker/instancepoller/updater_test.go (+1/-1)
worker/instancepoller/worker.go (+3/-3)
worker/instancepoller/worker_test.go (+1/-2)
worker/localstorage/config.go (+2/-2)
worker/localstorage/config_test.go (+1/-2)
worker/localstorage/worker.go (+4/-1)
worker/logger/logger.go (+0/-1)
worker/logger/package_test.go (+1/-2)
worker/machineenvironmentworker/machineenvironmentworker.go (+6/-3)
worker/machineenvironmentworker/machineenvironmentworker_test.go (+1/-2)
worker/machineenvironmentworker/package_test.go (+1/-2)
worker/machiner/machiner.go (+10/-8)
worker/machiner/machiner_test.go (+4/-4)
worker/minunitsworker/minunitsworker.go (+4/-1)
worker/notifyworker.go (+11/-3)
worker/notifyworker_test.go (+8/-7)
worker/provisioner/container_initialisation.go (+5/-4)
worker/provisioner/container_initialisation_test.go (+1/-2)
worker/provisioner/export_test.go (+1/-3)
worker/provisioner/kvm-broker.go (+1/-1)
worker/provisioner/kvm-broker_test.go (+1/-2)
worker/provisioner/lxc-broker.go (+0/-1)
worker/provisioner/lxc-broker_test.go (+1/-2)
worker/provisioner/package_test.go (+1/-2)
worker/provisioner/provisioner.go (+21/-10)
worker/provisioner/provisioner_task.go (+15/-14)
worker/resumer/export_test.go (+1/-3)
worker/resumer/resumer.go (+1/-2)
worker/resumer/resumer_test.go (+1/-2)
worker/runner.go (+1/-1)
worker/runner_test.go (+15/-15)
worker/stringsworker.go (+1/-1)
worker/stringsworker_test.go (+8/-8)
worker/terminationworker/worker.go (+1/-2)
worker/terminationworker/worker_test.go (+2/-1)
worker/uniter/charm/charm.go (+11/-9)
worker/uniter/charm/charm_test.go (+1/-2)
worker/uniter/charm/deployer.go (+26/-25)
worker/uniter/charm/deployer_test.go (+4/-3)
worker/uniter/charm/export_test.go (+1/-0)
worker/uniter/charm/git.go (+17/-17)
worker/uniter/charm/git_test.go (+3/-2)
worker/uniter/context.go (+6/-5)
worker/uniter/context_test.go (+1/-2)
worker/uniter/debug/client.go (+1/-2)
worker/uniter/debug/client_test.go (+1/-2)
worker/uniter/debug/common.go (+1/-2)
worker/uniter/debug/common_test.go (+1/-2)
worker/uniter/debug/server.go (+7/-5)
worker/uniter/debug/server_test.go (+2/-1)
worker/uniter/export_test.go (+1/-3)
worker/uniter/filter.go (+24/-24)
worker/uniter/filter_test.go (+5/-3)
worker/uniter/hook/hook.go (+3/-4)
worker/uniter/hook/hook_test.go (+1/-2)
worker/uniter/jujuc/config-get.go (+3/-4)
worker/uniter/jujuc/config-get_test.go (+1/-2)
worker/uniter/jujuc/context.go (+3/-3)
worker/uniter/jujuc/juju-log.go (+1/-1)
worker/uniter/jujuc/owner-get.go (+3/-4)
worker/uniter/jujuc/owner-get_test.go (+1/-2)
worker/uniter/jujuc/ports.go (+4/-4)
worker/uniter/jujuc/relation-get.go (+6/-5)
worker/uniter/jujuc/relation-get_test.go (+1/-2)
worker/uniter/jujuc/relation-ids.go (+2/-1)
worker/uniter/jujuc/relation-ids_test.go (+0/-1)
worker/uniter/jujuc/relation-list.go (+3/-4)
worker/uniter/jujuc/relation-list_test.go (+0/-1)
worker/uniter/jujuc/relation-set.go (+4/-3)
worker/uniter/jujuc/relation-set_test.go (+0/-1)
worker/uniter/jujuc/server.go (+6/-3)
worker/uniter/jujuc/server_test.go (+3/-4)
worker/uniter/jujuc/unit-get.go (+3/-4)
worker/uniter/jujuc/unit-get_test.go (+1/-2)
worker/uniter/jujuc/util_test.go (+2/-1)
worker/uniter/modes.go (+43/-43)
worker/uniter/relation/hookqueue.go (+1/-2)
worker/uniter/relation/hookqueue_test.go (+1/-2)
worker/uniter/relation/relation.go (+19/-16)
worker/uniter/relation/relation_test.go (+1/-2)
worker/uniter/relationer.go (+3/-3)
worker/uniter/relationer_test.go (+1/-2)
worker/uniter/runlistener.go (+1/-1)
worker/uniter/runlistener_test.go (+1/-2)
worker/uniter/state.go (+9/-10)
worker/uniter/state_test.go (+6/-2)
worker/uniter/tools.go (+2/-2)
worker/uniter/tools_test.go (+1/-2)
worker/uniter/uniter.go (+67/-57)
worker/uniter/uniter_test.go (+2/-1)
worker/upgrader/export_test.go (+1/-3)
worker/upgrader/upgrader.go (+14/-10)
worker/upgrader/upgrader_test.go (+2/-2)