lp:~rogpeppe/juju-core/430-do-not-upload-fake-tools-in-live-tests

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2013-10-02

Diff: 53 lines (+0/-12)

2 files modified

environs/jujutest/livetests.go (+0/-4)
provider/ec2/live_test.go (+0/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1929. By Roger Peppe on 2013-10-02

provider/ec2: remove UploadFakeTools from live tests

1928. By Roger Peppe on 2013-10-02

environs/jujutest: don't upload fake tools in live tests

1927. By John A Meinel on 2013-10-02

[r=jameinel],[bug=1229480] environs/openstack: fix hpcloud description

Same fix for bug #1229480 that landed on the 1.14 branch, but fixing
it in 1.15 requires submitting it for review again.

https://codereview.appspot.com/14272043/

1926. By Roger Peppe on 2013-10-02

[r=rogpeppe] environs/dummy: add state-id

This makes the dummy provider more like the other
providers in that the Environ does not refer
directly to the bootstrapped state, but is looked
up when operations are performed on it.

This is also a test case for adding attributes at Prepare
time - many tests needed changing to correctly
deal with this.

https://codereview.appspot.com/14207046/

1925. By William Reade on 2013-10-02

[r=fwereade] provider/common: Destroy, and tests

Added a common implementation of Destroy, and tests for Bootstrap which had
somehow never been written. Also drive-by removed the machineId arg from
consideration when bootstrapping, because, WTF... a non-0 bootstrap machine
would break *everything*.

https://codereview.appspot.com/14254043/

1924. By Roger Peppe on 2013-10-02

[r=rogpeppe] provider/openstack: remove redundant fields

https://codereview.appspot.com/14123043/

1923. By Andrew Wilkins on 2013-10-02

[r=axwalk],[bug=1233924] provider/azure: remove default daily stream

The simplestreams.GetMetadata function was
being called with three datasources: storage,
daily and released. In our tests, storage was
empty, but daily and released were not; daily
did not, however, have any matching image ids.
There's an issue with simplestreams.GetMetadata
not attempting the next datasource if the
metadata index is valid, but does not contain
any matching product IDs.

Since the behaviour of simplestreams.GetMetadata
is potentially useful for private clouds, we
will just remove the daily stream from the defaults
for now. If people really want it, they can get
at it with image-stream and image-metadata-url.

Fixes #1233924

https://codereview.appspot.com/14266043/

1922. By Andrew Wilkins on 2013-10-02

[r=axwalk] environs/sshstorage: stream stdin

Change sshstorage's Put to stream to the
ssh command's stdin, rather than reading
into memory and then writing.

Also, drive-by: use `mktemp --tmpdir` rather
than exporting $TMPDIR.

https://codereview.appspot.com/14197043/

1921. By Andrew Wilkins on 2013-10-02

[r=axwalk] Wire up authenticating httpstorage

There are two things happening here:
 - httpstorage authentication changes
 - wiring up to null provider/localstorage worker.

The httpstorage authentication mechanism has
changed to use an auth key (randomly generated
as part of the boilerplate), rather than client
certificates. This gives us more options for
using the storage, since now you don't need the
client to share the CA key.

Also, when serving HTTPS, HTTP is *also* provided,
but only for non-modifying operations. This allows
wget et al. to fetch files from the storage without
bypassing certificate validation. The HTTP interface
disallows modifying operations if there is an HTTPS
interface backing it. To get an HTTPS URL, a HEAD
request may be performed on the HTTP interface.

https://codereview.appspot.com/14011044/

1920. By Andrew Wilkins on 2013-10-02

[r=axwalk] provider/null: define simplestreams tools source

This is somewhat involved, as there's some fixes
required (and one drive-by in sshstorage). The
change to use GetToolsSources is simple enough,
and matches what the local provider does.

The Environ override struct in cmd/juju/bootstrap.go
had to so that the optional Environ interfaces were
still implemented. Overriding like that loses the
additional interfaces.

To do the above, environs.BootstrapStorager has been
changed to have a method that tells the environ to
use bootstrap storage, rather than returning a
bootstrap storage. The null provider has changed to
match, of course, as well as cmd/juju.

https://codereview.appspot.com/14011046/