lp:~rogpeppe/juju-core/282-ec2-retry-put

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~juju/juju-core/trunk

Juju Engineering: Pending requested 2013-04-11

Diff: 343 lines (+113/-29) (has conflicts)

14 files modified

cmd/juju/synctools.go (+4/-0)
cmd/juju/synctools_test.go (+20/-0)
environs/dummy/storage.go (+1/-1)
environs/ec2/export_test.go (+1/-1)
environs/ec2/local_test.go (+2/-3)
environs/ec2/state.go (+1/-1)
environs/ec2/storage.go (+75/-16)
environs/interface.go (+3/-1)
environs/jujutest/livetests.go (+1/-1)
environs/jujutest/tests.go (+1/-1)
environs/local/storage.go (+1/-1)
environs/local/storage_test.go (+1/-1)
environs/openstack/state.go (+1/-1)
environs/openstack/storage.go (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1149. By Roger Peppe on 2013-04-15

environs/ec2: add TODOs

1148. By Roger Peppe on 2013-04-11

environs/ec2: retry s3 puts

1147. By Roger Peppe on 2013-04-11

state/api: enable authentication

R=fwereade, dfc
CC=
https://codereview.appspot.com/8626044

1146. By Roger Peppe on 2013-04-11

state/api: add Constraints to AllWatcher

R=
CC=
https://codereview.appspot.com/8568044

1145. By Dimiter Naydenov on 2013-04-11

cmd/juju: status displays machine errors

This makes the juju status command behave in a
more py-juju compatible way, displaying the
following additional information for each
machine:
  agent-state: [whatever machine.Status() reports]
  agent-state-info: [machine.Status().Info, if set]

"instance-state" is not possible to support right now,
so I didn't implement it, but filed a lp:1167441 bug.
Also, when the agent is detected as "down", the
agent-state-info shows the original status and the
info (if set).

Finally, there is a fix for the machiner to handle
SetAgentAlive() and testing it correctly.

R=rog, fwereade
CC=
https://codereview.appspot.com/8561046

1144. By Dimiter Naydenov on 2013-04-11

worker/machiner: set status and agent alive

The machiner will now set the machine status
as needed (started/stopped), log the actions
with Noticef, and SetAgentAlive(), as required.

R=fwereade, rog
CC=
https://codereview.appspot.com/8630043

1143. By Dave Cheney on 2013-04-11

source mongo from package

This proposal replaces the source of mongo for state servers. Mongo is now
installed from a package. The source of this package differs depending on the
series of the machine being bootstrapped (which is itself drawn from the tools
installed on the machine). For P and Q, the source is a PPA owned by the Juju
team. For R and above, mongo is available in the archive.

R=rog, dimitern, fwereade
CC=
https://codereview.appspot.com/8648043

1142. By Tim Penhey on 2013-04-11

Implement the set-environment command.

This change introduces a new command called set-environment. It has an alias
of set-env, and is the pair to get-environment.

Key/value pairs are taken on the command line as positional parameters.

The environment is retrieved from state, updated with the new values, and then
validated using the provider Validate method. The resulting configuration is
passed bach through to the state.SetEnvironConfig.

There are some standard config values that we really don't want
changing. These rules have been encoded in a new function config.Validate.
This is now called from each of the provider validate methods.

I added a non-exported helper method on Config to do the type coersion for
getting values from the known map. This is now used in many internal places.

Since the agent-version was always added in the config.New to be the default
value, I instead add this to the schema default values. The existing tests
make sure this still works as intended.

Added an extra test for backslashes in names. Moved the firewall-mode default
behaviour up into the base class, as it was identical in all three provider
validate methods.

R=fwereade, dfc
CC=
https://codereview.appspot.com/8610043

1141. By Tim Penhey on 2013-04-11

Add a get-environment command.

Be able to get environment values from state. You can ask for either a single
value, or get the whole lot formatted how you like (well within reason).

set-environment coming next.

R=dfc, dimitern, fwereade
CC=
https://codereview.appspot.com/8597045

1140. By William Reade on 2013-04-11

environs/tools: new package

Tools selection logic implemented for `juju sync-tools` moved into its own
package, and was expanded somewhat.

R=dfc, thumper, rog, TheMue, dimitern
CC=
https://codereview.appspot.com/8604043