lp:~rogpeppe/juju-core/256-more-status
- Get this branch:
- bzr branch lp:~rogpeppe/juju-core/256-more-status
Branch merges
Branch information
Recent revisions
- 1058. By Roger Peppe
-
statecmd: don't use juju.Conn unnecessarily
There's an associated cost when the API uses juju.Conn,
so we want to avoid it when reasonable.
This change moves some operations from juju into
state because they don't require juju.Conn's associated
Environ.R=fwereade, dimitern
CC=
https://codereview. appspot. com/7945044 - 1057. By Roger Peppe
-
state/api/params: add CharmURL to ServiceInfo
This is by way of an example of how new info
can be added to the data produced by the AllWatcher.R=fwereade, dfc, gary.poster
CC=
https://codereview. appspot. com/7950044 - 1056. By Roger Peppe
-
charm: add JSON support for URL
We want it for the API.
R=thumper, dfc, fwereade
CC=
https://codereview. appspot. com/7568049 - 1055. By Roger Peppe
-
state: add annotations to StateWatcher
R=fwereade, dimitern
CC=
https://codereview. appspot. com/7948043 - 1054. By Roger Peppe
-
docs/draft: API design document
R=jameinel, thumper
CC=
https://codereview. appspot. com/7314085 - 1053. By William Reade
-
cmd/jujud: upgrader skips unnecessary downloads
kinda trivial, but I couldn't figure out how to write a test case. Not
really keen toput in any more time on this, just saw it lying around --
I'm fine either submitting or rejecting as is.Agreed that a better-factored loop would simplify this a lot and make it
more testable; also agree out of scope.R=dfc, jameinel, thumper
CC=
https://codereview. appspot. com/7755045 - 1052. By William Reade
-
doc: rudimentary developer docs for state
This has been dashed off without deep thought; I'm sure there are bits
missing. If you, dear reader, are not especially familiar with the nuts
and bolts of state, I would particularly appreciate your input.R=rog, jameinel, dimitern
CC=
https://codereview. appspot. com/7631046 - 1051. By William Reade
-
uniter: fix flaky tests, poor isolation
The changed test case wasn't waiting for the right thing, because there
wasn't anything clear to wait for; changed the uniter deploy code such
that it only notifies remote state about a new charm *after* it's downloaded
and verified it but still before the change is applied. I can then write the
test such that I immediately request the uniter stop just after it starts
installing the new charm -- a procedure it won't interrupt -- and thus delay
the verifyCharm check until the charm is sure to have been deployed.This change has been verified by rogpeppe and frankban, both of whom saw the
original failures and now no longer do.I also fixed up test isolation via Reset, which was kinda crackful before.
R=jameinel, rog
CC=
https://codereview. appspot. com/7950043 - 1050. By William Reade
-
worker/uniter: unbreak trunk
Fix log-badge regexps broken by previous commit.
R=rog
CC=
https://codereview. appspot. com/7968043
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~juju/juju-core/trunk