https://codereview.appspot.com/5650075/diff/1/zk.go File zk.go (right):
https://codereview.appspot.com/5650075/diff/1/zk.go#newcode97 zk.go:97: // event. This is extremely redundant. Please use something along these lines instead:
type Event struct { Type int // One of the EVENT_* constants Path string // Node path for non-session events State int // One of the STATE_* constants }
Note that State exists for non-session events also.
https://codereview.appspot.com/5650075/diff/1/zk.go#newcode347 zk.go:347: // CVersion returns the number of changes to the children of the node. This needs clarification. Will a change in a child's data increase this version too?
https://codereview.appspot.com/5650075/diff/1/zk.go#newcode368 zk.go:368: // NumChildren returns the number of children of the znode. s/znode/node/, as everywhere else.
https://codereview.appspot.com/5650075/diff/1/zk.go#newcode373 zk.go:373: // Pzxid returns the Pzxid of the node, whatever that is. :-)
https://codereview.appspot.com/5650075/diff/1/zk_test.go File zk_test.go (right):
https://codereview.appspot.com/5650075/diff/1/zk_test.go#newcode187 zk_test.go:187: if dt < 0 || dt > maxdt { if t.Before(t0) || t.After(t1) {
https://codereview.appspot.com/5650075/
« Back to merge proposal
https:/ /codereview. appspot. com/5650075/ diff/1/ zk.go
File zk.go (right):
https:/ /codereview. appspot. com/5650075/ diff/1/ zk.go#newcode97
zk.go:97: // event.
This is extremely redundant. Please use something along these lines
instead:
type Event struct {
Type int // One of the EVENT_* constants
Path string // Node path for non-session events
State int // One of the STATE_* constants
}
Note that State exists for non-session events also.
https:/ /codereview. appspot. com/5650075/ diff/1/ zk.go#newcode34 7
zk.go:347: // CVersion returns the number of changes to the children of
the node.
This needs clarification. Will a change in a child's data increase this
version too?
https:/ /codereview. appspot. com/5650075/ diff/1/ zk.go#newcode36 8
zk.go:368: // NumChildren returns the number of children of the znode.
s/znode/node/, as everywhere else.
https:/ /codereview. appspot. com/5650075/ diff/1/ zk.go#newcode37 3
zk.go:373: // Pzxid returns the Pzxid of the node, whatever that is.
:-)
https:/ /codereview. appspot. com/5650075/ diff/1/ zk_test. go
File zk_test.go (right):
https:/ /codereview. appspot. com/5650075/ diff/1/ zk_test. go#newcode187
zk_test.go:187: if dt < 0 || dt > maxdt {
if t.Before(t0) || t.After(t1) {
https:/ /codereview. appspot. com/5650075/