lp:~rogpeppe/goamz/predictable-urls
- Get this branch:
- bzr branch lp:~rogpeppe/goamz/predictable-urls
Branch merges
- The Go Language Gophers: Pending requested
-
Diff: 78 lines (+34/-1)3 files modifieds3/s3.go (+19/-1)
s3/s3i_test.go (+11/-0)
s3/s3t_test.go (+4/-0)
Branch information
Recent revisions
- 11. By James Henstridge
-
s3: fix canonical path handling on signing
The Sign function was trying to reverse engineer the bucket name from the
Host header, which would result in incorrect signatures if it guessed wrong.Since prepare knows the bucket and key name (and uses it to decide how to
set the host header and path), having it pass the canonical path to Sign
removes this failure condition, and removes the need for Sign to have
specific knowledge of Amazon and DreamHost host names. - 10. By Dave Cheney
-
s3: fix regions that require lowercase buckets.
US regions are lax on this restriction, but other later regions
enforce bucket names that are also valid dns names.R=niemeyer
CC=
https://codereview. appspot. com/6343080 - 8. By Dave Cheney
-
s3: add LocationConstraint in PutBucket
The default value of and empty body is only valid for us-east-1, the
so called classic ec2 region. Non US regions required a location
constraint.R=niemeyer
CC=
https://codereview. appspot. com/6344050 - 7. By Dave Cheney
-
aws: add Region.Name and Regions
This proposal adds a canonical Name field to the region struct.
This field is needed for specifying the LocationConstraint when
using PutBucket (to come in a followup branch). I also took the
opportunity to move the Regions map into aws.goR=niemeyer
CC=
https://codereview. appspot. com/6347059 - 6. By Gustavo Niemeyer
-
s3: implemented SignedURL
This also cleans up the querying logic a bit to make
the implementation of SignedURL more reasonble.R=rog
CC=
https://codereview. appspot. com/6231044 - 5. By Gustavo Niemeyer
-
s3: add support for dreamhost and bucket names in the domain
S3 supports two ways to address bucket names: via a common
domain name plus a path, and via a domain named after the
user bucket. This adds support to the latter convention.It also includes support for talking to DreamHost's S3-like
endpoint, and fixes a bug in the tests.R=rog
CC=
https://codereview. appspot. com/6211070 - 4. By Roger Peppe
-
s3test: add list bucket functionality.
also refactor tests to match ec2 structure
and gofmt on the source tree.R=niemeyer
CC=
https://codereview. appspot. com/6201062
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~gophers/goamz/trunk