Merge ~rodsmith/plainbox-provider-checkbox:fix-too-many-ethernet into plainbox-provider-checkbox:master

[Rod Smith]

This is a replacement for the buggy merge request https://code.launchpad.net/~rodsmith/checkbox-support/+git/checkbox-support/+merge/331160, for bug #1718749 ("Too many Ethernet devices detected on Cavium Thunder X"). This MR takes a different approach, by modifying network_device_info in plainbox-provider-checkbox rather than udevadm.py in checkbox-support. The latter proved quite tricky, since the change that fixed the bug had side effects that broke several other, completely unrelated, tests (of QEMU KVM, card readers, accelerometers, etc.).

This approach localizes the change much later in the testing process, to the network_device_info test itself, so there's much less risk of side effects affecting non-network devices. This version simply omits devices with device names of "UNKNOWN" from the list of devices reported by udev.

[Sylvain Pineau (sylvain-pineau)]

safer indeed, thanks for your checkbox-support attempt though. Udev and NM are tricky to compare sometimes.

review: Approve

diff --git a/bin/network_device_info b/bin/network_device_info
index da2f5a2..174fbe8 100755
--- a/bin/network_device_info
+++ b/bin/network_device_info
@@ -58,7 +58,7 @@ nm_devices = []
 
 class UdevResult:
     def addDevice(self, device):
-        if device.category == 'NETWORK':
+        if device.category == 'NETWORK' and device.interface != "UNKNOWN":
             udev_devices.append(device)