Merge ~rodsmith/plainbox-provider-certification-server:fix-precheck-iperf-delay into plainbox-provider-certification-server:master
Proposed by
Rod Smith
Status: | Merged |
---|---|
Approved by: | Rod Smith |
Approved revision: | 0d1e58503b13ac9ae280d80af3328b117e908b67 |
Merged at revision: | 45c15d0af2e5ab74a44eb027d64e95a61896a634 |
Proposed branch: | ~rodsmith/plainbox-provider-certification-server:fix-precheck-iperf-delay |
Merge into: | plainbox-provider-certification-server:master |
Diff against target: |
13 lines (+1/-1) 1 file modified
tools/canonical-certification-precheck (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Lane | Approve | ||
Review via email: mp+372774@code.launchpad.net |
Commit message
Add a 5-second timeout to the iperf3 check in canonical-
Description of the change
I used the bash "timeout" feature because, although some versions of iperf3 support a --connect-timeout option that should do the job, that's not supported in all versions of iperf3.
To post a comment you must log in.
LGTM. Maybe in the future we can change this to use the built in function, but this is good. Thanks for addressing this.