Merge ~rodsmith/plainbox-provider-certification-server:add-jumbo-frames-test into plainbox-provider-certification-server:master

Proposed by Rod Smith
Status: Rejected
Rejected by: Rod Smith
Proposed branch: ~rodsmith/plainbox-provider-certification-server:add-jumbo-frames-test
Merge into: plainbox-provider-certification-server:master
Diff against target: 62 lines (+6/-1)
5 files modified
units/network-only-16.04.pxu (+1/-0)
units/server-full-16.04.pxu (+1/-0)
units/server-functional-16.04.pxu (+1/-0)
units/server-soc-cert-16.04.pxu (+2/-1)
units/virtual-machine-full-16.04.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Jeff Lane  Pending
Review via email: mp+318974@code.launchpad.net

Description of the change

This branch adds support for the new jumbo frames test. It should be merged only after that test is approved. See its merge request for details:

https://code.launchpad.net/~rodsmith/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/318973

To post a comment you must log in.
Revision history for this message
Rod Smith (rodsmith) wrote :

After discussion with Jeff, we're rejecting this because of problems (undiscovered before submission) with PXE-booting some servers when the MAAS server is set for jumbo frames. This is a problem with betelnut in Lexington and at least one or two servers in 1SS. The test idea is still valid, but would require a separate iperf server from the MAAS server, at a minimum, to implement reliably. Thus, dropping this test, which was never critical, seems to be the best approach.

Unmerged commits

e553c84... by Rod Smith

Modify server .pxu files to point to new jumbo-frames test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/network-only-16.04.pxu b/units/network-only-16.04.pxu
2index b4d6980..4572851 100644
3--- a/units/network-only-16.04.pxu
4+++ b/units/network-only-16.04.pxu
5@@ -41,6 +41,7 @@ include:
6 ethernet/ethtool_info
7 ethernet/ethertool_check_.*
8 ethernet/multi_iperf3_nic_.*
9+ ethernet/multi_jumbo_frames_nic_.*
10 bootstrap_include:
11 device
12 fwts
13diff --git a/units/server-full-16.04.pxu b/units/server-full-16.04.pxu
14index 6171c77..d0be4e6 100644
15--- a/units/server-full-16.04.pxu
16+++ b/units/server-full-16.04.pxu
17@@ -64,6 +64,7 @@ include:
18 ethernet/ethtool_info certification-status=non-blocker
19 ethernet/ethertool_check_.* certification-status=non-blocker
20 ethernet/multi_iperf3_nic_.* certification-status=blocker
21+ ethernet/multi_jumbo_frames_nic_.* certification-status=non-blocker
22 mediacard/sd-preinserted certification-status=blocker
23 memory/info certification-status=blocker
24 memory/memory_stress_ng certification-status=blocker
25diff --git a/units/server-functional-16.04.pxu b/units/server-functional-16.04.pxu
26index 95fedcb..0c27661 100644
27--- a/units/server-functional-16.04.pxu
28+++ b/units/server-functional-16.04.pxu
29@@ -64,6 +64,7 @@ include:
30 ethernet/ethtool_info certification-status=non-blocker
31 ethernet/ethertool_check_.* certification-status=non-blocker
32 ethernet/multi_iperf3_nic_.* certification-status=blocker
33+ ethernet/multi_jumbo_frames_nic_.* certification-status=non-blocker
34 mediacard/sd-preinserted certification-status=blocker
35 memory/info certification-status=blocker
36 optical/detect certification-status=non-blocker
37diff --git a/units/server-soc-cert-16.04.pxu b/units/server-soc-cert-16.04.pxu
38index 43896a7..46eafe2 100644
39--- a/units/server-soc-cert-16.04.pxu
40+++ b/units/server-soc-cert-16.04.pxu
41@@ -56,7 +56,8 @@ include:
42 ethernet/info_automated certification-status=non-blocker
43 ethernet/ethtool_info certification-status=non-blocker
44 ethernet/ethertool_check_.* certification-status=non-blocker
45- ethernet/multi_iperf3_nic_.* certification-status=blocker
46+ ethernet/multi_iperf3_nic_.* certification-status=blocker
47+ ethernet/multi_jumbo_frames_nic_.* certification-status=non-blocker
48 mediacard/sd-preinserted certification-status=blocker
49 memory/info certification-status=blocker
50 memory/memory_stress_ng certification-status=blocker
51diff --git a/units/virtual-machine-full-16.04.pxu b/units/virtual-machine-full-16.04.pxu
52index ca5d551..2eb03b1 100644
53--- a/units/virtual-machine-full-16.04.pxu
54+++ b/units/virtual-machine-full-16.04.pxu
55@@ -56,6 +56,7 @@ include:
56 ethernet/ethtool_info certification-status=non-blocker
57 ethernet/ethertool_check_.* certification-status=non-blocker
58 ethernet/multi_iperf3_nic_.* certification-status=blocker
59+ ethernet/multi_jumbo_frames_nic_.* certification-status=non-blocker
60 memory/info certification-status=blocker
61 memory/memory_stress_ng certification-status=blocker
62 power-management/rtc certification-status=blocker

Subscribers

People subscribed via source and target branches

to all changes: