Merge ~rodsmith/plainbox-provider-certification-server:fwupdate-test2 into plainbox-provider-certification-server:master

Proposed by Rod Smith
Status: Merged
Merged at revision: 63bbbc24d88c693568a0fb8484107c85281fdd83
Proposed branch: ~rodsmith/plainbox-provider-certification-server:fwupdate-test2
Merge into: plainbox-provider-certification-server:master
Diff against target: 49 lines (+8/-0)
4 files modified
units/firmware-tests.pxu (+1/-0)
units/packaging.pxu (+5/-0)
units/server-full-16.04.pxu (+1/-0)
units/server-functional-16.04.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+312589@code.launchpad.net

Description of the change

This is a new submission of the old merge to add the fwupdate test to the .pxu files for server cert. (The old submission was marked as merged after I accidentally re-used the wrong git branch as a basis for another merge.) See https://code.launchpad.net/~rodsmith/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/308857 for the actual new test.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

+1

review: Approve
Revision history for this message
Jeff Lane  (bladernr) wrote :

Now that I just pushed this, need to check one more thing (so I re-set it to needs review).

What about the fake package for fwupdate for 14.04 that Sylvain mentioned?

I saw email comments from him that aren't on this, I presume the were on the older version of this MR? Anyway, just need to make sure his comment is addressed so we don't break on 14.04... (not that I care about 14.04, but they do).

review: Needs Information
Revision history for this message
Jeff Lane  (bladernr) wrote :

weird...I moved it to needs info or whatever, and it still got merged. But dummy packages are done now anyway.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/firmware-tests.pxu b/units/firmware-tests.pxu
2index 2b0e098..ad6b286 100644
3--- a/units/firmware-tests.pxu
4+++ b/units/firmware-tests.pxu
5@@ -40,6 +40,7 @@ mandatory_include:
6 include:
7 miscellanea/ipmi_test
8 miscellanea/bmc_info
9+ miscellanea/fwupdate certification-status=non-blocker
10 miscellanea/fwts_test
11 miscellanea/fwts_results.log
12 memory/info
13diff --git a/units/packaging.pxu b/units/packaging.pxu
14index fe0e272..f309b10 100644
15--- a/units/packaging.pxu
16+++ b/units/packaging.pxu
17@@ -7,3 +7,8 @@ Depends: iperf3
18 unit: packaging meta-data
19 os-id: debian
20 Depends: genisoimage
21+
22+# The 'miscellanea/fwupdate' job requires the fwupdate package
23+unit: packaging meta-data
24+os-id: debian
25+Depends: fwupdate
26diff --git a/units/server-full-16.04.pxu b/units/server-full-16.04.pxu
27index c871460..6171c77 100644
28--- a/units/server-full-16.04.pxu
29+++ b/units/server-full-16.04.pxu
30@@ -43,6 +43,7 @@ include:
31 info/hdparm_.*.txt certification-status=non-blocker
32 miscellanea/ipmi_test certification-status=blocker
33 miscellanea/bmc_info certification-status=non-blocker
34+ miscellanea/fwupdate certification-status=non-blocker
35 benchmarks/disk/hdparm-read_.* certification-status=blocker
36 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
37 cpu/clocktest certification-status=blocker
38diff --git a/units/server-functional-16.04.pxu b/units/server-functional-16.04.pxu
39index e64bbef..95fedcb 100644
40--- a/units/server-functional-16.04.pxu
41+++ b/units/server-functional-16.04.pxu
42@@ -43,6 +43,7 @@ include:
43 info/hdparm_.*.txt certification-status=non-blocker
44 miscellanea/ipmi_test certification-status=blocker
45 miscellanea/bmc_info certification-status=non-blocker
46+ miscellanea/fwupdate certification-status=non-blocker
47 benchmarks/disk/hdparm-read_.* certification-status=blocker
48 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
49 cpu/clocktest certification-status=blocker

Subscribers

People subscribed via source and target branches

to all changes: