Merge ~rodsmith/plainbox-provider-certification-server:stressng-storageio into plainbox-provider-certification-server:master

Proposed by Rod Smith
Status: Merged
Approved by: Jeff Lane 
Approved revision: 85a58e8ecd54b00289ae3849511753ee736591f0
Merged at revision: 85a58e8ecd54b00289ae3849511753ee736591f0
Proposed branch: ~rodsmith/plainbox-provider-certification-server:stressng-storageio
Merge into: plainbox-provider-certification-server:master
Diff against target: 60 lines (+5/-0)
5 files modified
units/server-full-16.04.pxu (+1/-0)
units/server-functional-16.04.pxu (+1/-0)
units/server-soc-cert-16.04.pxu (+1/-0)
units/storage-only.pxu (+1/-0)
units/virtual-machine-full-16.04.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+300193@code.launchpad.net

Description of the change

Updated whitelists to add the new disk_stress_ng test to the server certification whitelists. Note:

* This relies on merge the bzr merge for the test:
  https://code.launchpad.net/~rodsmith/checkbox/stressng-storageio/+merge/300190
* I've added the new test only to the 16.04 whitelists and to the disk-only
  whitelist, since it relies on a few stressors that aren't present in 14.04's
  version of stress-ng.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

since I approved the other, I'll approve this now. That said, it occurrs to me that we need to run this for a bit and then make a decision shortly (maybe in a month or two to give it some time to be tested widely) to remove the storage_devices test in favor of this one.

That way we can avoid having two disk stress tests chewing up test time.

For now we can run both, I'll set a reminder to consider swapping entirely in a few weeks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/server-full-16.04.pxu b/units/server-full-16.04.pxu
2index 999403d..792cbd5 100644
3--- a/units/server-full-16.04.pxu
4+++ b/units/server-full-16.04.pxu
5@@ -56,6 +56,7 @@ include:
6 disk/read_performance_.* certification-status=blocker
7 disk/smart_.* certification-status=non-blocker
8 disk/storage_device_.* certification-status=blocker
9+ disk/disk_stress_ng_.* certification-status=blocker
10 ethernet/detect certification-status=non-blocker
11 ethernet/info_automated certification-status=non-blocker
12 ethernet/ethtool_info certification-status=non-blocker
13diff --git a/units/server-functional-16.04.pxu b/units/server-functional-16.04.pxu
14index a5ee66b..d08fbed 100644
15--- a/units/server-functional-16.04.pxu
16+++ b/units/server-functional-16.04.pxu
17@@ -56,6 +56,7 @@ include:
18 disk/read_performance_.* certification-status=blocker
19 disk/smart_.* certification-status=non-blocker
20 disk/storage_device_.* certification-status=blocker
21+ disk/disk_stress_ng_.* certification-status=blocker
22 ethernet/detect certification-status=non-blocker
23 ethernet/info_automated certification-status=non-blocker
24 ethernet/ethtool_info certification-status=non-blocker
25diff --git a/units/server-soc-cert-16.04.pxu b/units/server-soc-cert-16.04.pxu
26index dbb3a92..c96e7a0 100644
27--- a/units/server-soc-cert-16.04.pxu
28+++ b/units/server-soc-cert-16.04.pxu
29@@ -50,6 +50,7 @@ include:
30 disk/read_performance_.* certification-status=blocker
31 disk/smart_.* certification-status=non-blocker
32 disk/storage_device_.* certification-status=blocker
33+ disk/disk_stress_ng_.* certification-status=blocker
34 ethernet/detect certification-status=non-blocker
35 ethernet/info_automated certification-status=non-blocker
36 ethernet/ethtool_info certification-status=non-blocker
37diff --git a/units/storage-only.pxu b/units/storage-only.pxu
38index a3e31e2..1017f7f 100644
39--- a/units/storage-only.pxu
40+++ b/units/storage-only.pxu
41@@ -43,6 +43,7 @@ include:
42 disk/read_performance_.* certification-status=blocker
43 disk/smart_.* certification-status=non-blocker
44 disk/storage_device_.* certification-status=blocker
45+ disk/disk_stress_ng_.* certification-status=blocker
46 mediacard/sd-preinserted certification-status=blocker
47 bootstrap_include:
48 device
49diff --git a/units/virtual-machine-full-16.04.pxu b/units/virtual-machine-full-16.04.pxu
50index d07879e..14562cf 100644
51--- a/units/virtual-machine-full-16.04.pxu
52+++ b/units/virtual-machine-full-16.04.pxu
53@@ -50,6 +50,7 @@ include:
54 disk/read_performance_.* certification-status=blocker
55 disk/smart_.* certification-status=non-blocker
56 disk/storage_device_.* certification-status=blocker
57+ disk/disk_stress_ng_.* certification-status=blocker
58 ethernet/detect certification-status=non-blocker
59 ethernet/info_automated certification-status=non-blocker
60 ethernet/ethtool_info certification-status=non-blocker

Subscribers

People subscribed via source and target branches

to all changes: