Merge lp:~rodsmith/maas-cert-server/fix-zesty-deploy into lp:~hardware-certification/maas-cert-server/trunk

[Rod Smith]

This MR fixes bug #1679758, which was blocking deployment of Ubuntu 17.04 zesty beta on MAAS when our custom preseeds were in use. There were two issues:

1) Under zesty, installing canonical-certification-server results in
   the installation of mailutils, which in turn causes postfix to
   be installed. Unfortunately, postfix requires interaction during
   installation, so everything falls apart. Explicitly installing
   sendmail along with canonical-certification-checkbox causes
   postfix to not be installed, thus working around this issue.
2) The "secureid" mini-script in the preseed was causing something
   in /dev to remain open, thus preventing it from being
   unmounted at the end of the installation, and the install
   would then fail. Adding "sleep 5;" to the end of the
   "secureid" mini-script seems to fix this problem.

I've applied these fixes to both the standard and custom preseeds and tested with both, although we probably won't be using custom images with zesty or later.

[Jeff Lane  (bladernr)]

Please file a checkbox bug (probably plainbox-provider-checkbox) for this. Ultimately, something should not be installing postfix, but is... so that should be investigated upstream as well.

Otherwise, approve

review: Approve

[Rod Smith (rodsmith)]

OK, I've filed a second bug report, bug 1679833, against plainbox-provider-checkbox.

=== modified file 'debian/changelog'
--- debian/changelog	2017-01-18 20:02:39 +0000
+++ debian/changelog	2017-04-04 19:50:15 +0000
@@ -1,3 +1,9 @@
+maas-cert-server (0.2.30-0ppa1) xenial; urgency=medium
+
+  * Fix preseeds so that zesty deployments work.
+
+ -- Rod Smith <[e-mail]>  Tue, 04 Apr 2017 15:38:39 -0400
+
 maas-cert-server (0.2.29-0ppa1) xenial; urgency=medium
 
   * Minor tweak to maniacs-setup to cope with small MAAS API changes.

=== modified file 'preseed/curtin_userdata_cert'
--- preseed/curtin_userdata_cert	2016-12-09 09:36:13 +0000
+++ preseed/curtin_userdata_cert	2017-04-04 19:50:15 +0000
@@ -61,7 +61,7 @@
       echo " Running apt-get update...";
       apt-get update;
       echo " Installing checkbox certification...";
-      apt-get install -y --force-yes canonical-certification-server;
+      apt-get install -y --allow-unauthenticated canonical-certification-server sendmail;
       apt-get install dmidecode;
       sleep 60;
       echo "Done.";
@@ -119,7 +119,8 @@
            sudo sed -i "s/#\[transport:c3\]/\[transport:c3\]/g" /etc/xdg/canonical-certification.conf
            sudo sed -i "s/#secure_id =.*/secure_id = $secureid/g" /etc/xdg/canonical-certification.conf
          fi
-      done
+      done;
+      sleep 5;
 
 late_commands:
   maas: [wget, '--no-proxy', {{node_disable_pxe_url|escape.json}}, '--post-data', {{node_disable_pxe_data|escape.json}}, '-O', '/dev/null']

=== modified file 'preseed/curtin_userdata_custom_cert'
--- preseed/curtin_userdata_custom_cert	2016-12-09 09:36:13 +0000
+++ preseed/curtin_userdata_custom_cert	2017-04-04 19:50:15 +0000
@@ -61,7 +61,7 @@
       echo " Running apt-get update...";
       apt-get update;
       echo " Installing checkbox certification...";
-      apt-get install -y --force-yes canonical-certification-server;
+      apt-get install -y --allow-unauthenticated canonical-certification-server sendmail;
       apt-get install dmidecode;
       sleep 60;
       echo "Done.";
@@ -141,7 +141,8 @@
            sudo sed -i "s/#\[transport:c3\]/\[transport:c3\]/g" /etc/xdg/canonical-certification.conf
            sudo sed -i "s/#secure_id =.*/secure_id = $secureid/g" /etc/xdg/canonical-certification.conf
          fi
-      done
+      done;
+      sleep 5;
 
 late_commands:
   maas: [wget, '--no-proxy', {{node_disable_pxe_url|escape.json}}, '--post-data', {{node_disable_pxe_data|escape.json}}, '-O', '/dev/null']