Merge lp:~rodsmith/checkbox/smart-newdisk into lp:checkbox

[Rod Smith]

Fixes bug #1392010, which caused the SMART test to fail on disks with no prior SMART tests logged.

[Daniel Manrique (roadmr)]

Cool, I looked at this in context and it makes sense, plus is a fairly simple fix.

Thanks!

review: Approve

=== modified file 'providers/plainbox-provider-checkbox/bin/disk_smart'
--- providers/plainbox-provider-checkbox/bin/disk_smart	2014-10-09 19:45:26 +0000
+++ providers/plainbox-provider-checkbox/bin/disk_smart	2014-11-13 19:02:08 +0000
@@ -35,6 +35,7 @@
 
 Changelog:
 
+v1.4: Fix script failure on disks with no pre-existing SMART tests
 v1.3: Fix detection of SMART availability & activate SMART if available
       but deactivated. Also use smartctl return value rather than string-
       matching to determine if a test has failed; this should be more
@@ -167,7 +168,7 @@
     line = next(stdout_lines)
     if not line.startswith('Num'):
         entries.append('No entries found in log yet')
-        return entries
+        return entries, returncode
     columns = ['number', 'description', 'status',
                'remaining', 'lifetime', 'lba']
     lengths = [line.index(i) for i in line.split()]