Merge lp:~rodsmith/checkbox/ipmi_pxe_test_removal into lp:checkbox

[Rod Smith]

Removed IPMI and PXE manual server tests because MAAS testing will cover this.

Removed IPMI and PXE manual server tests because MAAS testing will cover this.

This should affect only 14.04, not 12.04.

[Brendan Donegan (brendan-donegan)]

Hi Rod,

Can you elaborate on the part about 'only 14.04'? Currently we don't have a good way to release changes to whitelists independently for different releases so if we merge this now, it's going to impact on 12.04 testing as well.

review: Needs Information

[Rod Smith (rodsmith)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/16/2014 02:52 AM, Brendan Donegan wrote:
> Review: Needs Information
>
> Hi Rod,
>
> Can you elaborate on the part about 'only 14.04'? Currently we
> don't have a good way to release changes to whitelists
> independently for different releases so if we merge this now, it's
> going to impact on 12.04 testing as well.

Better hold off, then. Jeff wants those tests removed for 14.04, but
not for 12.04, so we need some way to do that. I'm still new enough
that I don't fully understand the build and release process for
checkbox, so I'm referring this to Jeff for his comments.

- --
Rod Smith
Server and Cloud Certification Engineer
<email address hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS19SwAAoJEFgyRI+V0FjmHKEH/2vsPNCz99m9JcbuBwqm1Hur
MxT0qbJopve9WcLQ1Jisr6LegWA1xGd8DQtJOcDodAxTvVqxDKCXmkBSRekmQ/B5
KPlIouusNvUqF1Q58h0xvjKz9ZDkDM8oetnA2oE45eb1BFpj0kWREQ007syXw8No
LWYWKV9jv+kWgsTCN6ilbXJjHGFoU6nGyzaBt836wxC4CZNWWoxUl9ShJtkjnp6O
wWXHXMl9ZSplQpiKgEnFSJQnBoj3keoCZR+e5IlGTki7JGfygETX+np2EePAIQMd
O8iodu3NhPohbUSggWd3FjQQnBN8WufJXCfIQWFWL0M403TmQmJaLgYAdCig2YY=
=9dd5
-----END PGP SIGNATURE-----

[Zygmunt Krynicki (zyga)]

I'm rejecting this based on your comments. Please seek another solution and re-propose.

Unmerged revisions

2595. By Rod Smith on 2014-01-15

jobs/miscellanea.txt.in: Removed manual PXE and IPMI tests

=== modified file 'checkbox-old/data/whitelists/server-selftest.whitelist'
--- checkbox-old/data/whitelists/server-selftest.whitelist	2013-12-18 16:20:21 +0000
+++ checkbox-old/data/whitelists/server-selftest.whitelist	2014-01-15 21:58:48 +0000
@@ -44,11 +44,6 @@
 # Moved the miscellanea to put manual tests at the beginning
 __miscellanea__
 miscellanea/tester-info
-miscellanea/pxe_boot
-miscellanea/pxe_boot_.*
-miscellanea/remote_shared_ipmi
-miscellanea/remote_shared_ipmi_.*
-miscellanea/remote_dedicated_ipmi
 miscellanea/fwts_test
 miscellanea/fwts_results.log
 miscellanea/ipmi_test

=== modified file 'checkbox-old/debian/changelog'
--- checkbox-old/debian/changelog	2014-01-10 11:02:47 +0000
+++ checkbox-old/debian/changelog	2014-01-15 21:58:48 +0000
@@ -1,6 +1,7 @@
 checkbox (0.17.3) UNRELEASED; urgency=low
 
-  * Incremented changelog
+  [ Rod Smith ]
+  * jobs/miscellanea.txt.in: Removed manual PXE and IPMI tests
 
  -- Brendan Donegan <[e-mail]>  Fri, 10 Jan 2014 11:02:47 +0000
 

=== modified file 'checkbox-old/jobs/miscellanea.txt.in'
--- checkbox-old/jobs/miscellanea.txt.in	2013-12-17 20:16:24 +0000
+++ checkbox-old/jobs/miscellanea.txt.in	2014-01-15 21:58:48 +0000
@@ -77,54 +77,3 @@
 name: miscellanea/sources-list
 command: sources_test $SOURCES_LIST "$REPOSITORIES"
 _description: Checks that a specified sources list file contains the requested repositories
-
-plugin: local
-name: miscellanea/pxe_boot
-requires: device.category == 'NETWORK'
-_description: Automated job to generate the PXE verification test for each NIC.
-command:
- cat <<'EOF' | run_templates -s 'udev_resource | filter_templates -w "category=NETWORK" | awk "/path: / { print \$2 }" | xargs -n 1 sh -c "for i in \`ls /sys\$0/net 2>/dev/null\`; do echo \$0 \$i; done"'
- plugin: manual
- name: miscellanea/pxe_boot_$2
- description:
-  PURPOSE:
-    This test will verify that you have attempted to PXE boot this machine from
-    the network device $2.
-  STEPS:
-    1. Prior to running this test, you should have attempted to boot this system via PXE on every Network Port available.
-  VERIFICATION:
-    1. Select Yes if you successfully used PXE boot this system using the NIC $2
-    2. Select No if you did not attempt to PXE boot this system using the NIC $2
-    3. Select No if you attempted to PXE boot via $2 and it failed for some reason.
- EOF
-
-plugin: local
-name: miscellanea/remote_shared_ipmi
-requires: device.category == 'NETWORK'
-_description: Automated job to generate the Remote Shared IPMI verification test for each NIC.
-command:
- cat <<'EOF' | run_templates -s 'udev_resource | filter_templates -w "category=NETWORK" | awk "/path: / { print \$2 }" | xargs -n 1 sh -c "for i in \`ls /sys\$0/net 2>/dev/null\`; do echo \$0 \$i; done"'
- plugin: manual
- name: miscellanea/remote_shared_ipmi_$2
- description:
-  PURPOSE:
-    This test will verify that you have attempted IPMI control of this machine from the network device $2.
-  STEPS:
-    1. Prior to running this test, you should have configured and used IPMI to power this machine off and on using every Network Port available.
-  VERIFICATION:
-    1. Select Yes if you successfully used IPMI to remotely power this system off and on using the NIC $2
-    2. Select No if you did not attempt to use IPMI to remotely power this sytem off and on via the NIC $2
-    3. Select No if you attempted to use IPMI to remotely power off/on this system via $2 and it failed for some reason.
- EOF
-
-plugin: manual
-name: miscellanea/remote_dedicated_ipmi
-_description:
- PURPOSE:
-  Some systems do not share IPMI over all NICs but instead have a dedicated management port directly connected to the BMC.  This test verifies that you have used that port for remote IPMI connections and actions.
- STEPS:
-  1. Prior to running the test, you should have configured and used the Dedicated Management Port to remotely power off/on this sytem.
- VERIFICATION:
-  Skip this test if this system ONLY uses shared management/ethernet ports OR if this system does not have a BMC (Management Console)
-  1. Select Yes if you successfully used IPMI to remotely power this system off and on using the dedicated management port.
-  2. Select No if you attempted to use the dedicated management port to remotely power this system off/on and it failed for some reason.