Merge lp:~rodsmith/checkbox/fix-engineering-sample-detection into lp:checkbox

Proposed by Rod Smith
Status: Merged
Approved by: Jeff Lane 
Approved revision: 4364
Merged at revision: 4364
Proposed branch: lp:~rodsmith/checkbox/fix-engineering-sample-detection
Merge into: lp:checkbox
Diff against target: 11 lines (+1/-1)
1 file modified
providers/plainbox-provider-checkbox/bin/dmitest (+1/-1)
To merge this branch: bzr merge lp:~rodsmith/checkbox/fix-engineering-sample-detection
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+295243@code.launchpad.net

Description of the change

Expanded the check for engineering sample CPUs to include the string found in the suspected Intel engineering-sample CPUs.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks good to me...
You might want to give cwayne's team a heads up in case they use this in Client, as client does a lot of certifying of systems that would fail this test.

review: Approve
Revision history for this message
Taihsiang Ho (tai271828) wrote :

@Jeff
thanks for the heads up.

We did have systems like this and will pay attention on this MR.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/bin/dmitest'
2--- providers/plainbox-provider-checkbox/bin/dmitest 2015-11-24 14:54:34 +0000
3+++ providers/plainbox-provider-checkbox/bin/dmitest 2016-05-19 17:26:41 +0000
4@@ -256,7 +256,7 @@
5 if args.test_serials:
6 retval += serial_tests(args, stream)
7 if find_in_section(stream, 'Processor Information', 'Version:',
8- ['sample'], False):
9+ ['sample', 'Genuine Intel\(R\) CPU 0000'], False):
10 print("*** Invalid processor information!")
11 retval += 1
12

Subscribers

People subscribed via source and target branches