Merge lp:~rodrigo-moya/unity/add-panel-service-a11y into lp:unity

[Rodrigo Moya]

Add Util, Root and (beginning of) Indicators A11Y to panel service

[Alejandro Piñeiro (apinheiro)]

154 + if (!a11y_initialized)
155 + {

I think that it is worth to check the opposite, return if a11y_initialized. That would avoid a indentation level (IMHO, code would be clearer).

164 + /* Restore environment to load AT bridge */
165 + g_unsetenv ("NO_AT_BRIDGE");
166 + g_unsetenv ("NO_GAIL");

Take into account that there are one case (!should_enable_a11y) where you don't restore the environment, *but*, you modify the environment alway. Sorry, I was the one that suggested to move that to just before the load bridge, but probably this should be done as the first thing, to ensure that you always restore the environment (although this would only be a problem if there are a process child of this service, unlikely).

299 + atk_object_set_name (accessible, _("An indicator")); /* FIXME */

Do you really thing that worths to add this temporal names. Are useful for testing during development, but not sure if it is worth on have that on the actual code. If in the end you remove it, you will not require this include:
240 +#include <glib/gi18n.h>

294 +static void
295 +panel_indicator_accessible_initialize (AtkObject *accessible, gpointer data)
296 +{
297 + g_return_if_fail (PANEL_IS_INDICATOR_ACCESSIBLE (accessible));
298 +
299 + atk_object_set_name (accessible, _("An indicator")); /* FIXME */
300 + atk_object_set_role (accessible, ATK_ROLE_LABEL);
301 +
302 + ATK_OBJECT_CLASS (panel_indicator_accessible_parent_class)->initialize (accessible, data);

Although cally-root also calls the parent class initialize as the last thing, by default this should be done as the first thing of the initialize. Ie: imagine that the parent class also set a role, in that case that ATK_ROLE_LABEL would be unused.

508 + accessible->role = ATK_ROLE_APPLICATION;
509 + atk_object_set_name (accessible, _("Unity Panel Service"));

As the root represents the application I think that you should use the application name. Here you can use g_get_prgname(), like in gail or cally. I couldn't use that on Unity because I didn't found a equivalent to g_get_prgname to be used there (anyway, this is FIXME).

Some extra comments:

  * The indentation is somewhat weird. It seems that in some cases you have spaces and in other you have tabs, ie:
475 + atk_class->initialize = panel_root_accessible_initialize;
476 + atk_class->get_n_children = panel_root_accessible_get_n_children;
477 + atk_class->ref_child = panel_root_accessible_ref_child;
478 + atk_class->get_parent = panel_root_accessible_get_parent;

  * The way we reuse gail here is allow gtk_init to load gail but not the bridge, and then load the bridge. I don't like too much this mixed approach, as it could be prone-error (what would happen if for any reason gtk_init doesn't load the accessibility but panel-service yes, or the opposite). Taking into account the current wisdom (firefox and so on), probably we should do all the work. That means setting both NO_GAIL and NO_AT_BRIDGE, and then load by hand both gail and the bridge. But this could be done in a posterior task, but take that into account if you want to do that while solving the other issues.

review: Needs Fixing

[Alejandro Piñeiro (apinheiro)]

BTW, as this also touch panel-main.c code, probably you would require to add someone else to review the code.

[Rodrigo Moya (rodrigo-moya)]

> 154 + if (!a11y_initialized)
> 155 + {
>
> I think that it is worth to check the opposite, return if a11y_initialized.
> That would avoid a indentation level (IMHO, code would be clearer).
>
fixed

> 164 + /* Restore environment to load AT bridge */
> 165 + g_unsetenv ("NO_AT_BRIDGE");
> 166 + g_unsetenv ("NO_GAIL");
>
> Take into account that there are one case (!should_enable_a11y) where you
> don't restore the environment, *but*, you modify the environment alway. Sorry,
> I was the one that suggested to move that to just before the load bridge, but
> probably this should be done as the first thing, to ensure that you always
> restore the environment (although this would only be a problem if there are a
> process child of this service, unlikely).
>
done

>
> 299 + atk_object_set_name (accessible, _("An indicator")); /* FIXME */
>
> Do you really thing that worths to add this temporal names. Are useful for
> testing during development, but not sure if it is worth on have that on the
> actual code. If in the end you remove it, you will not require this include:
> 240 +#include <glib/gi18n.h>
>
in the next branch I will remove that temporary code, with real code to return the indicators. So just added this so that it shows something in accerciser.

>
> 294 +static void
> 295 +panel_indicator_accessible_initialize (AtkObject *accessible,
> gpointer data)
> 296 +{
> 297 + g_return_if_fail (PANEL_IS_INDICATOR_ACCESSIBLE (accessible));
> 298 +
> 299 + atk_object_set_name (accessible, _("An indicator")); /* FIXME */
> 300 + atk_object_set_role (accessible, ATK_ROLE_LABEL);
> 301 +
> 302 + ATK_OBJECT_CLASS
> (panel_indicator_accessible_parent_class)->initialize (accessible, data);
>
> Although cally-root also calls the parent class initialize as the last thing,
> by default this should be done as the first thing of the initialize. Ie:
> imagine that the parent class also set a role, in that case that
> ATK_ROLE_LABEL would be unused.
>
right, fixed

>
> 508 + accessible->role = ATK_ROLE_APPLICATION;
> 509 + atk_object_set_name (accessible, _("Unity Panel Service"));
>
> As the root represents the application I think that you should use the
> application name. Here you can use g_get_prgname(), like in gail or cally. I
> couldn't use that on Unity because I didn't found a equivalent to
> g_get_prgname to be used there (anyway, this is FIXME).
>
ok, fixed

> Some extra comments:
>
> * The indentation is somewhat weird. It seems that in some cases you have
> spaces and in other you have tabs, ie:
> 475 + atk_class->initialize = panel_root_accessible_initialize;
> 476 + atk_class->get_n_children = panel_root_accessible_get_n_children;
> 477 + atk_class->ref_child = panel_root_accessible_ref_child;
> 478 + atk_class->get_parent = panel_root_accessible_get_parent;
>
yes, seems I got the format header wrong, so I've removed it from all the files and fixed (hopefully) all TABs

>
> * The way we reuse gail here is allow gtk_init to load gail but not the
> bridge, and then load the bridge. I don't like too much this mixed approach,
> as it could be pron...

[Rodrigo Moya (rodrigo-moya)]

> BTW, as this also touch panel-main.c code, probably you would require to add
> someone else to review the code.

yes, as soon as you approve all the A11Y part, I'll ask for a 2nd approval, so yeah, any other unity developer can have a look at this branch, please?

[Alejandro Piñeiro (apinheiro)]

> > * The way we reuse gail here is allow gtk_init to load gail but not the
> > bridge, and then load the bridge. I don't like too much this mixed approach,
> > as it could be prone-error (what would happen if for any reason gtk_init
> > doesn't load the accessibility but panel-service yes, or the opposite).
> Taking
> > into account the current wisdom (firefox and so on), probably we should do
> all
> > the work. That means setting both NO_GAIL and NO_AT_BRIDGE, and then load by
> > hand both gail and the bridge. But this could be done in a posterior task,
> but
> > take that into account if you want to do that while solving the other
> issues.
> >
> ok, file a bug for that and assign it to me and I'll work on that on another
> branch

Ok, I will do that.

And as you changed the rest of the things, and I have just tested it, it seems ok for me.

Just a nitpick:

390 +#include <string.h>

Why do you require this new include?

review: Approve

[Alejandro Piñeiro (apinheiro)]

> > BTW, as this also touch panel-main.c code, probably you would require to add
> > someone else to review the code.
>
> yes, as soon as you approve all the A11Y part, I'll ask for a 2nd approval, so
> yeah, any other unity developer can have a look at this branch, please?

Alex Launi were reviewing my branches, although these days Loïc Molinari was also helping me with this kind of things.

You could try to ask them, or just ask David.

[Alex Launi (alexlauni)]

This looks pretty good to me.
But same question as Alejandro, why the added #include <string.h>. It doesn't look you add anything that uses string.h.

review: Approve

=== modified file 'services/CMakeLists.txt'
--- services/CMakeLists.txt	2010-11-29 12:02:39 +0000
+++ services/CMakeLists.txt	2011-01-31 21:55:43 +0000
@@ -24,9 +24,17 @@
 link_directories(${LIB_PATHS})
 
 add_executable(unity-panel-service
+               panel-a11y.c
+               panel-a11y.h
+               panel-indicator-accessible.c
+               panel-indicator-accessible.h
                panel-main.c
+               panel-root-accessible.c
+               panel-root-accessible.h
                panel-service.c
-               panel-service.h 
+               panel-service.h
+               panel-util-accessible.c
+               panel-util-accessible.h
               )
 install(TARGETS unity-panel-service DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/unity/)
 

=== added file 'services/panel-a11y.c'
--- services/panel-a11y.c	1970-01-01 00:00:00 +0000
+++ services/panel-a11y.c	2011-01-31 21:55:43 +0000
@@ -0,0 +1,150 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#include <gio/gio.h>
+#include "panel-a11y.h"
+#include "panel-util-accessible.h"
+
+static gboolean a11y_initialized = FALSE;
+
+#define INIT_METHOD "gnome_accessibility_module_init"
+#define DESKTOP_SCHEMA "org.gnome.desktop.interface"
+#define ACCESSIBILITY_ENABLED_KEY "accessibility"
+#define AT_SPI_SCHEMA "org.a11y.atspi"
+#define ATK_BRIDGE_LOCATION_KEY "atk-bridge-location"
+
+static gboolean
+has_gsettings_schema (const gchar *schema)
+{
+  const char * const *list_schemas = NULL;
+  gboolean found = FALSE;
+  int i = 0;
+
+  /* we need to check if AT_SPI_SCHEMA is present as g_settings_new
+     could abort if the schema is not here*/
+  list_schemas = g_settings_list_schemas ();
+  for (i = 0; list_schemas [i]; i++)
+    {
+      if (!g_strcmp0 (list_schemas[i], schema))
+        {
+          found = TRUE;
+          break;
+        }
+    }
+
+  return found;
+}
+
+static gboolean
+should_enable_a11y (void)
+{
+  GSettings *desktop_settings = NULL;
+  gboolean value = FALSE;
+
+  if (!has_gsettings_schema (DESKTOP_SCHEMA))
+    return FALSE;
+
+  desktop_settings = g_settings_new (DESKTOP_SCHEMA);
+  value = g_settings_get_boolean (desktop_settings, ACCESSIBILITY_ENABLED_KEY);
+
+  g_object_unref (desktop_settings);
+
+  return value;
+}
+
+static gchar*
+get_atk_bridge_path (void)
+{
+  GSettings *atspi_settings = NULL;
+  char *value = NULL;
+
+  if (!has_gsettings_schema (AT_SPI_SCHEMA))
+    return NULL;
+
+  atspi_settings = g_settings_new (AT_SPI_SCHEMA);
+  value = g_settings_get_string (atspi_settings, ATK_BRIDGE_LOCATION_KEY);
+
+  g_object_unref (atspi_settings);
+
+  return value;
+}
+
+static gboolean
+a11y_invoke_module (const char *module_path)
+{
+  GModule    *handle;
+  void      (*invoke_fn) (void);
+
+  if (!module_path)
+    {
+      g_warning ("Accessibility: invalid module path (NULL)");
+
+      return FALSE;
+    }
+
+  if (!(handle = g_module_open (module_path, (GModuleFlags)0)))
+    {
+      g_warning ("Accessibility: failed to load module '%s': '%s'",
+                 module_path, g_module_error ());
+
+      return FALSE;
+    }
+
+  if (!g_module_symbol (handle, INIT_METHOD, (gpointer *)&invoke_fn))
+    {
+      g_warning ("Accessibility: error library '%s' does not include "
+                 "method '%s' required for accessibility support",
+                 module_path, INIT_METHOD);
+      g_module_close (handle);
+
+      return FALSE;
+    }
+
+  invoke_fn ();
+
+  return TRUE;
+}
+
+void
+panel_a11y_init (void)
+{
+  gchar *bridge_path = NULL;
+
+  if (a11y_initialized)
+    return;
+
+  /* Restore environment to load AT bridge */
+  g_unsetenv ("NO_AT_BRIDGE");
+  g_unsetenv ("NO_GAIL");
+
+  if (!should_enable_a11y ())
+    return;
+
+  /* Load PanelUtilAccessible class */
+  g_type_class_unref (g_type_class_ref (PANEL_TYPE_UTIL_ACCESSIBLE));
+
+  bridge_path = get_atk_bridge_path ();
+  if (a11y_invoke_module (bridge_path))
+    {
+      g_debug ("Unity accessibility started, using bridge on %s", bridge_path);
+    }
+
+  g_free (bridge_path);
+
+  a11y_initialized = TRUE;
+}

=== added file 'services/panel-a11y.h'
--- services/panel-a11y.h	1970-01-01 00:00:00 +0000
+++ services/panel-a11y.h	2011-01-31 21:55:43 +0000
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#ifndef _PANEL_A11Y_H_
+#define _PANEL_A11Y_H_
+
+#include <glib-object.h>
+
+G_BEGIN_DECLS
+
+void panel_a11y_init (void);
+
+G_END_DECLS
+
+#endif

=== added file 'services/panel-indicator-accessible.c'
--- services/panel-indicator-accessible.c	1970-01-01 00:00:00 +0000
+++ services/panel-indicator-accessible.c	2011-01-31 21:55:43 +0000
@@ -0,0 +1,98 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#include <glib/gi18n.h>
+#include "panel-indicator-accessible.h"
+
+G_DEFINE_TYPE(PanelIndicatorAccessible, panel_indicator_accessible, ATK_TYPE_OBJECT)
+
+#define GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), PANEL_TYPE_INDICATOR_ACCESSIBLE, PanelIndicatorAccessiblePrivate))
+
+/* AtkObject methods */
+static void       panel_indicator_accessible_initialize     (AtkObject *accessible, gpointer data);
+static gint       panel_indicator_accessible_get_n_children (AtkObject *accessible);
+static AtkObject *panel_indicator_accessible_ref_child      (AtkObject *accessible, gint i);
+
+struct _PanelIndicatorAccessiblePrivate
+{
+};
+
+static void
+panel_indicator_accessible_class_init (PanelIndicatorAccessibleClass *klass)
+{
+  GObjectClass *object_class;
+  AtkObjectClass *atk_class;
+
+  /* GObject */
+  object_class = G_OBJECT_CLASS (klass);
+
+  /* AtkObject */
+  atk_class = ATK_OBJECT_CLASS (klass);
+  atk_class->initialize = panel_indicator_accessible_initialize;
+  atk_class->get_n_children = panel_indicator_accessible_get_n_children;
+  atk_class->ref_child = panel_indicator_accessible_ref_child;
+
+  g_type_class_add_private (object_class, sizeof (PanelIndicatorAccessiblePrivate));
+}
+
+static void
+panel_indicator_accessible_init (PanelIndicatorAccessible *pia)
+{
+  pia->priv = GET_PRIVATE (pia);
+}
+
+AtkObject *
+panel_indicator_accessible_new (void)
+{
+  AtkObject *accessible;
+
+  accessible = ATK_OBJECT (g_object_new (PANEL_TYPE_INDICATOR_ACCESSIBLE, NULL));
+
+  atk_object_initialize (accessible, NULL);
+
+  return accessible;
+}
+
+/* Implementation of AtkObject methods */
+
+static void
+panel_indicator_accessible_initialize (AtkObject *accessible, gpointer data)
+{
+  g_return_if_fail (PANEL_IS_INDICATOR_ACCESSIBLE (accessible));
+
+  ATK_OBJECT_CLASS (panel_indicator_accessible_parent_class)->initialize (accessible, data);
+
+  atk_object_set_name (accessible, _("An indicator")); /* FIXME */
+  atk_object_set_role (accessible, ATK_ROLE_LABEL);
+}
+
+static gint
+panel_indicator_accessible_get_n_children (AtkObject *accessible)
+{
+  g_return_val_if_fail (PANEL_IS_INDICATOR_ACCESSIBLE (accessible), 0);
+
+  return 0;
+}
+
+static AtkObject *
+panel_indicator_accessible_ref_child (AtkObject *accessible, gint i)
+{
+  g_return_val_if_fail (PANEL_IS_INDICATOR_ACCESSIBLE (accessible), NULL);
+
+  return NULL;
+}

=== added file 'services/panel-indicator-accessible.h'
--- services/panel-indicator-accessible.h	1970-01-01 00:00:00 +0000
+++ services/panel-indicator-accessible.h	2011-01-31 21:55:43 +0000
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#ifndef _PANEL_INDICATOR_ACCESSIBLE_H_
+#define _PANEL_INDICATOR_ACCESSIBLE_H_
+
+#include <atk/atk.h>
+
+G_BEGIN_DECLS
+
+#define PANEL_TYPE_INDICATOR_ACCESSIBLE (panel_indicator_accessible_get_type ())
+#define PANEL_INDICATOR_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), PANEL_TYPE_INDICATOR_ACCESSIBLE, PanelIndicatorAccessible))
+#define PANEL_INDICATOR_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), PANEL_TYPE_INDICATOR_ACCESSIBLE, PanelIndicatorAccessibleClass))
+#define PANEL_IS_INDICATOR_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), PANEL_TYPE_INDICATOR_ACCESSIBLE))
+#define PANEL_IS_INDICATOR_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), PANEL_TYPE_INDICATOR_ACCESSIBLE))
+#define PANEL_INDICATOR_ACCESSIBLE_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), PANEL_TYPE_INDICATOR_ACCESSIBLE, PanelIndicatorAccessibleClass))
+
+typedef struct _PanelIndicatorAccessible        PanelIndicatorAccessible;
+typedef struct _PanelIndicatorAccessibleClass   PanelIndicatorAccessibleClass;
+typedef struct _PanelIndicatorAccessiblePrivate PanelIndicatorAccessiblePrivate;
+
+struct _PanelIndicatorAccessible
+{
+  AtkObject                        parent;
+  PanelIndicatorAccessiblePrivate *priv;
+};
+
+struct _PanelIndicatorAccessibleClass
+{
+  AtkObjectClass parent_class;
+};
+
+GType      panel_indicator_accessible_get_type (void);
+AtkObject *panel_indicator_accessible_new (void);
+
+G_END_DECLS
+
+#endif

=== modified file 'services/panel-main.c'
--- services/panel-main.c	2011-01-11 15:48:03 +0000
+++ services/panel-main.c	2011-01-31 21:55:43 +0000
@@ -1,3 +1,4 @@
+// -*- Mode: C; tab-width:2; indent-tabs-mode: t; c-basic-offset: 2 -*-
 /*
  * Copyright (C) 2010 Canonical Ltd
  *
@@ -14,12 +15,14 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  *
  * Authored by: Neil Jagdish Patel <[e-mail]>
+ *              Rodrigo Moya <[e-mail]>
  */
 
 #include <glib.h>
 #include <gio/gio.h>
 #include <gtk/gtk.h>
 
+#include "panel-a11y.h"
 #include "panel-service.h"
 
 static GDBusNodeInfo *introspection_data = NULL;
@@ -299,10 +302,14 @@
   guint         owner_id;
 
   g_unsetenv("UBUNTU_MENUPROXY");
+  g_setenv ("NO_AT_BRIDGE", "1", TRUE);
+  g_unsetenv ("NO_GAIL");
 
   gtk_init (&argc, &argv);
-	gtk_icon_theme_append_search_path (gtk_icon_theme_get_default(),
-	                                   INDICATORICONDIR);
+  gtk_icon_theme_append_search_path (gtk_icon_theme_get_default(),
+				     INDICATORICONDIR);
+
+  panel_a11y_init ();
 
   introspection_data = g_dbus_node_info_new_for_xml (introspection_xml, NULL);
   g_assert (introspection_data != NULL);

=== added file 'services/panel-root-accessible.c'
--- services/panel-root-accessible.c	1970-01-01 00:00:00 +0000
+++ services/panel-root-accessible.c	2011-01-31 21:55:43 +0000
@@ -0,0 +1,123 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#include <glib/gi18n.h>
+#include "panel-indicator-accessible.h"
+#include "panel-root-accessible.h"
+#include "panel-service.h"
+
+G_DEFINE_TYPE(PanelRootAccessible, panel_root_accessible, ATK_TYPE_OBJECT)
+
+#define GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), PANEL_TYPE_ROOT_ACCESSIBLE, PanelRootAccessiblePrivate))
+
+/* AtkObject methods */
+static void       panel_root_accessible_initialize     (AtkObject *accessible, gpointer data);
+static gint       panel_root_accessible_get_n_children (AtkObject *accessible);
+static AtkObject *panel_root_accessible_ref_child      (AtkObject *accessible, gint i);
+static AtkObject *panel_root_accessible_get_parent     (AtkObject *accessible);
+
+struct _PanelRootAccessiblePrivate
+{
+};
+
+static void
+panel_root_accessible_class_init (PanelRootAccessibleClass *klass)
+{
+  GObjectClass *object_class;
+  AtkObjectClass *atk_class;
+
+  /* GObject */
+  object_class = G_OBJECT_CLASS (klass);
+
+  /* AtkObject */
+  atk_class = ATK_OBJECT_CLASS (klass);
+  atk_class->initialize = panel_root_accessible_initialize;
+  atk_class->get_n_children = panel_root_accessible_get_n_children;
+  atk_class->ref_child = panel_root_accessible_ref_child;
+  atk_class->get_parent = panel_root_accessible_get_parent;
+
+  g_type_class_add_private (object_class, sizeof (PanelRootAccessiblePrivate));
+}
+
+static void
+panel_root_accessible_init (PanelRootAccessible *root)
+{
+  root->priv = GET_PRIVATE (root);
+}
+
+AtkObject *
+panel_root_accessible_new (void)
+{
+  AtkObject *accessible;
+
+  accessible = ATK_OBJECT (g_object_new (PANEL_TYPE_ROOT_ACCESSIBLE, NULL));
+  atk_object_initialize (accessible, NULL);
+
+  return accessible;
+}
+
+/* Implementation of AtkObject methods */
+
+static void
+panel_root_accessible_initialize (AtkObject *accessible, gpointer data)
+{
+  g_return_if_fail (PANEL_IS_ROOT_ACCESSIBLE (accessible));
+
+  ATK_OBJECT_CLASS (panel_root_accessible_parent_class)->initialize (accessible, data);
+
+  accessible->role = ATK_ROLE_APPLICATION;
+  atk_object_set_name (accessible, g_get_prgname ());
+  atk_object_set_parent (accessible, NULL);
+}
+
+static gint
+panel_root_accessible_get_n_children (AtkObject *accessible)
+{
+  guint n_children;
+
+  g_return_val_if_fail (PANEL_IS_ROOT_ACCESSIBLE (accessible), 0);
+
+  n_children = panel_service_get_n_indicators (panel_service_get_default ());
+
+  g_debug ("PanelRootAccessible has %d children", n_children);
+
+  return n_children;
+}
+
+static AtkObject *
+panel_root_accessible_ref_child (AtkObject *accessible, gint i)
+{
+  AtkObject *child;
+
+  g_return_val_if_fail (PANEL_IS_ROOT_ACCESSIBLE (accessible), NULL);
+
+  child = panel_indicator_accessible_new (); /* FIXME */
+  atk_object_set_parent (child, accessible);
+
+  g_debug ("Returning ATK child %p", child);
+
+  return child;
+}
+
+static AtkObject *
+panel_root_accessible_get_parent (AtkObject *accessible)
+{
+	g_return_val_if_fail (PANEL_IS_ROOT_ACCESSIBLE (accessible), NULL);
+
+	return NULL;
+}

=== added file 'services/panel-root-accessible.h'
--- services/panel-root-accessible.h	1970-01-01 00:00:00 +0000
+++ services/panel-root-accessible.h	2011-01-31 21:55:43 +0000
@@ -0,0 +1,51 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#ifndef _PANEL_ROOT_ACCESSIBLE_H_
+#define _PANEL_ROOT_ACCESSIBLE_H_
+
+#include <atk/atk.h>
+
+G_BEGIN_DECLS
+
+#define PANEL_TYPE_ROOT_ACCESSIBLE (panel_root_accessible_get_type ())
+#define PANEL_ROOT_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), PANEL_TYPE_ROOT_ACCESSIBLE, PanelRootAccessible))
+#define PANEL_ROOT_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), PANEL_TYPE_ROOT_ACCESSIBLE, PanelRootAccessibleClass))
+#define PANEL_IS_ROOT_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), PANEL_TYPE_ROOT_ACCESSIBLE))
+#define PANEL_IS_ROOT_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), PANEL_TYPE_ROOT_ACCESSIBLE))
+#define PANEL_ROOT_ACCESSIBLE_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), PANEL_TYPE_ROOT_ACCESSIBLE, PanelRootAccessibleClass))
+
+typedef struct _PanelRootAccessible        PanelRootAccessible;
+typedef struct _PanelRootAccessibleClass   PanelRootAccessibleClass;
+typedef struct _PanelRootAccessiblePrivate PanelRootAccessiblePrivate;
+
+struct _PanelRootAccessible
+{
+	AtkObject                   parent;
+	PanelRootAccessiblePrivate *priv;
+};
+
+struct _PanelRootAccessibleClass
+{
+	AtkObjectClass parent_class;
+};
+
+GType      panel_root_accessible_get_type (void);
+AtkObject *panel_root_accessible_new      (void);
+
+#endif

=== added file 'services/panel-util-accessible.c'
--- services/panel-util-accessible.c	1970-01-01 00:00:00 +0000
+++ services/panel-util-accessible.c	2011-01-31 21:55:43 +0000
@@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#include "panel-root-accessible.h"
+#include "panel-util-accessible.h"
+
+G_DEFINE_TYPE(PanelUtilAccessible, panel_util_accessible, ATK_TYPE_UTIL)
+
+/* AtkUtil methods */
+static AtkObject   *panel_util_accessible_get_root (void);
+
+static AtkObject *root = NULL;
+
+/* GObject methods implementation */
+
+static void
+panel_util_accessible_class_init (PanelUtilAccessibleClass *klass)
+{
+  AtkUtilClass *atk_class;
+
+  g_debug ("Initializing PanelUtilAccessible class");
+
+  /* AtkUtil */
+  atk_class = g_type_class_peek (ATK_TYPE_UTIL);
+  atk_class->get_root = panel_util_accessible_get_root;
+}
+
+static void
+panel_util_accessible_init (PanelUtilAccessible *panel_util)
+{
+}
+
+/* AtkUtil methods implementation */
+
+static AtkObject *
+panel_util_accessible_get_root (void)
+{
+  if (!root)
+    root = panel_root_accessible_new ();
+
+  g_debug ("Returning root A11Y object at %p", root);
+
+  return root;
+}

=== added file 'services/panel-util-accessible.h'
--- services/panel-util-accessible.h	1970-01-01 00:00:00 +0000
+++ services/panel-util-accessible.h	2011-01-31 21:55:43 +0000
@@ -0,0 +1,51 @@
+/*
+ * Copyright (C) 2011 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Rodrigo Moya <[e-mail]>
+ */
+
+#ifndef _PANEL_UTIL_ACCESSIBLE_H_
+#define _PANEL_UTIL_ACCESSIBLE_H_
+
+#include <atk/atk.h>
+
+G_BEGIN_DECLS
+
+#define PANEL_TYPE_UTIL_ACCESSIBLE (panel_util_accessible_get_type ())
+
+#define PANEL_UTIL_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), PANEL_TYPE_UTIL_ACCESSIBLE, PanelUtilAccessible))
+#define PANEL_UTIL_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), PANEL_TYPE_UTIL_ACCESSIBLE, PanelUtilAccessibleClass))
+#define PANEL_IS_UTIL_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), PANEL_TYPE_UTIL_ACCESSIBLE))
+#define PANEL_IS_UTIL_ACCESSIBLE_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), PANEL_TYPE_UTIL_ACCESSIBLE))
+#define PANEL_UTIL_ACCESSIBLE_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), PANEL_TYPE_UTIL_ACCESSIBLE, PanelUtilAccessibleClass))
+
+typedef struct _PanelUtilAccessible      PanelUtilAccessible;
+typedef struct _PanelUtilAccessibleClass PanelUtilAccessibleClass;
+
+struct _PanelUtilAccessible
+{
+  AtkUtil parent;
+};
+
+struct _PanelUtilAccessibleClass
+{
+  AtkUtilClass parent_class;
+};
+
+GType panel_util_accessible_get_type (void);
+
+G_END_DECLS
+
+#endif