Merge lp:~rodrigo-moya/ubuntu/natty/nautilus/fix-662194 into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Rodrigo Moya
Status: Merged
Merged at revision: 130
Proposed branch: lp:~rodrigo-moya/ubuntu/natty/nautilus/fix-662194
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 54 lines (+27/-6)
2 files modified
debian/changelog (+8/-0)
debian/patches/02_dont_set_default.patch (+19/-6)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntu/natty/nautilus/fix-662194
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+54337@code.launchpad.net

Description of the change

Patch sent upstream for hiding the checkbox for folders

To post a comment you must log in.
130. By Rodrigo Moya

Set the checkbox to FALSE by default to avoid unwanted results

131. By Rodrigo Moya

Keep description in patch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-03-15 14:12:56 +0000
3+++ debian/changelog 2011-03-22 13:05:05 +0000
4@@ -1,3 +1,11 @@
5+nautilus (1:2.32.2.1-0ubuntu10) UNRELEASED; urgency=low
6+
7+ * debian/patches/02_dont_set_default.patch
8+ - Updated to hide 'Remember this app...' checkbox for directories in the
9+ 'Open with' dialog (LP: #662194)
10+
11+ -- Rodrigo Moya <rodrigo.moya@canonical.com> Tue, 22 Mar 2011 12:57:56 +0100
12+
13 nautilus (1:2.32.2.1-0ubuntu9) natty; urgency=low
14
15 * 17_disable_locked_automounting.patch: Fix g_bus_unwatch_name() assertion
16
17=== modified file 'debian/patches/02_dont_set_default.patch'
18--- debian/patches/02_dont_set_default.patch 2010-12-15 14:21:10 +0000
19+++ debian/patches/02_dont_set_default.patch 2011-03-22 13:05:05 +0000
20@@ -1,11 +1,11 @@
21 # Upstream: https://bugzilla.gnome.org/show_bug.cgi?id=637264
22 # Ubuntu: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/662194
23-# Description: don't change the default handler by default
24-Index: nautilus-2.32.2/libnautilus-private/nautilus-open-with-dialog.c
25-===================================================================
26---- nautilus-2.32.2.orig/libnautilus-private/nautilus-open-with-dialog.c 2010-12-15 13:36:33.076155730 +0100
27-+++ nautilus-2.32.2/libnautilus-private/nautilus-open-with-dialog.c 2010-12-15 13:36:47.000000000 +0100
28-@@ -864,7 +864,7 @@
29+# Description: hide checkbox to remember selection when opening folders
30+diff --git a/libnautilus-private/nautilus-open-with-dialog.c b/libnautilus-private/nautilus-open-with-dialog.c
31+index 357e20c..300a92c 100644
32+--- a/libnautilus-private/nautilus-open-with-dialog.c
33++++ b/libnautilus-private/nautilus-open-with-dialog.c
34+@@ -864,7 +864,7 @@ nautilus_open_with_dialog_init (NautilusOpenWithDialog *dialog)
35
36 /* Add remember this application checkbox - only visible in open mode */
37 dialog->details->checkbox = gtk_check_button_new ();
38@@ -14,3 +14,16 @@
39 gtk_button_set_use_underline (GTK_BUTTON (dialog->details->checkbox), TRUE);
40 gtk_widget_show (GTK_WIDGET (dialog->details->checkbox));
41 gtk_box_pack_start (GTK_BOX (vbox), dialog->details->checkbox, FALSE, FALSE, 0);
42+@@ -1031,6 +1031,12 @@ set_uri_and_type (NautilusOpenWithDialog *dialog,
43+ gtk_label_set_text_with_mnemonic (GTK_LABEL (dialog->details->open_label),
44+ _("_Add"));
45+ gtk_window_set_title (GTK_WINDOW (dialog), _("Add Application"));
46++ } else {
47++ if (g_str_equal (mime_type, "inode/directory")) {
48++ gtk_widget_hide (dialog->details->checkbox);
49++ } else {
50++ gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (dialog->details->checkbox), TRUE);
51++ }
52+ }
53+
54+ gtk_label_set_markup (GTK_LABEL (dialog->details->label), label);

Subscribers

People subscribed via source and target branches

to all changes: