Merge lp:~rodrigo-moya/ubuntu/maverick/json-glib/fix-756426 into lp:ubuntu/maverick/json-glib

Proposed by Rodrigo Moya
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp:~rodrigo-moya/ubuntu/maverick/json-glib/fix-756426
Merge into: lp:ubuntu/maverick/json-glib
Diff against target: 55 lines (+37/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/01_use_g_format_for_g_ascii_formatd.patch (+29/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntu/maverick/json-glib/fix-756426
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+57474@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

thanks uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-08-10 19:30:56 +0000
3+++ debian/changelog 2011-04-13 11:41:06 +0000
4@@ -1,3 +1,10 @@
5+json-glib (0.10.2-2ubuntu3) maverick-proposed; urgency=low
6+
7+ * debian/patches/01_use_g_format_for_g_ascii_formatd.patch:
8+ - Add upstream patch to fix serialization of doubles (LP: #756426)
9+
10+ -- Rodrigo Moya <rodrigo.moya@canonical.com> Wed, 13 Apr 2011 13:10:57 +0200
11+
12 json-glib (0.10.2-2ubuntu2) maverick; urgency=low
13
14 * Rebuild for the new gobject introspection
15
16=== added directory 'debian/patches'
17=== added file 'debian/patches/01_use_g_format_for_g_ascii_formatd.patch'
18--- debian/patches/01_use_g_format_for_g_ascii_formatd.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/01_use_g_format_for_g_ascii_formatd.patch 2011-04-13 11:41:06 +0000
20@@ -0,0 +1,29 @@
21+From f622ee8d8ba54ddea6fbb7311a905ffab7842e8d Mon Sep 17 00:00:00 2001
22+From: Emmanuele Bassi <ebassi@linux.intel.com>
23+Date: Thu, 18 Mar 2010 17:05:57 +0000
24+Subject: generator: Use %g format for g_ascii_formatd()
25+
26+I should read the documentation for the functions I use:
27+
28+ Converts a gdouble to a string, using the '.' as decimal point. To
29+ format the number you pass in a printf()-style format string. Allowed
30+ conversion specifiers are 'e', 'E', 'f', 'F', 'g' and 'G'.
31+ -- from g_ascii_formatd() in GLib's API reference
32+
33+Epic reading fail.
34+---
35+diff --git a/json-glib/json-generator.c b/json-glib/json-generator.c
36+index bad239b..c77830e 100644
37+--- a/json-glib/json-generator.c
38++++ b/json-glib/json-generator.c
39+@@ -309,7 +309,7 @@ dump_value (JsonGenerator *generator,
40+ {
41+ gchar buf[65];
42+
43+- g_ascii_formatd (buf, 65, "%d", g_value_get_double (&value));
44++ g_ascii_formatd (buf, 65, "%g", g_value_get_double (&value));
45+ g_string_append (buffer, buf);
46+ }
47+ break;
48+--
49+cgit v0.9
50
51=== added file 'debian/patches/series'
52--- debian/patches/series 1970-01-01 00:00:00 +0000
53+++ debian/patches/series 2011-04-13 11:41:06 +0000
54@@ -0,0 +1,1 @@
55+01_use_g_format_for_g_ascii_formatd.patch

Subscribers

People subscribed via source and target branches

to all changes: